Attachment 341217 Details for Bug 185955 – Patch

[patch] Patch

bug-185955-20180524125209.patch (text/plain), 1.79 KB, created by Brent Fulgham on 2018-05-24 12:52:09 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Brent Fulgham

Created: 2018-05-24 12:52:09 PDT

Size: 1.79 KB

patch

obsolete

>Subversion Revision: 232122
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 28edc121fb15a8f0eb2d55a69bcdbd5d0cc360e3..a6a230c366d665fb4c529325c8040777d4ce701a 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,22 @@
>+2018-05-24  Brent Fulgham  <bfulgham@apple.com>
>+
>+        REGRESSION(r224908): [macOS] Media playback not honoring custom caption styles
>+        https://bugs.webkit.org/show_bug.cgi?id=185955
>+        <rdar://problem/40339278>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        In r224908 I removed access to the MediaAccessibility mach port, as well as
>+        read/write access to various preferences associated with that process, as it
>+        was no longer needed by modern WebKit media routines.
>+
>+        Detailed testing reveals that read access is still needed to these preferences
>+        to properly handle custom caption styles.
>+
>+        This patch re-enables access to the media accessibility preferences.
>+
>+        * WebProcess/com.apple.WebProcess.sb.in:
>+
> 2018-05-23  Youenn Fablet  <youenn@apple.com>
> 
>         NetworkLoadChecker should check cached redirections
>diff --git a/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in b/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in
>index 833b518f3cf74b9212093d35331b7127f265db7b..24c3aec93f8baa6a19536c81a918ee256831a1a7 100644
>--- a/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in
>+++ b/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in
>@@ -477,6 +477,7 @@
>         "com.apple.driver.AppleBluetoothMultitouch.trackpad"
>         "com.apple.driver.AppleHIDMouse"
>         "com.apple.lookup.shared"
>+        "com.apple.mediaaccessibility" ;; Needed for custom caption styles
>         "com.apple.networkConnect"
>         "com.apple.speech.voice.prefs"
>         "com.apple.systemsound"

Actions: View | Formatted Diff | Diff

Attachments on bug 185955: 341217