Attachment 341206 Details for Bug 185831 – Patch

[patch] Patch

bug-185831-20180524103948.patch (text/plain), 2.37 KB, created by Sihui Liu on 2018-05-24 10:39:48 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Sihui Liu

Created: 2018-05-24 10:39:48 PDT

Size: 2.37 KB

patch

obsolete

>Subversion Revision: 232140
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 284a5c1c96a9f2a2a870f4446382f020ebda07c0..f6475d6477dda0fa8ba2643c1f99cf304df35e2f 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,15 @@
>+2018-05-24  Sihui Liu  <sihui_liu@apple.com>
>+
>+        [iOS] TestWebKitAPI.WebKit.WKHTTPCookieStoreWithoutProcessPool fails because cookies use different files with/without processpool
>+        https://bugs.webkit.org/show_bug.cgi?id=185831
>+        <rdar://problem/40468716>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
>+        (-[CookieUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
>+        (TEST):
>+
> 2018-05-23  Roy Reapor  <rreapor@apple.com>
> 
>         Use Helvetica on build.webkit.org webpages
>diff --git a/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm b/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm
>index deb09a127ea0e70dd7ea4592274045eebfc77871..6f77d916f19ec7b992661f972edb5e5cc9b438d0 100644
>--- a/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm
>+++ b/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm
>@@ -377,8 +377,7 @@ @end
> @implementation CookieUIDelegate
> - (void)webView:(WKWebView *)webView runJavaScriptAlertPanelWithMessage:(NSString *)message initiatedByFrame:(WKFrameInfo *)frame completionHandler:(void (^)(void))completionHandler
> {
>-    auto cookies = String(message.UTF8String);
>-    EXPECT_TRUE(cookies == "PersistentCookieName=CookieValue; SessionCookieName=CookieValue" || cookies == "SessionCookieName=CookieValue; PersistentCookieName=CookieValue");
>+    EXPECT_STREQ("PersistentCookieName=CookieValue,SessionCookieName=CookieValue", message.UTF8String);
>     finished = true;
>     completionHandler();
> }
>@@ -399,7 +398,7 @@ TEST(WebKit, WKHTTPCookieStoreWithoutProcessPool)
>         NSHTTPCookieDomain: @"127.0.0.1",
>         NSHTTPCookieExpires: [NSDate distantFuture],
>     }];
>-    NSString *alertCookieHTML = @"<script>alert(document.cookie);</script>";
>+    NSString *alertCookieHTML = @"<script>var cookies = document.cookie.split(';'); for (let i = 0; i < cookies.length; i ++) {cookies[i] = cookies[i].trim();} cookies.sort(); alert(cookies);</script>";
> 
>     // NonPersistentDataStore
>     RetainPtr<WKWebsiteDataStore> ephemeralStoreWithCookies = [WKWebsiteDataStore nonPersistentDataStore];

Actions: View | Formatted Diff | Diff

Attachments on bug 185831: 340990 | 341206 | 341464