WebKit Bugzilla
Attachment 341205 Details for
Bug 185950
: [ews-build] Unit-tests should run buildbot checkconfig
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Updated patch
ews_buildbot_checkconfig_v2.patch (text/plain), 1.85 KB, created by
Aakash Jain
on 2018-05-24 10:31:58 PDT
(
hide
)
Description:
Updated patch
Filename:
MIME Type:
Creator:
Aakash Jain
Created:
2018-05-24 10:31:58 PDT
Size:
1.85 KB
patch
obsolete
>Index: Tools/ChangeLog >=================================================================== >--- Tools/ChangeLog (revision 232153) >+++ Tools/ChangeLog (working copy) >@@ -1,3 +1,13 @@ >+2018-05-24 Aakash Jain <aakash_jain@apple.com> >+ >+ [ews-build] Unit-tests should run buildbot checkconfig >+ https://bugs.webkit.org/show_bug.cgi?id=185950 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * BuildSlaveSupport/ews-build/loadConfig_unittest.py: >+ (BuildbotCheckconfig.test_buildbot_checkconfig): Added unit-test to run buildbot checkconfig. >+ > 2018-05-24 Carlos Garcia Campos <cgarcia@igalia.com> > > WebDriver: implement maximize, minimize and fullscreen window commands >Index: Tools/BuildSlaveSupport/ews-build/loadConfig_unittest.py >=================================================================== >--- Tools/BuildSlaveSupport/ews-build/loadConfig_unittest.py (revision 232153) >+++ Tools/BuildSlaveSupport/ews-build/loadConfig_unittest.py (working copy) >@@ -23,6 +23,8 @@ > # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > > >+import os >+import subprocess > import unittest > > import loadConfig >@@ -33,6 +35,15 @@ class ConfigDotJSONTest(unittest.TestCas > loadConfig.loadBuilderConfig({}) > > >+class BuildbotCheckconfig(unittest.TestCase): >+ def test_buildbot_checkconfig(self): >+ cwd = os.path.dirname(os.path.abspath(__file__)) >+ checkconfig_process = subprocess.Popen(['buildbot', 'checkconfig'], cwd=cwd, stdout=subprocess.PIPE, stderr=subprocess.STDOUT) >+ (stdout, stderr) = checkconfig_process.communicate() >+ self.assertEqual(checkconfig_process.returncode, 0) >+ self.assertEqual(stdout, 'Config file is good!\n') >+ >+ > class TagsForBuilderTeest(unittest.TestCase): > def verifyTags(self, builderName, expectedTags): > tags = loadConfig.getTagsForBuilder({'name': builderName})
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 185950
:
341198
| 341205