Attachment 341185 Details for Bug 185944 – Patch

[patch] Patch

bug-185944-20180524151523.patch (text/plain), 3.42 KB, created by Dominik Inführ on 2018-05-24 06:15:24 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Dominik Inführ

Created: 2018-05-24 06:15:24 PDT

Size: 3.42 KB

patch

obsolete

>Subversion Revision: 232107
>diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog
>index 942850b124b95f06bed28ae494c6c6d2d89b9fc7..995f5bb480523861dad10414eb51c0cd2f252fb2 100644
>--- a/Source/JavaScriptCore/ChangeLog
>+++ b/Source/JavaScriptCore/ChangeLog
>@@ -1,3 +1,15 @@
>+2018-05-24  Dominik Infuehr  <dinfuehr@igalia.com>
>+
>+        [MIPS] Fix build on MIPS32r1
>+        https://bugs.webkit.org/show_bug.cgi?id=185944
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Only use instructions on MIPS32r2 or later. mthc1 and mfhc1 are not supported
>+        on MIPS32r1.
>+
>+        * offlineasm/mips.rb:
>+
> 2018-05-22  Yusuke Suzuki  <utatane.tea@gmail.com>
> 
>         [JSC] Clean up stringGetByValStubGenerator
>diff --git a/Source/WTF/ChangeLog b/Source/WTF/ChangeLog
>index 1c667d0a4ce9964a40d15eeddb71d1b1324a5498..a7b7139642a1a1618828a675feee2b586ea309c0 100644
>--- a/Source/WTF/ChangeLog
>+++ b/Source/WTF/ChangeLog
>@@ -1,3 +1,14 @@
>+2018-05-24  Dominik Infuehr  <dinfuehr@igalia.com>
>+
>+        [MIPS] Fix build on MIPS32r1
>+        https://bugs.webkit.org/show_bug.cgi?id=185944
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Added WTF_MIPS_ISA_REV_AT_LEAST to test for certain release or later.
>+
>+        * wtf/Platform.h:
>+
> 2018-05-22  Mark Lam  <mark.lam@apple.com>
> 
>         StringImpl utf8 conversion should not fail silently.
>diff --git a/Source/JavaScriptCore/offlineasm/mips.rb b/Source/JavaScriptCore/offlineasm/mips.rb
>index 32eea5ad1a7d60c8020a1014e17f20e1b7673cc2..df19c6ba03e159fcb9339df1ef8204baa2102a68 100644
>--- a/Source/JavaScriptCore/offlineasm/mips.rb
>+++ b/Source/JavaScriptCore/offlineasm/mips.rb
>@@ -1014,10 +1014,18 @@ class Instruction
>             $asm.puts "sw #{operands[1].mipsOperand}, #{operands[0].value * 4}($sp)"
>         when "fii2d"
>             $asm.puts "mtc1 #{operands[0].mipsOperand}, #{operands[2].mipsSingleLo}"
>+            $asm.putStr("#if WTF_MIPS_ISA_REV_AT_LEAST(2)")
>             $asm.puts "mthc1 #{operands[1].mipsOperand}, #{operands[2].mipsSingleLo}"
>+            $asm.putStr("#else")
>+            $asm.puts "mtc1 #{operands[1].mipsOperand}, #{operands[2].mipsSingleHi}"
>+            $asm.putStr("#endif")
>         when "fd2ii"
>             $asm.puts "mfc1 #{operands[1].mipsOperand}, #{operands[0].mipsSingleLo}"
>+            $asm.putStr("#if WTF_MIPS_ISA_REV_AT_LEAST(2)")
>             $asm.puts "mfhc1 #{operands[2].mipsOperand}, #{operands[0].mipsSingleLo}"
>+            $asm.putStr("#else")
>+            $asm.puts "mfc1 #{operands[2].mipsOperand}, #{operands[0].mipsSingleHi}"
>+            $asm.putStr("#endif")
>         when /^bo/
>             $asm.puts "bgt #{operands[0].mipsOperand}, #{operands[1].mipsOperand}, #{operands[2].asmLabel}"
>         when /^bs/
>diff --git a/Source/WTF/wtf/Platform.h b/Source/WTF/wtf/Platform.h
>index c7d0ca00fbf016f582c23c1ae7de0e28c9ec878c..e919685b69fca793af452430791dc4b43abc6ddc 100644
>--- a/Source/WTF/wtf/Platform.h
>+++ b/Source/WTF/wtf/Platform.h
>@@ -74,6 +74,7 @@
> #define WTF_MIPS_ISA_AT_LEAST(v) (defined WTF_MIPS_ARCH && WTF_MIPS_ARCH >= v)
> #define WTF_MIPS_ARCH_REV __mips_isa_rev
> #define WTF_MIPS_ISA_REV(v) (defined WTF_MIPS_ARCH_REV && WTF_MIPS_ARCH_REV == v)
>+#define WTF_MIPS_ISA_REV_AT_LEAST(v) (defined WTF_MIPS_ARCH_REV && WTF_MIPS_ARCH_REV >= v)
> #define WTF_MIPS_DOUBLE_FLOAT (defined __mips_hard_float && !defined __mips_single_float)
> #define WTF_MIPS_FP64 (defined __mips_fpr && __mips_fpr == 64)
> /* MIPS requires allocators to use aligned memory */

Actions: View | Formatted Diff | Diff

Attachments on bug 185944: 341185