Attachment 341137 Details for Bug 183885 – Patch

[patch] Patch

bug-183885-20180523154240.patch (text/plain), 4.46 KB, created by Chris Dumez on 2018-05-23 15:42:40 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Dumez

Created: 2018-05-23 15:42:40 PDT

Size: 4.46 KB

patch

obsolete

>Subversion Revision: 232125
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 50c0bbb10b4c1dd359c03fe10456544e7138bcc1..61754c69616854ad57d4029fc8e950b1fd8fad23 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,20 @@
>+2018-05-23  Chris Dumez  <cdumez@apple.com>
>+
>+        Regression(r229831): fast/loader/javascript-url-iframe-remove-on-navigate-async-delegate.html is flaky
>+        https://bugs.webkit.org/show_bug.cgi?id=183885
>+        <rdar://problem/38733968>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Stop loading an external URL as this is not what the test is testing and since the error message for
>+        the external load causes flakiness.
>+
>+        * TestExpectations:
>+        * fast/loader/javascript-url-iframe-remove-on-navigate-async-delegate-expected.txt:
>+        * fast/loader/javascript-url-iframe-remove-on-navigate-async-delegate.html:
>+        * fast/loader/javascript-url-iframe-remove-on-navigate-expected.txt:
>+        * fast/loader/javascript-url-iframe-remove-on-navigate.html:
>+
> 2018-05-23  Chris Dumez  <cdumez@apple.com>
> 
>         RenderLayer::scrollRectToVisible() should not propagate a subframe's scroll to its cross-origin parent
>diff --git a/LayoutTests/TestExpectations b/LayoutTests/TestExpectations
>index edbf6943aace635df38bf9969d2c305bfcbf6602..dc67101fecc04d791467d2ddc33d19d72c09a3ad 100644
>--- a/LayoutTests/TestExpectations
>+++ b/LayoutTests/TestExpectations
>@@ -1976,10 +1976,6 @@ http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-css-i
> 
> media/event-queue-crash.html [ DumpJSConsoleLogInStdErr ]
> 
>-# This is flaky since r229831.
>-webkit.org/b/183885 fast/loader/javascript-url-iframe-remove-on-navigate.html [ Pass Failure ]
>-webkit.org/b/183885 fast/loader/javascript-url-iframe-remove-on-navigate-async-delegate.html [ Pass Failure ]
>-
> webkit.org/b/172243 imported/w3c/web-platform-tests/IndexedDB/idbdatabase-createObjectStore-exception-order.htm [ Pass Failure ]
> 
> webkit.org/b/179851 imported/w3c/web-platform-tests/html/browsers/offline/manifest_url_check.html [ Pass Failure ]
>diff --git a/LayoutTests/fast/loader/javascript-url-iframe-remove-on-navigate-async-delegate-expected.txt b/LayoutTests/fast/loader/javascript-url-iframe-remove-on-navigate-async-delegate-expected.txt
>index 7b4df6687d9884a71f05c321dde43190482539cf..291bbd07a3c85c3bf5b13d0007cc7a001452e7f1 100644
>--- a/LayoutTests/fast/loader/javascript-url-iframe-remove-on-navigate-async-delegate-expected.txt
>+++ b/LayoutTests/fast/loader/javascript-url-iframe-remove-on-navigate-async-delegate-expected.txt
>@@ -1,2 +1 @@
>-Blocked access to external URL http://does.not.exist/
> PASS - Javascript URL blocked without crashing.
>diff --git a/LayoutTests/fast/loader/javascript-url-iframe-remove-on-navigate-async-delegate.html b/LayoutTests/fast/loader/javascript-url-iframe-remove-on-navigate-async-delegate.html
>index c04150e06862a7cdaabfac77fefb120a073eda40..a3f633c73c8128a32ccf5be65da073a9868d091c 100644
>--- a/LayoutTests/fast/loader/javascript-url-iframe-remove-on-navigate-async-delegate.html
>+++ b/LayoutTests/fast/loader/javascript-url-iframe-remove-on-navigate-async-delegate.html
>@@ -1,4 +1,4 @@
>-<iframe src="http://does.not.exist/" id="target"></iframe>
>+<iframe src="resources/empty-subframe.html" id="target"></iframe>
> <script>
> if (window.testRunner) {
>     testRunner.dumpAsText();
>diff --git a/LayoutTests/fast/loader/javascript-url-iframe-remove-on-navigate-expected.txt b/LayoutTests/fast/loader/javascript-url-iframe-remove-on-navigate-expected.txt
>index 7b4df6687d9884a71f05c321dde43190482539cf..291bbd07a3c85c3bf5b13d0007cc7a001452e7f1 100644
>--- a/LayoutTests/fast/loader/javascript-url-iframe-remove-on-navigate-expected.txt
>+++ b/LayoutTests/fast/loader/javascript-url-iframe-remove-on-navigate-expected.txt
>@@ -1,2 +1 @@
>-Blocked access to external URL http://does.not.exist/
> PASS - Javascript URL blocked without crashing.
>diff --git a/LayoutTests/fast/loader/javascript-url-iframe-remove-on-navigate.html b/LayoutTests/fast/loader/javascript-url-iframe-remove-on-navigate.html
>index 1501e2c3adb252a43ad5477982c77db73012600b..af3764dfdc2b91185ca38528cfd932ee1a4f5506 100644
>--- a/LayoutTests/fast/loader/javascript-url-iframe-remove-on-navigate.html
>+++ b/LayoutTests/fast/loader/javascript-url-iframe-remove-on-navigate.html
>@@ -1,4 +1,4 @@
>-<iframe src="http://does.not.exist/" id="target"></iframe>
>+<iframe src="resources/empty-subframe.html" id="target"></iframe>
> <script>
> if (window.testRunner) {
>     testRunner.dumpAsText();

Actions: View | Formatted Diff | Diff

Attachments on bug 183885: 341137 | 341160