Attachment 341110 Details for Bug 183744 – [Patch] Instrument unti tests to dump timing info

[patch] [Patch] Instrument unti tests to dump timing info

InstrumentedSerialMeasurements.diff (text/plain), 8.28 KB, created by Daniel Bates on 2018-05-23 11:21:13 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Daniel Bates

Created: 2018-05-23 11:21:13 PDT

Size: 8.28 KB

patch

obsolete

>diff --git a/Tools/Scripts/webkitpy/test/main.py b/Tools/Scripts/webkitpy/test/main.py
>index 806ffbb9da4..72e5292b214 100644
>--- a/Tools/Scripts/webkitpy/test/main.py
>+++ b/Tools/Scripts/webkitpy/test/main.py
>@@ -70,7 +70,7 @@ def main():
>     webkit_root = up(up(up(up(up(os.path.abspath(__file__))))))
> 
>     tester = Tester()
>-    tester.add_tree(os.path.join(webkit_root, 'Tools', 'Scripts'), 'webkitpy')
>+    #tester.add_tree(os.path.join(webkit_root, 'Tools', 'Scripts'), 'webkitpy')
> 
>     # There is no WebKit2 on Windows, so we don't need to run WebKit2 unittests on it.
>     if not (sys.platform.startswith('win') or sys.platform == 'cygwin'):
>diff --git a/Tools/lldb/lldb_webkit_unittest.py b/Tools/lldb/lldb_webkit_unittest.py
>index 7a5628d4508..e377d832b59 100755
>--- a/Tools/lldb/lldb_webkit_unittest.py
>+++ b/Tools/lldb/lldb_webkit_unittest.py
>@@ -27,6 +27,7 @@ import lldb
> import lldb_webkit
> import os
> import sys
>+import time
> import unittest
> 
> from webkitpy.common.system.systemhost import SystemHost
>@@ -76,36 +77,84 @@ class TestSummaryProviders(unittest.TestCase):
> 
>     # MARK: WTFStringImpl_SummaryProvider test cases
> 
>-    def stateless_process_test_WTFStringImpl_SummaryProvider_null_string(self):
>-        summary = lldb_webkit.WTFStringImpl_SummaryProvider(self.sbFrame.FindVariable('aNullStringImpl'), {})
>+    def serial_test_WTFStringImpl_SummaryProvider_null_string(self):
>+        start_time = time.time()
>+        temp = self.sbFrame.FindVariable('aNullStringImpl')
>+        print >> sys.stderr, ''
>+        print >> sys.stderr, '\t[serial_test_WTFStringImpl_SummaryProvider_null_string] Took {}ms to find variable'.format((time.time() - start_time) * 1000.0)
>+        start_time = time.time()
>+        summary = lldb_webkit.WTFStringImpl_SummaryProvider(temp, {})
>+        print >> sys.stderr, '\t[serial_test_WTFStringImpl_SummaryProvider_null_string] Took {}ms to run WTFStringImpl_SummaryProvider'.format((time.time() - start_time) * 1000.0)
>         self.assertEqual(summary, "{ length = 0, is8bit = 1, contents = '' }")
> 
>-    def stateless_process_test_WTFStringImpl_SummaryProvider_empty_string(self):
>-        summary = lldb_webkit.WTFStringImpl_SummaryProvider(self.sbFrame.FindVariable('anEmptyStringImpl'), {})
>+    def serial_test_WTFStringImpl_SummaryProvider_empty_string(self):
>+        start_time = time.time()
>+        temp = self.sbFrame.FindVariable('anEmptyStringImpl')
>+        print >> sys.stderr, ''
>+        print >> sys.stderr, '\t[serial_test_WTFStringImpl_SummaryProvider_empty_string] Took {}ms to find variable'.format((time.time() - start_time) * 1000.0)
>+        start_time = time.time()
>+        summary = lldb_webkit.WTFStringImpl_SummaryProvider(temp, {})
>+        print >> sys.stderr, '\t[serial_test_WTFStringImpl_SummaryProvider_empty_string] Took {}ms to run WTFStringImpl_SummaryProvider'.format((time.time() - start_time) * 1000.0)
>         self.assertEqual(summary, "{ length = 0, is8bit = 1, contents = '' }")
> 
>-    def stateless_process_test_WTFStringImpl_SummaryProvider_8bit_string(self):
>-        summary = lldb_webkit.WTFStringImpl_SummaryProvider(self.sbFrame.FindVariable('an8BitStringImpl'), {})
>+    def serial_test_WTFStringImpl_SummaryProvider_8bit_string(self):
>+        start_time = time.time()
>+        temp = self.sbFrame.FindVariable('an8BitStringImpl')
>+        print >> sys.stderr, ''
>+        print >> sys.stderr, '\t[serial_test_WTFStringImpl_SummaryProvider_8bit_string] Took {}ms to find variable'.format((time.time() - start_time) * 1000.0)
>+        start_time = time.time()
>+        summary = lldb_webkit.WTFStringImpl_SummaryProvider(temp, {})
>+        print >> sys.stderr, '\t[serial_test_WTFStringImpl_SummaryProvider_8bit_string] Took {}ms to run WTFStringImpl_SummaryProvider'.format((time.time() - start_time) * 1000.0)
>         self.assertEqual(summary, "{ length = 8, is8bit = 1, contents = 'r\\xe9sum\\xe9' }")
> 
>-    def stateless_process_test_WTFStringImpl_SummaryProvider_16bit_string(self):
>-        summary = lldb_webkit.WTFStringImpl_SummaryProvider(self.sbFrame.FindVariable('a16BitStringImpl'), {})
>+    def serial_test_WTFStringImpl_SummaryProvider_16bit_string(self):
>+        start_time = time.time()
>+        temp = self.sbFrame.FindVariable('a16BitStringImpl')
>+        print >> sys.stderr, ''
>+        print >> sys.stderr, '\t[serial_test_WTFStringImpl_SummaryProvider_16bit_string] Took {}ms to find variable'.format((time.time() - start_time) * 1000.0)
>+        start_time = time.time()
>+        summary = lldb_webkit.WTFStringImpl_SummaryProvider(temp, {})
>+        print >> sys.stderr, '\t[serial_test_WTFStringImpl_SummaryProvider_16bit_string] Took {}ms to run WTFStringImpl_SummaryProvider'.format((time.time() - start_time) * 1000.0)
>         self.assertEqual(summary, u"{ length = 13, is8bit = 0, contents = '\\u1680Cappuccino\\u1680\\x00' }")
> 
>     # MARK: WTFString_SummaryProvider test cases
> 
>-    def stateless_process_test_WTFString_SummaryProvider_null_string(self):
>-        summary = lldb_webkit.WTFString_SummaryProvider(self.sbFrame.FindVariable('aNullString'), {})
>+    def serial_test_WTFString_SummaryProvider_null_string(self):
>+        start_time = time.time()
>+        temp = self.sbFrame.FindVariable('aNullString')
>+        print >> sys.stderr, ''
>+        print >> sys.stderr, '\t[serial_test_WTFString_SummaryProvider_null_string] Took {}ms to find variable'.format((time.time() - start_time) * 1000.0)
>+        start_time = time.time()
>+        summary = lldb_webkit.WTFString_SummaryProvider(temp, {})
>+        print >> sys.stderr, '\t[serial_test_WTFString_SummaryProvider_null_string] Took {}ms to run WTFString_SummaryProvider'.format((time.time() - start_time) * 1000.0)
>         self.assertEqual(summary, "{ length = 0, contents = '' }")
> 
>-    def stateless_process_test_WTFString_SummaryProvider_empty_string(self):
>-        summary = lldb_webkit.WTFString_SummaryProvider(self.sbFrame.FindVariable('anEmptyString'), {})
>+    def serial_test_WTFString_SummaryProvider_empty_string(self):
>+        start_time = time.time()
>+        temp = self.sbFrame.FindVariable('anEmptyString')
>+        print >> sys.stderr, ''
>+        print >> sys.stderr, '\t[serial_test_WTFString_SummaryProvider_empty_string] Took {}ms to find variable'.format((time.time() - start_time) * 1000.0)
>+        start_time = time.time()
>+        summary = lldb_webkit.WTFString_SummaryProvider(temp, {})
>+        print >> sys.stderr, '\t[serial_test_WTFString_SummaryProvider_empty_string] Took {}ms to run WTFString_SummaryProvider'.format((time.time() - start_time) * 1000.0)
>         self.assertEqual(summary, "{ length = 0, contents = '' }")
> 
>-    def stateless_process_test_WTFString_SummaryProvider_8bit_string(self):
>-        summary = lldb_webkit.WTFString_SummaryProvider(self.sbFrame.FindVariable('an8BitString'), {})
>+    def serial_test_WTFString_SummaryProvider_8bit_string(self):
>+        start_time = time.time()
>+        temp = self.sbFrame.FindVariable('an8BitString')
>+        print >> sys.stderr, ''
>+        print >> sys.stderr, '\t[serial_test_WTFString_SummaryProvider_8bit_string] Took {}ms to find variable'.format((time.time() - start_time) * 1000.0)
>+        start_time = time.time()
>+        summary = lldb_webkit.WTFString_SummaryProvider(temp, {})
>+        print >> sys.stderr, '\t[serial_test_WTFString_SummaryProvider_8bit_string] Took {}ms to run WTFString_SummaryProvider'.format((time.time() - start_time) * 1000.0)
>         self.assertEqual(summary, "{ length = 8, contents = 'r\\xe9sum\\xe9' }")
> 
>-    def stateless_process_test_WTFString_SummaryProvider_16bit_string(self):
>-        summary = lldb_webkit.WTFString_SummaryProvider(self.sbFrame.FindVariable('a16BitString'), {})
>+    def serial_test_WTFString_SummaryProvider_16bit_string(self):
>+        start_time = time.time()
>+        temp = self.sbFrame.FindVariable('a16BitString')
>+        print >> sys.stderr, ''
>+        print >> sys.stderr, '\t[serial_test_WTFString_SummaryProvider_16bit_string] Took {}ms to find variable'.format((time.time() - start_time) * 1000.0)
>+        start_time = time.time()
>+        summary = lldb_webkit.WTFString_SummaryProvider(temp, {})
>+        print >> sys.stderr, '\t[serial_test_WTFString_SummaryProvider_16bit_string] Took {}ms to run WTFString_SummaryProvider'.format((time.time() - start_time) * 1000.0)
>         self.assertEqual(summary, u"{ length = 13, contents = '\\u1680Cappuccino\\u1680\\x00' }")

Actions: View | Formatted Diff | Diff

Attachments on bug 183744: 336054 | 336055 | 336057 | 340870 | 340913 | 341110 | 341210 | 341388 | 341691 | 341712 | 341714 | 341716 | 341731 | 341733 | 341791 | 341794 | 343791