WebKit Bugzilla
Attachment 341090 Details for
Bug 185436
: Conversion misspelled "Convertion" in error message string
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
patch
0001-Fix-typo-Convertion-Conversion-in-error-message-stri.patch (text/plain), 3.23 KB, created by
Rick Waldron
on 2018-05-23 07:39:29 PDT
(
hide
)
Description:
patch
Filename:
MIME Type:
Creator:
Rick Waldron
Created:
2018-05-23 07:39:29 PDT
Size:
3.23 KB
patch
obsolete
>From 284c06fc78457dd08a810e4a74e7c158ac0bc1d2 Mon Sep 17 00:00:00 2001 >From: Rick Waldron <waldron.rick@gmail.com> >Date: Tue, 8 May 2018 14:40:31 -0400 >Subject: [PATCH] Fix typo "Convertion" => "Conversion" in error message > string. > >--- > JSTests/ChangeLog | 9 +++++++++ > JSTests/bigIntTests.yaml | 3 +++ > JSTests/stress/big-int-no-conversion-to-number.js | 12 ++++++++++++ > Source/JavaScriptCore/ChangeLog | 10 ++++++++++ > Source/JavaScriptCore/runtime/JSBigInt.cpp | 2 +- > 5 files changed, 35 insertions(+), 1 deletion(-) > create mode 100644 JSTests/stress/big-int-no-conversion-to-number.js > >diff --git a/JSTests/ChangeLog b/JSTests/ChangeLog >index 2b12bffe20..1a2ce23e1d 100644 >--- a/JSTests/ChangeLog >+++ b/JSTests/ChangeLog >@@ -1,3 +1,12 @@ >+2018-05-23 Rick Waldron <waldron.rick@gmail.com> >+ >+ Conversion misspelled "Convertion" in error message string >+ https://bugs.webkit.org/show_bug.cgi?id=185436 >+ >+ Reviewed by Saam Barati, Michael Saboff. >+ >+ * bigIntTests.yaml: >+ > 2018-05-23 Yusuke Suzuki <utatane.tea@gmail.com> > > Unreviewed, skip test if memoryLimited is specified >diff --git a/JSTests/bigIntTests.yaml b/JSTests/bigIntTests.yaml >index 4ff994ff50..1b05d6990d 100644 >--- a/JSTests/bigIntTests.yaml >+++ b/JSTests/bigIntTests.yaml >@@ -135,3 +135,6 @@ > > - path: stress/big-int-division.js > cmd: runBigIntEnabled >+ >+- path: stress/big-int-no-conversion-to-number.js >+ cmd: runBigIntEnabled >diff --git a/JSTests/stress/big-int-no-conversion-to-number.js b/JSTests/stress/big-int-no-conversion-to-number.js >new file mode 100644 >index 0000000000..f380b57522 >--- /dev/null >+++ b/JSTests/stress/big-int-no-conversion-to-number.js >@@ -0,0 +1,12 @@ >+//@ runBigIntEnabled >+ >+let message; >+try { >+ 1n + 1; >+} catch (error) { >+ message = error.message; >+} >+ >+if (message !== "Conversion from 'BigInt' to 'number' is not allowed.") { >+ throw new Error("Error message has changed to something unexpected"); >+} >diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog >index 942850b124..5d6abeb4cf 100644 >--- a/Source/JavaScriptCore/ChangeLog >+++ b/Source/JavaScriptCore/ChangeLog >@@ -1,3 +1,13 @@ >+2018-05-23 Rick Waldron <waldron.rick@gmail.com> >+ >+ Conversion misspelled "Convertion" in error message string >+ https://bugs.webkit.org/show_bug.cgi?id=185436 >+ >+ Reviewed by Saam Barati, Michael Saboff >+ >+ * runtime/JSBigInt.cpp: >+ (JSC::JSBigInt::toNumber const): >+ > 2018-05-22 Yusuke Suzuki <utatane.tea@gmail.com> > > [JSC] Clean up stringGetByValStubGenerator >diff --git a/Source/JavaScriptCore/runtime/JSBigInt.cpp b/Source/JavaScriptCore/runtime/JSBigInt.cpp >index 460775d248..0e021f1380 100644 >--- a/Source/JavaScriptCore/runtime/JSBigInt.cpp >+++ b/Source/JavaScriptCore/runtime/JSBigInt.cpp >@@ -1026,7 +1026,7 @@ double JSBigInt::toNumber(ExecState* state) const > { > VM& vm = state->vm(); > auto scope = DECLARE_THROW_SCOPE(vm); >- throwTypeError(state, scope, ASCIILiteral("Convertion from 'BigInt' to 'number' is not allowed.")); >+ throwTypeError(state, scope, ASCIILiteral("Conversion from 'BigInt' to 'number' is not allowed.")); > return 0.0; > } > >-- >2.15.1 (Apple Git-101) >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 185436
:
339848
|
339963
| 341090