Attachment 341052 Details for Bug 185896 – proposed patch.

[patch] proposed patch.

bug-185896.patch (text/plain), 2.67 KB, created by Mark Lam on 2018-05-22 17:54:11 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Mark Lam

Created: 2018-05-22 17:54:11 PDT

Size: 2.67 KB

patch

obsolete

>Index: JSTests/ChangeLog
>===================================================================
>--- JSTests/ChangeLog	(revision 232093)
>+++ JSTests/ChangeLog	(working copy)
>@@ -1,3 +1,13 @@
>+2018-05-22  Mark Lam  <mark.lam@apple.com>
>+
>+        BytecodeGeneratorification shouldn't add a ValueProfile if the JIT is disabled.
>+        https://bugs.webkit.org/show_bug.cgi?id=185896
>+        <rdar://problem/40471403>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * stress/regress-185896.js: Added.
>+
> 2018-05-22  Yusuke Suzuki  <utatane.tea@gmail.com>
> 
>         [JSC] Fix CachedCall's argument count if RegExp has named captures
>Index: JSTests/stress/regress-185896.js
>===================================================================
>--- JSTests/stress/regress-185896.js	(nonexistent)
>+++ JSTests/stress/regress-185896.js	(working copy)
>@@ -0,0 +1,14 @@
>+var exception;
>+function* items() {
>+    yield { };
>+    yield* 42;
>+}
>+
>+try {
>+    for (let i of items()) { }
>+} catch (e) {
>+    exception = e;
>+}
>+
>+if (exception != "TypeError: undefined is not a function (near '...yield* 42...')")
>+    throw FAILED;
>Index: Source/JavaScriptCore/ChangeLog
>===================================================================
>--- Source/JavaScriptCore/ChangeLog	(revision 232089)
>+++ Source/JavaScriptCore/ChangeLog	(working copy)
>@@ -1,3 +1,14 @@
>+2018-05-22  Mark Lam  <mark.lam@apple.com>
>+
>+        BytecodeGeneratorification shouldn't add a ValueProfile if the JIT is disabled.
>+        https://bugs.webkit.org/show_bug.cgi?id=185896
>+        <rdar://problem/40471403>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * bytecode/BytecodeGeneratorification.cpp:
>+        (JSC::BytecodeGeneratorification::run):
>+
> 2018-05-22  Mark Lam  <mark.lam@apple.com>
> 
>         StringImpl utf8 conversion should not fail silently.
>Index: Source/JavaScriptCore/bytecode/BytecodeGeneratorification.cpp
>===================================================================
>--- Source/JavaScriptCore/bytecode/BytecodeGeneratorification.cpp	(revision 232087)
>+++ Source/JavaScriptCore/bytecode/BytecodeGeneratorification.cpp	(working copy)
>@@ -229,7 +229,9 @@ void BytecodeGeneratorification::run()
>                 VirtualRegister operand = virtualRegisterForLocal(index);
>                 Storage storage = storageForGeneratorLocal(index);
> 
>-                UnlinkedValueProfile profile = m_codeBlock->addValueProfile();
>+                UnlinkedValueProfile profile = m_codeBlock->vm()->canUseJIT()
>+                    ? m_codeBlock->addValueProfile()
>+                    : static_cast<UnlinkedValueProfile>(-1);
>                 fragment.appendInstruction(
>                     op_get_from_scope,
>                     operand.offset(), // dst

Flags:

saam: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 185896: 341052