Attachment 340995 Details for Bug 185874 – Patch

[patch] Patch

bug-185874-20180522111547.patch (text/plain), 2.24 KB, created by Brent Fulgham on 2018-05-22 11:15:47 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Brent Fulgham

Created: 2018-05-22 11:15:47 PDT

Size: 2.24 KB

patch

obsolete

>Subversion Revision: 232069
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 545439bf4e71e242821e21896310fb0adf8e257f..90c4fa7ac62684a3eefaa095d2d7974988bc38d6 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-05-22  Brent Fulgham  <bfulgham@apple.com>
>+
>+        REGRESSION(r229093): Re-enable Network Extension support in the WebContent process (Take 2)
>+        https://bugs.webkit.org/show_bug.cgi?id=185874
>+        <rdar://problem/40454404>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Add back a necessary XPC connection after locking down the network features in r229093.
>+
>+        * Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
>+        * WebProcess/com.apple.WebProcess.sb.in:
>+
> 2018-05-22  Ryan Haddad  <ryanhaddad@apple.com>
> 
>         Unreviewed, rolling out r232052.
>diff --git a/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb b/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb
>index 7e655426c796b7dae6624416c44576c9479ef427..9d91f542faa2969c1e111c7fea726aff5ae328a8 100644
>--- a/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb
>+++ b/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb
>@@ -113,7 +113,8 @@
> 
> ;; Network Extensions / VPN helper.
> (allow mach-lookup
>-    (global-name "com.apple.nehelper"))
>+    (global-name "com.apple.nehelper")
>+    (global-name "com.apple.nesessionmanager"))
> 
> ;; allow 3rd party applications to access nsurlstoraged's top level domain data cache
> (allow-well-known-system-group-container-literal-read
>diff --git a/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in b/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in
>index e335aa051e3c794e12ed487fc2acb66cdb0f8fc8..833b518f3cf74b9212093d35331b7127f265db7b 100644
>--- a/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in
>+++ b/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in
>@@ -656,7 +656,8 @@
> 
> ;; Network Extensions / VPN helper.
> (allow mach-lookup
>-    (global-name "com.apple.nehelper"))
>+    (global-name "com.apple.nehelper")
>+    (global-name "com.apple.nesessionmanager"))
> 
> #if PLATFORM(MAC)
> ;; FIXME should be removed when <rdar://problem/9347205> + related radar in Safari is fixed

Actions: View | Formatted Diff | Diff

Attachments on bug 185874: 340995