Attachment 340948 Details for Bug 185857 – Cleanup

[patch] Cleanup

bug-185857-20180521201516.patch (text/plain), 3.11 KB, created by Ryosuke Niwa on 2018-05-21 20:15:17 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Ryosuke Niwa

Created: 2018-05-21 20:15:17 PDT

Size: 3.11 KB

patch

obsolete

>Index: Source/WebKit/ChangeLog
>===================================================================
>--- Source/WebKit/ChangeLog	(revision 232044)
>+++ Source/WebKit/ChangeLog	(working copy)
>@@ -1,3 +1,17 @@
>+2018-05-21  Ryosuke Niwa  <rniwa@webkit.org>
>+
>+        Remove unused and no-op WKContextSetCookieStorageDirectory
>+        https://bugs.webkit.org/show_bug.cgi?id=185857
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Deleted C API which didn't do anything useful, and consequently not used by anyone.
>+
>+        * UIProcess/API/C/WKContext.cpp:
>+        (WKContextSetCookieStorageDirectory): Deleted.
>+        * UIProcess/API/C/WKContextPrivate.h:
>+        * UIProcess/WebProcessPool.h:
>+
> 2018-05-21  Chris Nardi  <cnardi@chromium.org>
> 
>         Remove dead exception in MediaList.appendMedium
>Index: Source/WebKit/UIProcess/WebProcessPool.h
>===================================================================
>--- Source/WebKit/UIProcess/WebProcessPool.h	(revision 232032)
>+++ Source/WebKit/UIProcess/WebProcessPool.h	(working copy)
>@@ -261,8 +261,6 @@ public:
>     };
>     static Statistics& statistics();    
> 
>-    void setCookieStorageDirectory(const String& dir) { m_overrideCookieStorageDirectory = dir; }
>-
>     void useTestingNetworkSession();
>     bool isUsingTestingNetworkSession() const { return m_shouldUseTestingNetworkSession; }
> 
>@@ -614,8 +612,6 @@ private:
>     std::unique_ptr<PerActivityStateCPUUsageSampler> m_perActivityStateCPUUsageSampler;
> #endif
> 
>-    String m_overrideCookieStorageDirectory;
>-
>     bool m_shouldUseTestingNetworkSession { false };
> 
>     bool m_processTerminationEnabled { true };
>Index: Source/WebKit/UIProcess/API/C/WKContext.cpp
>===================================================================
>--- Source/WebKit/UIProcess/API/C/WKContext.cpp	(revision 232032)
>+++ Source/WebKit/UIProcess/API/C/WKContext.cpp	(working copy)
>@@ -488,11 +488,6 @@ void WKContextAllowSpecificHTTPSCertific
>     toImpl(contextRef)->allowSpecificHTTPSCertificateForHost(toImpl(certificateRef), toImpl(hostRef)->string());
> }
> 
>-WK_EXPORT void WKContextSetCookieStorageDirectory(WKContextRef contextRef, WKStringRef cookieStorageDirectory)
>-{
>-    toImpl(contextRef)->setCookieStorageDirectory(toImpl(cookieStorageDirectory)->string());
>-}
>-
> void WKContextDisableProcessTermination(WKContextRef contextRef)
> {
>     toImpl(contextRef)->disableProcessTermination();
>Index: Source/WebKit/UIProcess/API/C/WKContextPrivate.h
>===================================================================
>--- Source/WebKit/UIProcess/API/C/WKContextPrivate.h	(revision 232032)
>+++ Source/WebKit/UIProcess/API/C/WKContextPrivate.h	(working copy)
>@@ -75,8 +75,6 @@ WK_EXPORT void WKContextSetIconDatabaseP
> 
> WK_EXPORT void WKContextAllowSpecificHTTPSCertificateForHost(WKContextRef context, WKCertificateInfoRef certificate, WKStringRef host);
> 
>-WK_EXPORT void WKContextSetCookieStorageDirectory(WKContextRef context, WKStringRef cookieStorageDirectory);
>-
> // FIXME: This is a workaround for testing purposes only and should be removed once a better
> // solution has been found for testing.
> WK_EXPORT void WKContextDisableProcessTermination(WKContextRef context);

Actions: View | Formatted Diff | Diff

Attachments on bug 185857: 340948