Attachment 340883 Details for Bug 185835 – Patch

[patch] Patch

bug-185835-20180521135416.patch (text/plain), 1.60 KB, created by Sihui Liu on 2018-05-21 13:54:17 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Sihui Liu

Created: 2018-05-21 13:54:17 PDT

Size: 1.60 KB

patch

obsolete

>Subversion Revision: 232015
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 35dc9aa5744131177495eb730597fae12002b943..1205fbeac99c9f8194e6d37e04148f66b06ab3c9 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-05-21  Sihui Liu  <sihui_liu@apple.com>
>+
>+        Unable to remove IndexedDB Databases with Cocoa API removeDataOfTypes
>+        https://bugs.webkit.org/show_bug.cgi?id=185835
>+        <rdar://problem/39142257>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Databases should be closed and deleted if websiteDataTypes contains WebsiteDataType::IndexedDBDatabases.
>+
>+        * StorageProcess/StorageProcess.cpp:
>+        (WebKit::StorageProcess::deleteWebsiteDataForOrigins):
>+
> 2018-05-21  Carlos Garcia Campos  <cgarcia@igalia.com>
> 
>         Unreviewed. Update OptionsGTK.cmake and NEWS for 2.21.2 release.
>diff --git a/Source/WebKit/StorageProcess/StorageProcess.cpp b/Source/WebKit/StorageProcess/StorageProcess.cpp
>index 6a98d1ad8d910b8ba40368a88b0a2eba696ce609..9bb489a9a4f260191bce0062c5816812d359c601 100644
>--- a/Source/WebKit/StorageProcess/StorageProcess.cpp
>+++ b/Source/WebKit/StorageProcess/StorageProcess.cpp
>@@ -347,7 +347,7 @@ void StorageProcess::deleteWebsiteDataForOrigins(PAL::SessionID sessionID, Optio
> #endif
> 
> #if ENABLE(INDEXED_DATABASE)
>-    if (!websiteDataTypes.contains(WebsiteDataType::IndexedDBDatabases))
>+    if (websiteDataTypes.contains(WebsiteDataType::IndexedDBDatabases))
>         idbServer(sessionID).closeAndDeleteDatabasesForOrigins(securityOrigins, [callbackAggregator = WTFMove(callbackAggregator)] { });
> #endif
> }

Actions: View | Formatted Diff | Diff

Attachments on bug 185835: 340883 | 341030 | 341474 | 341475