Attachment 340880 Details for Bug 185680 – Fix flaky test.

[patch] Fix flaky test.

now_playing_test_fix.txt (text/plain), 3.27 KB, created by Eric Carlson on 2018-05-21 13:44:54 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Eric Carlson

Created: 2018-05-21 13:44:54 PDT

Size: 3.27 KB

patch

obsolete

>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index c866217d2d0..2d9409ac277 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,15 @@
>+2018-05-21  Eric Carlson  <eric.carlson@apple.com>
>+
>+        Improve NowPlaying "title"
>+        https://bugs.webkit.org/show_bug.cgi?id=185680
>+        <rdar://problem/40296700>
>+
>+        Unreviewed test fix.
>+
>+        * http/tests/media/now-playing-info-expected.txt:
>+        * http/tests/media/now-playing-info.html: Don't test .elapsedTime before seeking because
>+        the time value can take a while to "settle" when a file has just loaded.
>+
> 2018-05-18  Jer Noble  <jer.noble@apple.com>
> 
>         Complete fix for enabling modern EME by default
>diff --git a/LayoutTests/http/tests/media/now-playing-info-expected.txt b/LayoutTests/http/tests/media/now-playing-info-expected.txt
>index 5c85b1d49ce..dbc3c05b10b 100644
>--- a/LayoutTests/http/tests/media/now-playing-info-expected.txt
>+++ b/LayoutTests/http/tests/media/now-playing-info-expected.txt
>@@ -17,7 +17,6 @@ RUN(nowPlayingState = internals.nowPlayingState)
> EXPECTED (nowPlayingState.registeredAsNowPlayingApplication == 'true') OK
> EXPECTED (nowPlayingState.title == 'Page Title') OK
> EXPECTED (nowPlayingState.duration > '0') OK
>-EXPECTED (nowPlayingState.elapsedTime >= '0') OK
> 
> * Set video title, it should be used.
> RUN(video.title = "Video Title")
>diff --git a/LayoutTests/http/tests/media/now-playing-info.html b/LayoutTests/http/tests/media/now-playing-info.html
>index b60220eba61..a39bad0c522 100644
>--- a/LayoutTests/http/tests/media/now-playing-info.html
>+++ b/LayoutTests/http/tests/media/now-playing-info.html
>@@ -47,7 +47,6 @@
>                 testExpected('nowPlayingState.registeredAsNowPlayingApplication', true);
>                 testExpected('nowPlayingState.title', 'Page Title');
>                 testExpected('nowPlayingState.duration', '0', '>');
>-                testExpected('nowPlayingState.elapsedTime', '0', '>=');
>                 previousNowPlayingState = nowPlayingState;
> 
> 
>@@ -64,8 +63,6 @@
>                 // because the values will be different from run to run.
>                 if (nowPlayingState.uniqueIdentifier != previousNowPlayingState.uniqueIdentifier)
>                     testExpected('nowPlayingState.uniqueIdentifier', previousNowPlayingState.uniqueIdentifier);
>-                if (nowPlayingState.elapsedTime != previousNowPlayingState.elapsedTime)
>-                    testExpected('nowPlayingState.elapsedTime', previousNowPlayingState.elapsedTime);
>                 previousNowPlayingState = nowPlayingState;
> 
>                 consoleWrite('<br>* Clear video and page titles, page domain should be used.');
>@@ -79,8 +76,6 @@
>                 testExpected('nowPlayingState.duration', '0', '>');
>                 if (nowPlayingState.uniqueIdentifier != previousNowPlayingState.uniqueIdentifier)
>                     testExpected('nowPlayingState.uniqueIdentifier', previousNowPlayingState.uniqueIdentifier);
>-                if (nowPlayingState.elapsedTime != previousNowPlayingState.elapsedTime)
>-                    testExpected('nowPlayingState.elapsedTime', previousNowPlayingState.elapsedTime);
>                 previousNowPlayingState = nowPlayingState;
> 
>                 consoleWrite('<br>* Change currentTime, state should be updated.');

Actions: View | Formatted Diff | Diff

Attachments on bug 185680: 340504 | 340762 | 340763 | 340764 | 340766 | 340767 | 340769 | 340786 | 340880