Attachment 340878 Details for Bug 185833 – Patch

[patch] Patch

bug-185833-20180521222738.patch (text/plain), 5.79 KB, created by Yoav Weiss on 2018-05-21 13:27:40 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Yoav Weiss

Created: 2018-05-21 13:27:40 PDT

Size: 5.79 KB

patch

obsolete

>Subversion Revision: 232015
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 43ab552a1e97453264e3da8c8090afc9382cced8..602487417515637d70dc4bca0884400ea14a26cf 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,19 @@
>+2018-05-21  Yoav Weiss  <yoav@yoav.ws>
>+
>+        Add APNG as a supported MIME type
>+        https://bugs.webkit.org/show_bug.cgi?id=185833
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        This makes sure that APNG is recognized as a supported MIME type,
>+        enabling developers to conditionally load it using the `<picture>`
>+        element.
>+
>+        Test: fast/picture/image-picture-1x.html
>+
>+        * platform/MIMETypeRegistry.cpp:
>+        (WebCore::initializeSupportedImageMIMETypes): Add APNG MIME type.
>+
> 2018-05-21  Alicia Boya GarcÃa  <aboya@igalia.com>
> 
>         [MSE][GStreamer] Stream::decodebinSinkPad is read but never assigned
>diff --git a/Source/WebCore/platform/MIMETypeRegistry.cpp b/Source/WebCore/platform/MIMETypeRegistry.cpp
>index 017bd99097ee4a3bfdfa0a08ba821faaa6c16945..56350115af5f4ee9181055d284b37f5f9c05e9c2 100644
>--- a/Source/WebCore/platform/MIMETypeRegistry.cpp
>+++ b/Source/WebCore/platform/MIMETypeRegistry.cpp
>@@ -71,7 +71,7 @@ static void initializeSupportedImageMIMETypes()
> 
> #if USE(CG)
>     // This represents the subset of allowed image UTIs for which CoreServices has a corresponding MIME type. Keep this in sync with allowedImageUTIs().
>-    static const char* const allowedImageMIMETypes[] = { "image/tiff", "image/gif", "image/jpeg", "image/vnd.microsoft.icon", "image/jp2", "image/png", "image/bmp" };
>+    static const char* const allowedImageMIMETypes[] = { "image/tiff", "image/gif", "image/jpeg", "image/vnd.microsoft.icon", "image/jp2", "image/png", "image/bmp", "image/apng" };
>     for (auto& mimeType : allowedImageMIMETypes) {
>         supportedImageMIMETypes->add(ASCIILiteral { mimeType });
>         supportedImageResourceMIMETypes->add(ASCIILiteral { mimeType });
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index e4bc3f0d7f9e685c0ff3a1ed81789cadf22daa6b..771ac44d0ae7a6d1e0d7df5d6be53adf491b445e 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,13 @@
>+2018-05-21  Yoav Weiss  <yoav@yoav.ws>
>+
>+        Add APNG as a supported MIME type
>+        https://bugs.webkit.org/show_bug.cgi?id=185833
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * fast/picture/image-picture-1x-expected.txt:
>+        * fast/picture/image-picture-1x.html: Add test for "image/apng".
>+
> 2018-05-20  Emilio Cobos Ãlvarez  <emilio@crisal.io>
> 
>         Update CSSOM WPT tests.
>diff --git a/LayoutTests/fast/picture/image-picture-1x-expected.txt b/LayoutTests/fast/picture/image-picture-1x-expected.txt
>index 85021c898ad1ba2f2f600e7831916e488f8d3522..8164709bf0d048255382f83284433c3cc99adfa4 100644
>--- a/LayoutTests/fast/picture/image-picture-1x-expected.txt
>+++ b/LayoutTests/fast/picture/image-picture-1x-expected.txt
>@@ -10,6 +10,8 @@ PASS document.getElementById("img_before_source").clientWidth is 75
> PASS currentSrcFileName("img_before_source") is "blue_rect.jpg?1"
> PASS document.getElementById("unknown_type").clientWidth is 1600
> PASS currentSrcFileName("unknown_type") is "image-set-4x.png?3"
>+PASS document.getElementById("apng_type").clientWidth is 800
>+PASS currentSrcFileName("apng_type") is "image-set-2x.png?2"
> PASS document.getElementById("svg_type").clientWidth is 800
> PASS currentSrcFileName("svg_type") is "image-set-2x.png?2"
> PASS document.getElementById("empty_type").clientWidth is 800
>@@ -27,4 +29,4 @@ PASS successfullyParsed is true
> TEST COMPLETE
>    
> some text
>-         
>+          
>diff --git a/LayoutTests/fast/picture/image-picture-1x.html b/LayoutTests/fast/picture/image-picture-1x.html
>index 4ce33ac33e4592c65bff57acb5de687ceafd0cb3..4d395b35a656845704d7b24e192acb85a06effbb 100644
>--- a/LayoutTests/fast/picture/image-picture-1x.html
>+++ b/LayoutTests/fast/picture/image-picture-1x.html
>@@ -18,6 +18,8 @@
> 	        shouldBe('currentSrcFileName("img_before_source")', '"blue_rect.jpg?1"');
> 	        shouldBe('document.getElementById("unknown_type").clientWidth', '1600');
> 	        shouldBe('currentSrcFileName("unknown_type")', '"image-set-4x.png?3"');
>+	        shouldBe('document.getElementById("apng_type").clientWidth', '800');
>+	        shouldBe('currentSrcFileName("apng_type")', '"image-set-2x.png?2"');
>             shouldBe('document.getElementById("svg_type").clientWidth', '800');
> 	        shouldBe('currentSrcFileName("svg_type")', '"image-set-2x.png?2"');
> 	        shouldBe('document.getElementById("empty_type").clientWidth', '800');
>@@ -86,6 +88,16 @@
> 	        resources/image-set-4x.png?3 1600w">
> 	    <img id="unknown_type" src="resources/blue_rect.jpg?1">
> 	</picture>
>+	
>+	<picture>
>+	    <source media="(max-width: 400px)" sizes="400px" srcset="../hidpi/resources/image-set-1x.png?1 400w, ../hidpi/resources/image-set-2x.png?1 800w,
>+	        resources/image-set-4x.png?1 1600w">
>+	    <source media="(max-width: 800px)" type="image/apng" sizes="800px" srcset="../hidpi/resources/image-set-1x.png?2 400w, ../hidpi/resources/image-set-2x.png?2 800w,
>+	        resources/image-set-4x.png?2 1600w">
>+	    <source media="(max-width: 1600px)" sizes="1600px" srcset="../hidpi/resources/image-set-1x.png?3 400w, ../hidpi/resources/image-set-2x.png?3 800w,
>+	        resources/image-set-4x.png?3 1600w">
>+	    <img id="apng_type" src="resources/blue_rect.jpg?1">
>+	</picture>
> 	
> 	<picture>
> 	    <source media="(max-width: 400px)" sizes="400px" srcset="../hidpi/resources/image-set-1x.png?1 400w, ../hidpi/resources/image-set-2x.png?1 800w,
>@@ -144,4 +156,4 @@
> 	        resources/image-set-4x.png?3 1600w">
> 	    <img id="no_srcset" src="resources/blue_rect.jpg?1">
> 	</picture>
>-    
>\ No newline at end of file
>+

Actions: View | Formatted Diff | Diff

Attachments on bug 185833: 340878 | 340891 | 341257