Attachment 340877 Details for Bug 185827 – Patch

[patch] Patch

bug-185827-20180521132517.patch (text/plain), 1.93 KB, created by BJ Burg on 2018-05-21 13:25:18 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: BJ Burg

Created: 2018-05-21 13:25:18 PDT

Size: 1.93 KB

patch

obsolete

>Subversion Revision: 232023
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 97781346b4472edb4ac6f3b7551530943f256920..d58004074c5d8c452da95c580b892b445c2181af 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,18 @@
>+2018-05-21  Brian Burg  <bburg@apple.com>
>+
>+        Web Automation: terminate the automation session if the network or storage process crashes
>+        https://bugs.webkit.org/show_bug.cgi?id=185827
>+        <rdar://problem/40424020>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        If one of the processes crashes, the page may be in an undefined state and
>+        automation will fail in unpredictable ways. It's better to just give up immediately.
>+
>+        * UIProcess/WebProcessPool.cpp:
>+        (WebKit::WebProcessPool::networkProcessFailedToLaunch):
>+        (WebKit::WebProcessPool::storageProcessCrashed):
>+
> 2018-05-21  Sam Weinig  <sam@webkit.org>
> 
>         Modernize RenderStyleConstants.h - Part 1
>diff --git a/Source/WebKit/UIProcess/WebProcessPool.cpp b/Source/WebKit/UIProcess/WebProcessPool.cpp
>index 30679d3507ac8b6fd73c35663ec5493a3be12d9b..c561bcb5014301cccba8920bf69ebbb4e8f5243a 100644
>--- a/Source/WebKit/UIProcess/WebProcessPool.cpp
>+++ b/Source/WebKit/UIProcess/WebProcessPool.cpp
>@@ -560,6 +560,9 @@ void WebProcessPool::networkProcessFailedToLaunch(NetworkProcessProxy& networkPr
> 
>     m_client.networkProcessDidCrash(this);
> 
>+    if (m_automationSession)
>+        m_automationSession->terminate();
>+
>     // Leave the process proxy around during client call, so that the client could query the process identifier.
>     m_networkProcess = nullptr;
> }
>@@ -627,6 +630,10 @@ void WebProcessPool::storageProcessCrashed(StorageProcessProxy* storageProcessPr
>         supplement->processDidClose(storageProcessProxy);
> 
>     m_client.storageProcessDidCrash(this);
>+
>+    if (m_automationSession)
>+        m_automationSession->terminate();
>+
>     m_storageProcess = nullptr;
> }
>

Actions: View | Formatted Diff | Diff

Attachments on bug 185827: 340877