Attachment 340870 Details for Bug 183744 – Patch

[patch] Patch

bug-183744-20180521121647.patch (text/plain), 46.13 KB, created by Daniel Bates on 2018-05-21 12:16:48 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Daniel Bates

Created: 2018-05-21 12:16:48 PDT

Size: 46.13 KB

patch

obsolete

>Subversion Revision: 231991
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index f569f3b1a2ad65a61dd5e388e96f09e05b8adb02..81feb366a20881ce18dd1763df2966c15552bfd1 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,5 +1,96 @@
> 2018-05-21  Daniel Bates  <dabates@apple.com>
> 
>+        Add some tests for lldb_webkit.py
>+        https://bugs.webkit.org/show_bug.cgi?id=183744
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Adds some tests to ensure we do not regress LLDB pretty-printing of WTF::StringImpl
>+        and WTF::String objects.
>+
>+        The tests make use of the LLDB Python API and a simple debug-built test program,
>+        lldbWebKitTester, to run. For now, we build and run the these tests only on Mac.
>+
>+        * Makefile: Build the simple test tool lldbWebKitTester on Mac. Although this makefile
>+        supports building the tool for either Release and Debug we only support running the tests
>+        with a debug-built version of lldbWebKitTester. We should look to override a specified
>+        configuration style and always build lldbWebKitTester for Debug.
>+        * Scripts/dump-class-layout: Extract logic to compute the path to the LLDB Python module
>+        from here to Scripts/webkitpy/common/system/systemhost.py so that it can used by both
>+        this script and lldb/lldb_webkit_unittest.py. Also import the lldb module at the top of
>+        the file and take advantage of Python's default error semantics to throw an exception
>+        if the import fails instead of handling it ourself. This has the side effect that we
>+        now always import the LLDB Python module even if this script is invoked with --help.
>+        If this turns out to be a significant annoyance then we can look to dynamically import
>+        the module as we did before this change.
>+        (webkit_build_dir):
>+        (main):
>+        (developer_dir): Deleted.
>+        (import_lldb): Deleted.
>+        * Scripts/webkitpy/common/system/systemhost.py:
>+        (SystemHost):
>+        (SystemHost.path_to_lldb_python_directory): Added.
>+        * Scripts/webkitpy/test/main.py:
>+        (maybe_add_lldb_webkit_tests): Added.
>+        (main): Call maybe_add_lldb_webkit_tests() to conditionally add the lldb_webkit tests
>+        to the test search path.
>+        (Tester._run_tests): Update code as needed for change below.
>+        (Tester._test_names): Modified to look for a new test method prefix, 'stateless_process_test_'
>+        and collect such methods. Methods with this name prefix will run in a new Python process (i.e.
>+        not a fork() of test-webkitpy). 
>+
>+        * Scripts/webkitpy/test/main_unittest.py:
>+        (TestStubs.stateless_process_test_empty):
>+        (TestStubs):
>+        (TestStubs.stateless_process_integration_test_empty):
>+        (TesterTest.test_individual_names_are_not_run_twice):
>+        (TesterTest.test_integration_tests_are_not_found_by_default):
>+        (TesterTest.test_integration_tests_are_found):
>+        Add unit tests for test methods that are prefixed with 'stateless_process_test_'.
>+
>+        * Scripts/webkitpy/test/runner.py:
>+        (write_pickled_test_result_modifying_test_result): Convenience function that nullifies file-like
>+        attributes of the specified unittest.TestResult object and pickles it. The nullification is needed
>+        because we cannot pickle file-like objects.
>+        (Runner.__init__): Substitute 'self._stateful_worker_factory' for 'self.worker_factory' to better
>+        describe that this function returns a new stateful Worker instance (i.e. a worker that executes in
>+        a fork() of test-webkitpy).
>+        (Runner.run): Modified to take an optional parameter, use_stateless_process, as to whether to use
>+        a new Python process to execute the test.
>+        (_StatelessWorker): Added.
>+        (_StatelessWorker.__init__): Added.
>+        (_StatelessWorker.handle): Launches a new Python process that executes script stateless_process_runner.py.
>+        This new process expects the name of the test method to run to be passed to it as its only command-line
>+        argument and reads the pickled unittest.TestResult() object passed to it via standard input. It signals
>+        the start and end of the test via hardcoded '## Start ##' and '## End ##' strings written to standard output.
>+        Then it passes back the unittest.TestResult() it originally received via standard input to its parent by
>+        pickling it and writing it to standard output.
>+        * lldb/lldbWebKitTester/Configurations/Base.xcconfig: Added.
>+        * lldb/lldbWebKitTester/Configurations/DebugRelease.xcconfig: Added.
>+        * lldb/lldbWebKitTester/Configurations/lldbWebKitTester.xcconfig: Added.
>+        * lldb/lldbWebKitTester/Makefile: Added.
>+        * lldb/lldbWebKitTester/lldbWebKitTester.xcodeproj/project.pbxproj: Added.
>+        * lldb/lldbWebKitTester/main.cpp: Added.
>+        (breakForTestingSummaryProviders):
>+        (utf16String):
>+        (testSummaryProviders):
>+        (main):
>+        * lldb/lldb_webkit_unittest.py: Added.
>+        (TestSummaryProviders):
>+        (TestSummaryProviders.setUpClass):
>+        (TestSummaryProviders.tearDownClass):
>+        (TestSummaryProviders.stateless_process_test_WTFStringImpl_SummaryProvider_null_string):
>+        (TestSummaryProviders.stateless_process_test_WTFStringImpl_SummaryProvider_empty_string):
>+        (TestSummaryProviders.stateless_process_test_WTFStringImpl_SummaryProvider_8bit_string):
>+        (TestSummaryProviders.stateless_process_test_WTFStringImpl_SummaryProvider_16bit_string):
>+        (TestSummaryProviders.stateless_process_test_WTFString_SummaryProvider_null_string):
>+        (TestSummaryProviders.stateless_process_test_WTFString_SummaryProvider_empty_string):
>+        (TestSummaryProviders.stateless_process_test_WTFString_SummaryProvider_8bit_string):
>+        (TestSummaryProviders.stateless_process_test_WTFString_SummaryProvider_16bit_string):
>+
>+
>+2018-05-21  Daniel Bates  <dabates@apple.com>
>+
>         test-webkitpy messages logged using __main__ logger are not displayed
>         https://bugs.webkit.org/show_bug.cgi?id=185823
> 
>diff --git a/Tools/Makefile b/Tools/Makefile
>index 6a1f77ce63573e5fe891034768253730045b9243..ca07f1881bc91fe8e522d66e3df7b81f7580f44c 100644
>--- a/Tools/Makefile
>+++ b/Tools/Makefile
>@@ -2,7 +2,7 @@ MODULES = DumpRenderTree WebKitTestRunner MiniBrowser ../Source/ThirdParty/gtest
> 
> ifneq (,$(SDKROOT))
> 	ifeq (,$(findstring macosx,$(SDKROOT)))
>-		MODULES = DumpRenderTree WebKitTestRunner ../Source/ThirdParty/gtest/xcode TestWebKitAPI
>+		MODULES = DumpRenderTree WebKitTestRunner ../Source/ThirdParty/gtest/xcode TestWebKitAPI lldb/lldbWebKitTester
> 	endif
> 	ifneq (,$(findstring iphone,$(SDKROOT)))
> 		MODULES += MobileMiniBrowser
>diff --git a/Tools/Scripts/dump-class-layout b/Tools/Scripts/dump-class-layout
>index d41864455836e3b0e2b06546b9bab62668586ec5..6f6eba42de8175362b2c21977916d874b5504cd5 100755
>--- a/Tools/Scripts/dump-class-layout
>+++ b/Tools/Scripts/dump-class-layout
>@@ -31,6 +31,9 @@ import os
> import subprocess
> from sets import Set
> 
>+from webkitpy.common.system.systemhost import SystemHost
>+sys.path.append(SystemHost().path_to_lldb_python_directory())
>+import lldb
> 
> framework = "WebCore"
> build_directory = ""
>@@ -41,21 +44,6 @@ def webkit_build_dir():
>     scriptpath = os.path.dirname(os.path.realpath(__file__))
>     return subprocess.check_output([os.path.join(scriptpath, "webkit-build-directory"), "--top-level"]).strip()
> 
>-def developer_dir():
>-    return subprocess.check_output(["xcode-select", "--print-path"])
>-
>-def import_lldb():
>-    xcode_contents_path = os.path.split(developer_dir())[0]
>-    lldb_framework_path = os.path.join(xcode_contents_path, "SharedFrameworks", "LLDB.framework", "Resources", "Python")
>-    sys.path.append(lldb_framework_path)
>-
>-    LLDB_MODULE_NAME = "lldb"
>-    try:
>-        globals()[LLDB_MODULE_NAME] = __import__(LLDB_MODULE_NAME)
>-    except ImportError:
>-        print "Failed to import {} from {}".format(LLDB_MODULE_NAME, lldb_framework_path)
>-        sys.exit(1)
>-
> def verify_type(target, type):
>     typename = type.GetName()
>     seenOffset = Set()
>@@ -196,7 +184,6 @@ def main():
>         build_dir = args.build_directory
> 
>     target_path = os.path.join(build_dir, args.config, args.framework + ".framework", args.framework);
>-    import_lldb()
>     dump_class(target_path, args.classname, args.arch)
> 
> if __name__ == "__main__":
>diff --git a/Tools/Scripts/webkitpy/common/system/systemhost.py b/Tools/Scripts/webkitpy/common/system/systemhost.py
>index a15342201d833414731ebd0f76f7179a6f0bd6e3..43d6d79fc472394001fc94f942b199a4a9cdf8b1 100644
>--- a/Tools/Scripts/webkitpy/common/system/systemhost.py
>+++ b/Tools/Scripts/webkitpy/common/system/systemhost.py
>@@ -47,3 +47,9 @@ class SystemHost(object):
> 
>     def symbolicate_crash_log_if_needed(self, path):
>         return self.filesystem.read_text_file(path)
>+
>+    def path_to_lldb_python_directory(self):
>+        if not self.platform.is_mac():
>+            return ''
>+        xcode_developer_directory = self.executive.run_command(['xcode-select', '--print-path'], return_stderr=False).rstrip()
>+        return self.filesystem.abspath(self.filesystem.join(xcode_developer_directory, '..', 'SharedFrameworks', 'LLDB.framework', 'Versions', 'A', 'Resources', 'Python'))
>diff --git a/Tools/Scripts/webkitpy/test/main.py b/Tools/Scripts/webkitpy/test/main.py
>index 5facaa546dee9658bac9848ea02e1fc482a0f2ef..806ffbb9da4df720129f362fdbc1cf49c307f919 100644
>--- a/Tools/Scripts/webkitpy/test/main.py
>+++ b/Tools/Scripts/webkitpy/test/main.py
>@@ -1,5 +1,6 @@
> # Copyright (C) 2012 Google, Inc.
> # Copyright (C) 2010 Chris Jerdonek (cjerdonek@webkit.org)
>+# Copyright (C) 2018 Apple Inc. All rights reserved.
> #
> # Redistribution and use in source and binary forms, with or without
> # modification, are permitted provided that the following conditions
>@@ -38,6 +39,8 @@ import unittest
> 
> from webkitpy.common.system.logutils import configure_logging
> from webkitpy.common.system.filesystem import FileSystem
>+from webkitpy.common.system.systemhost import SystemHost
>+from webkitpy.port.config import Config
> from webkitpy.test.finder import Finder
> from webkitpy.test.printer import Printer
> from webkitpy.test.runner import Runner, unit_test_name
>@@ -45,6 +48,21 @@ from webkitpy.test.runner import Runner, unit_test_name
> _log = logging.getLogger(__name__)
> 
> 
>+def maybe_add_lldb_webkit_tests(tester, webkit_root):
>+    host = SystemHost()
>+    lldb_python_directory = host.path_to_lldb_python_directory()
>+    if not os.path.isdir(lldb_python_directory):
>+        _log.info("Skipping lldb_webkit tests; could not find LLDB Python module directory '{}'.".format(lldb_python_directory))
>+        return
>+    build_directory = Config(host.executive, host.filesystem).build_directory('Debug')
>+    lldb_webkit_tester_executable = os.path.join(build_directory, 'lldbWebKitTester')
>+    if not os.path.exists(lldb_webkit_tester_executable):
>+        _log.info("Skipping lldb_webkit tests; could not find '{}'.".format(lldb_webkit_tester_executable))
>+        return
>+    if lldb_python_directory not in sys.path:
>+        sys.path.append(lldb_python_directory)
>+    tester.add_tree(os.path.join(webkit_root, 'Tools', 'lldb'))
>+
> def main():
>     configure_logging(logger=_log)
> 
>@@ -58,6 +76,8 @@ def main():
>     if not (sys.platform.startswith('win') or sys.platform == 'cygwin'):
>         tester.add_tree(os.path.join(webkit_root, 'Source', 'WebKit', 'Scripts'), 'webkit')
> 
>+    maybe_add_lldb_webkit_tests(tester, webkit_root)
>+
>     tester.skip(('webkitpy.common.checkout.scm.scm_unittest',), 'are really, really, slow', 31818)
>     if sys.platform.startswith('win'):
>         tester.skip(('webkitpy.common.checkout', 'webkitpy.common.config', 'webkitpy.tool'), 'fail horribly on win32', 54526)
>@@ -168,13 +188,14 @@ class Tester(object):
> 
>         self.printer.write_update("Finding the individual test methods ...")
>         loader = _Loader()
>-        parallel_tests, serial_tests = self._test_names(loader, names)
>+        parallel_tests, serial_tests, stateless_parallel_tests = self._test_names(loader, names)
> 
>         self.printer.write_update("Running the tests ...")
>         self.printer.num_tests = len(parallel_tests) + len(serial_tests)
>         start = time.time()
>         test_runner = Runner(self.printer, loader)
>         test_runner.run(parallel_tests, self._options.child_processes)
>+        test_runner.run(stateless_parallel_tests, self._options.child_processes, use_stateless_process=True)
>         test_runner.run(serial_tests, 1)
> 
>         self.printer.print_result(time.time() - start)
>@@ -211,9 +232,11 @@ class Tester(object):
>     def _test_names(self, loader, names):
>         parallel_test_method_prefixes = ['test_']
>         serial_test_method_prefixes = ['serial_test_']
>+        stateless_parallel_test_method_prefixes = ['stateless_process_test_']
>         if self._options.integration_tests:
>             parallel_test_method_prefixes.append('integration_test_')
>             serial_test_method_prefixes.append('serial_integration_test_')
>+            stateless_parallel_test_method_prefixes.append('stateless_process_integration_test_')
> 
>         parallel_tests = []
>         loader.test_method_prefixes = parallel_test_method_prefixes
>@@ -225,12 +248,19 @@ class Tester(object):
>         for name in names:
>             serial_tests.extend(self._all_test_names(loader.loadTestsFromName(name, None)))
> 
>+        stateless_parallel_tests = []
>+        loader.test_method_prefixes = stateless_parallel_test_method_prefixes
>+        for name in names:
>+            stateless_parallel_tests.extend(self._all_test_names(loader.loadTestsFromName(name, None)))
>+
>         # loader.loadTestsFromName() will not verify that names begin with one of the test_method_prefixes
>         # if the names were explicitly provided (e.g., MainTest.test_basic), so this means that any individual
>-        # tests will be included in both parallel_tests and serial_tests, and we need to de-dup them.
>-        serial_tests = list(set(serial_tests).difference(set(parallel_tests)))
>+        # tests will be included in parallel_tests, serial_tests, and stateless_parallel_tests and we need
>+        # to de-dup them.
>+        serial_tests = list(set(serial_tests).difference(set(parallel_tests)).difference(set(stateless_parallel_tests)))
>+        stateless_parallel_tests = list(set(stateless_parallel_tests).difference(set(parallel_tests)).difference(set(serial_tests)))
> 
>-        return (parallel_tests, serial_tests)
>+        return (parallel_tests, serial_tests, stateless_parallel_tests)
> 
>     def _all_test_names(self, suite):
>         names = []
>diff --git a/Tools/Scripts/webkitpy/test/main_unittest.py b/Tools/Scripts/webkitpy/test/main_unittest.py
>index 2a48243de76faa85307e3ecfa7a2280ed437e6b7..7c65c8ac259061d7fe19af6b5c52bc9ea13fe655 100644
>--- a/Tools/Scripts/webkitpy/test/main_unittest.py
>+++ b/Tools/Scripts/webkitpy/test/main_unittest.py
>@@ -1,4 +1,5 @@
> # Copyright (C) 2012 Google, Inc.
>+# Copyright (C) 2018 Apple Inc. All rights reserved.
> #
> # Redistribution and use in source and binary forms, with or without
> # modification, are permitted provided that the following conditions
>@@ -47,6 +48,12 @@ class TestStubs(unittest.TestCase):
>     def serial_integration_test_empty(self):
>         pass
> 
>+    def stateless_process_test_empty(self):
>+        pass
>+
>+    def stateless_process_integration_test_empty(self):
>+        pass
>+
> 
> class TesterTest(unittest.TestCase):
> 
>@@ -80,21 +87,25 @@ class TesterTest(unittest.TestCase):
> 
>     def test_individual_names_are_not_run_twice(self):
>         args = [STUBS_CLASS + '.test_empty']
>-        parallel_tests, serial_tests = self._find_test_names(args)
>+        parallel_tests, serial_tests, stateless_parallel_tests = self._find_test_names(args)
>         self.assertEqual(parallel_tests, args)
>         self.assertEqual(serial_tests, [])
>+        self.assertEqual(stateless_parallel_tests, [])
> 
>     def test_integration_tests_are_not_found_by_default(self):
>-        parallel_tests, serial_tests = self._find_test_names([STUBS_CLASS])
>+        parallel_tests, serial_tests, stateless_parallel_tests = self._find_test_names([STUBS_CLASS])
>         self.assertEqual(parallel_tests, [
>             STUBS_CLASS + '.test_empty',
>             ])
>         self.assertEqual(serial_tests, [
>             STUBS_CLASS + '.serial_test_empty',
>             ])
>+        self.assertEqual(stateless_parallel_tests, [
>+            STUBS_CLASS + '.stateless_process_test_empty',
>+            ])
> 
>     def test_integration_tests_are_found(self):
>-        parallel_tests, serial_tests = self._find_test_names(['--integration-tests', STUBS_CLASS])
>+        parallel_tests, serial_tests, stateless_parallel_tests = self._find_test_names(['--integration-tests', STUBS_CLASS])
>         self.assertEqual(parallel_tests, [
>             STUBS_CLASS + '.integration_test_empty',
>             STUBS_CLASS + '.test_empty',
>@@ -103,6 +114,10 @@ class TesterTest(unittest.TestCase):
>             STUBS_CLASS + '.serial_integration_test_empty',
>             STUBS_CLASS + '.serial_test_empty',
>             ])
>+        self.assertEqual(stateless_parallel_tests, [
>+            STUBS_CLASS + '.stateless_process_integration_test_empty',
>+            STUBS_CLASS + '.stateless_process_test_empty',
>+            ])
> 
>     def integration_test_coverage_works(self):
>         filesystem = FileSystem()
>diff --git a/Tools/Scripts/webkitpy/test/runner.py b/Tools/Scripts/webkitpy/test/runner.py
>index 3c25a16b663d410064578c541428207bc3b0046c..e1b94ce960a3eb366e098d5f99f3e09e208a2703 100644
>--- a/Tools/Scripts/webkitpy/test/runner.py
>+++ b/Tools/Scripts/webkitpy/test/runner.py
>@@ -22,7 +22,11 @@
> 
> """code to actually run a list of python tests."""
> 
>+import os
>+import pickle
> import re
>+import subprocess
>+import sys
> import time
> import unittest
> 
>@@ -31,6 +35,13 @@ from webkitpy.common import message_pool
> _test_description = re.compile("(\w+) $([\w.]+)$")
> 
> 
>+def write_pickled_test_result_modifying_test_result(test_result, file_object):
>+    # From <https://stackoverflow.com/questions/17459464/how-to-save-unittest-testresult>
>+    for key, value in vars(test_result).items():
>+        if isinstance(value, file):
>+            setattr(test_result, key, None)
>+    pickle.dump(test_result, file_object, pickle.HIGHEST_PROTOCOL)
>+
> def unit_test_name(test):
>     m = _test_description.match(str(test))
>     return "%s.%s" % (m.group(2), m.group(1))
>@@ -43,13 +54,16 @@ class Runner(object):
>         self.tests_run = 0
>         self.errors = []
>         self.failures = []
>-        self.worker_factory = lambda caller: _Worker(caller, self.loader)
>+        self._stateful_worker_factory = lambda caller: _Worker(caller, self.loader)
> 
>-    def run(self, test_names, num_workers):
>+    def run(self, test_names, num_workers, use_stateless_process=False):
>         if not test_names:
>             return
>+        worker_factory_to_use = self._stateful_worker_factory
>+        if use_stateless_process:
>+            worker_factory_to_use = lambda caller: _StatelessWorker(caller, self.loader)
>         num_workers = min(num_workers, len(test_names))
>-        with message_pool.get(self, self.worker_factory, num_workers) as pool:
>+        with message_pool.get(self, worker_factory_to_use, num_workers) as pool:
>             pool.run(('test', test_name) for test_name in test_names)
> 
>     def handle(self, message_name, source, test_name=None, delay=None, failures=None, errors=None):
>@@ -83,3 +97,41 @@ class _Worker(object):
>         self._loader.loadTestsFromName(test_name, None).run(result)
>         self._caller.post('finished_test', test_name, time.time() - start,
>             [failure[1] for failure in result.failures], [error[1] for error in result.errors])
>+
>+
>+class _StatelessWorker(object):
>+    def __init__(self, caller, loader):
>+        self._caller = caller
>+        self._loader = loader
>+
>+    def handle(self, message_name, source, test_name):
>+        assert message_name == 'test'
>+
>+        # We will need to rework this if a test_name results in multiple tests.
>+        assert sys.executable
>+        stateless_process_runner = os.path.join(os.path.dirname(os.path.abspath(__file__)), 'stateless_process_runner.py')
>+        args = [sys.executable, stateless_process_runner, test_name]
>+        child_process = subprocess.Popen(args, stdin=subprocess.PIPE, stdout=subprocess.PIPE, env={'PYTHONPATH': ':'.join(sys.path)}, close_fds=True)
>+        write_pickled_test_result_modifying_test_result(unittest.TestResult(), child_process.stdin)
>+
>+        time_elapsed = 0
>+        while True:
>+            output_line = child_process.stdout.readline().rstrip()
>+            if output_line == '## Start ##':
>+                start = time.time()
>+                self._caller.post('started_test', test_name)
>+                continue
>+            if output_line == '' and child_process.poll() is not None:
>+                break
>+            if output_line == '## End ##':
>+                time_elapsed = time.time() - start
>+                break
>+
>+        result = pickle.load(child_process.stdout)
>+        exit_code = child_process.wait()
>+
>+        if exit_code:
>+            raise RuntimeError('{} exited with non-zero exit code {}'.format(' '.join(args), test_name, exit_code))
>+
>+        self._caller.post('finished_test', test_name, time_elapsed,
>+            [failure[1] for failure in result.failures], [error[1] for error in result.errors])
>diff --git a/Tools/lldb/lldbWebKitTester/Configurations/Base.xcconfig b/Tools/lldb/lldbWebKitTester/Configurations/Base.xcconfig
>new file mode 100644
>index 0000000000000000000000000000000000000000..e20bc5d774ff3104030beb3cdfe20fd19567207b
>--- /dev/null
>+++ b/Tools/lldb/lldbWebKitTester/Configurations/Base.xcconfig
>@@ -0,0 +1,90 @@
>+// Copyright (C) 2015-2018 Apple Inc. All rights reserved.
>+//
>+// Redistribution and use in source and binary forms, with or without
>+// modification, are permitted provided that the following conditions
>+// are met:
>+// 1. Redistributions of source code must retain the above copyright
>+//    notice, this list of conditions and the following disclaimer.
>+// 2. Redistributions in binary form must reproduce the above copyright
>+//    notice, this list of conditions and the following disclaimer in the
>+//    documentation and/or other materials provided with the distribution.
>+//
>+// THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY
>+// EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
>+// IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
>+// PURPOSE ARE DISCLAIMED.  IN NO EVENT SHALL APPLE INC. OR
>+// CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
>+// EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
>+// PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
>+// PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
>+// OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
>+// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
>+// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>+
>+#include "../../../../Internal/Configurations/HaveInternalSDK.xcconfig"
>+
>+USE_INTERNAL_SDK = $(USE_INTERNAL_SDK_$(CONFIGURATION));
>+USE_INTERNAL_SDK_Production = YES;
>+USE_INTERNAL_SDK_Debug = $(HAVE_INTERNAL_SDK);
>+USE_INTERNAL_SDK_Release = $(HAVE_INTERNAL_SDK);
>+
>+CLANG_CXX_LANGUAGE_STANDARD = gnu++14;
>+CLANG_CXX_LIBRARY = libc++;
>+CLANG_WARN_BOOL_CONVERSION = YES;
>+CLANG_WARN_CONSTANT_CONVERSION = YES;
>+CLANG_WARN_CXX0X_EXTENSIONS = NO;
>+CLANG_WARN_EMPTY_BODY = YES;
>+CLANG_WARN_ENUM_CONVERSION = YES;
>+CLANG_WARN_INT_CONVERSION = YES;
>+CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
>+DEBUG_INFORMATION_FORMAT = dwarf-with-dsym;
>+GCC_C_LANGUAGE_STANDARD = gnu99;
>+GCC_DEBUGGING_SYMBOLS = default;
>+GCC_ENABLE_CPP_EXCEPTIONS = NO;
>+GCC_ENABLE_CPP_RTTI = YES;
>+GCC_ENABLE_OBJC_EXCEPTIONS = YES;
>+GCC_ENABLE_SYMBOL_SEPARATION = NO;
>+GCC_FAST_OBJC_DISPATCH = YES;
>+GCC_GENERATE_DEBUGGING_SYMBOLS = YES;
>+GCC_OBJC_CALL_CXX_CDTORS = YES;
>+GCC_PRECOMPILE_PREFIX_HEADER = YES;
>+GCC_PREPROCESSOR_DEFINITIONS = $(DEBUG_DEFINES) $(inherited);
>+GCC_STRICT_ALIASING = YES;
>+GCC_THREADSAFE_STATICS = NO;
>+GCC_TREAT_WARNINGS_AS_ERRORS = YES;
>+GCC_WARN_64_TO_32_BIT_CONVERSION_ = YES;
>+GCC_WARN_ABOUT_DEPRECATED_FUNCTIONS = NO;
>+GCC_WARN_ABOUT_MISSING_NEWLINE = YES;
>+GCC_WARN_ABOUT_MISSING_PROTOTYPES = YES;
>+GCC_WARN_ABOUT_RETURN_TYPE = YES;
>+GCC_WARN_NON_VIRTUAL_DESTRUCTOR = YES;
>+GCC_WARN_SIGN_COMPARE = YES;
>+GCC_WARN_UNDECLARED_SELECTOR = YES;
>+GCC_WARN_UNINITIALIZED_AUTOS = YES;
>+GCC_WARN_UNUSED_FUNCTION = YES;
>+GCC_WARN_UNUSED_VARIABLE = NO;
>+WARNING_CFLAGS = -Wcast-qual -Wchar-subscripts -Wextra-tokens -Wformat=2 -Winit-self -Wmissing-format-attribute -Wmissing-noreturn -Wpacked -Wpointer-arith -Wredundant-decls -Wundef -Wwrite-strings -Wexit-time-destructors -Wglobal-constructors -Wtautological-compare -Wimplicit-fallthrough;
>+
>+HEADER_SEARCH_PATHS = ${BUILT_PRODUCTS_DIR}/usr/local/include;
>+
>+TARGET_MAC_OS_X_VERSION_MAJOR = $(TARGET_MAC_OS_X_VERSION_MAJOR$(MACOSX_DEPLOYMENT_TARGET:suffix:identifier));
>+TARGET_MAC_OS_X_VERSION_MAJOR_10 = 101000;
>+TARGET_MAC_OS_X_VERSION_MAJOR_11 = 101100;
>+TARGET_MAC_OS_X_VERSION_MAJOR_12 = 101200;
>+TARGET_MAC_OS_X_VERSION_MAJOR_13 = 101300;
>+
>+// DEBUG_DEFINES, GCC_OPTIMIZATION_LEVEL, STRIP_INSTALLED_PRODUCT and DEAD_CODE_STRIPPING vary between the debug and normal variants.
>+// We set up the values for each variant here, and have the Debug configuration in the Xcode project use the _debug variant.
>+DEBUG_DEFINES_debug = ;
>+DEBUG_DEFINES_normal = NDEBUG;
>+DEBUG_DEFINES = $(DEBUG_DEFINES_$(CURRENT_VARIANT));
>+
>+GCC_OPTIMIZATION_LEVEL = $(GCC_OPTIMIZATION_LEVEL_$(CURRENT_VARIANT));
>+GCC_OPTIMIZATION_LEVEL_normal = 3;
>+GCC_OPTIMIZATION_LEVEL_debug = 0;
>+
>+SDKROOT = macosx.internal;
>+
>+OTHER_CFLAGS = $(ASAN_OTHER_CFLAGS);
>+OTHER_CPLUSPLUSFLAGS = $(ASAN_OTHER_CPLUSPLUSFLAGS);
>+OTHER_LDFLAGS = $(ASAN_OTHER_LDFLAGS);
>diff --git a/Tools/lldb/lldbWebKitTester/Configurations/DebugRelease.xcconfig b/Tools/lldb/lldbWebKitTester/Configurations/DebugRelease.xcconfig
>new file mode 100644
>index 0000000000000000000000000000000000000000..9eade9c1cae379a3ee19208b797dfcc112a75745
>--- /dev/null
>+++ b/Tools/lldb/lldbWebKitTester/Configurations/DebugRelease.xcconfig
>@@ -0,0 +1,41 @@
>+// Copyright (C) 2015-2018 Apple Inc. All rights reserved.
>+//
>+// Redistribution and use in source and binary forms, with or without
>+// modification, are permitted provided that the following conditions
>+// are met:
>+// 1. Redistributions of source code must retain the above copyright
>+//    notice, this list of conditions and the following disclaimer.
>+// 2. Redistributions in binary form must reproduce the above copyright
>+//    notice, this list of conditions and the following disclaimer in the
>+//    documentation and/or other materials provided with the distribution.
>+//
>+// THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY
>+// EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
>+// IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
>+// PURPOSE ARE DISCLAIMED.  IN NO EVENT SHALL APPLE INC. OR
>+// CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
>+// EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
>+// PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
>+// PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
>+// OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
>+// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
>+// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>+
>+#include "Base.xcconfig"
>+
>+ONLY_ACTIVE_ARCH = YES;
>+
>+TARGET_MAC_OS_X_VERSION_MAJOR = $(MAC_OS_X_VERSION_MAJOR);
>+
>+MACOSX_DEPLOYMENT_TARGET = $(MACOSX_DEPLOYMENT_TARGET_$(PLATFORM_NAME)_$(TARGET_MAC_OS_X_VERSION_MAJOR));
>+MACOSX_DEPLOYMENT_TARGET_macosx_101000 = 10.10;
>+MACOSX_DEPLOYMENT_TARGET_macosx_101100 = 10.11;
>+MACOSX_DEPLOYMENT_TARGET_macosx_101200 = 10.12;
>+MACOSX_DEPLOYMENT_TARGET_macosx_101300 = 10.13;
>+
>+GCC_WARN_ABOUT_DEPRECATED_FUNCTIONS = YES;
>+DEBUG_INFORMATION_FORMAT = dwarf;
>+
>+SDKROOT = $(SDKROOT_$(USE_INTERNAL_SDK));
>+SDKROOT_ = macosx;
>+SDKROOT_YES = macosx.internal;
>diff --git a/Tools/lldb/lldbWebKitTester/Configurations/lldbWebKitTester.xcconfig b/Tools/lldb/lldbWebKitTester/Configurations/lldbWebKitTester.xcconfig
>new file mode 100644
>index 0000000000000000000000000000000000000000..0666000d1afdd7dd1ce5ffc1b2d1fe10523d5e3e
>--- /dev/null
>+++ b/Tools/lldb/lldbWebKitTester/Configurations/lldbWebKitTester.xcconfig
>@@ -0,0 +1,24 @@
>+// Copyright (C) 2015-2018 Apple Inc. All rights reserved.
>+//
>+// Redistribution and use in source and binary forms, with or without
>+// modification, are permitted provided that the following conditions
>+// are met:
>+// 1. Redistributions of source code must retain the above copyright
>+//    notice, this list of conditions and the following disclaimer.
>+// 2. Redistributions in binary form must reproduce the above copyright
>+//    notice, this list of conditions and the following disclaimer in the
>+//    documentation and/or other materials provided with the distribution.
>+//
>+// THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY
>+// EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
>+// IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
>+// PURPOSE ARE DISCLAIMED.  IN NO EVENT SHALL APPLE INC. OR
>+// CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
>+// EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
>+// PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
>+// PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
>+// OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
>+// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
>+// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>+
>+PRODUCT_NAME = $(TARGET_NAME);
>diff --git a/Tools/lldb/lldbWebKitTester/Makefile b/Tools/lldb/lldbWebKitTester/Makefile
>new file mode 100644
>index 0000000000000000000000000000000000000000..058c21e1ba387a8ba4fc43f1444c380eec79ede9
>--- /dev/null
>+++ b/Tools/lldb/lldbWebKitTester/Makefile
>@@ -0,0 +1,2 @@
>+SCRIPTS_PATH = ../../Scripts
>+include ../../../Makefile.shared
>diff --git a/Tools/lldb/lldbWebKitTester/lldbWebKitTester.xcodeproj/project.pbxproj b/Tools/lldb/lldbWebKitTester/lldbWebKitTester.xcodeproj/project.pbxproj
>new file mode 100644
>index 0000000000000000000000000000000000000000..4d34748c75ecf51747397e1e5a5c70b890c70500
>--- /dev/null
>+++ b/Tools/lldb/lldbWebKitTester/lldbWebKitTester.xcodeproj/project.pbxproj
>@@ -0,0 +1,202 @@
>+// !$*UTF8*$!
>+{
>+	archiveVersion = 1;
>+	classes = {
>+	};
>+	objectVersion = 46;
>+	objects = {
>+
>+/* Begin PBXBuildFile section */
>+		7CB6844B1AFA7978002B305C /* main.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 7CB6844A1AFA7978002B305C /* main.cpp */; };
>+		CE3F4426205C6A01007195B3 /* JavaScriptCore.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = CE3F4422205C669C007195B3 /* JavaScriptCore.framework */; };
>+/* End PBXBuildFile section */
>+
>+/* Begin PBXCopyFilesBuildPhase section */
>+		7C4AB39F1AF0276C003FC8D1 /* CopyFiles */ = {
>+			isa = PBXCopyFilesBuildPhase;
>+			buildActionMask = 2147483647;
>+			dstPath = /usr/share/man/man1/;
>+			dstSubfolderSpec = 0;
>+			files = (
>+			);
>+			runOnlyForDeploymentPostprocessing = 1;
>+		};
>+/* End PBXCopyFilesBuildPhase section */
>+
>+/* Begin PBXFileReference section */
>+		7C2227511AFC4D9C008C3338 /* Base.xcconfig */ = {isa = PBXFileReference; lastKnownFileType = text.xcconfig; path = Base.xcconfig; sourceTree = "<group>"; };
>+		7C2227521AFC4D9C008C3338 /* lldbWebKitTester.xcconfig */ = {isa = PBXFileReference; lastKnownFileType = text.xcconfig; path = lldbWebKitTester.xcconfig; sourceTree = "<group>"; };
>+		7C2227531AFC4D9C008C3338 /* DebugRelease.xcconfig */ = {isa = PBXFileReference; lastKnownFileType = text.xcconfig; path = DebugRelease.xcconfig; sourceTree = "<group>"; };
>+		7C4AB3A11AF0276C003FC8D1 /* lldbWebKitTester */ = {isa = PBXFileReference; explicitFileType = "compiled.mach-o.executable"; includeInIndex = 0; path = lldbWebKitTester; sourceTree = BUILT_PRODUCTS_DIR; };
>+		7CB6844A1AFA7978002B305C /* main.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = main.cpp; sourceTree = SOURCE_ROOT; };
>+		CE3F4422205C669C007195B3 /* JavaScriptCore.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = JavaScriptCore.framework; path = System/Library/Frameworks/JavaScriptCore.framework; sourceTree = SDKROOT; };
>+/* End PBXFileReference section */
>+
>+/* Begin PBXFrameworksBuildPhase section */
>+		7C4AB39E1AF0276C003FC8D1 /* Frameworks */ = {
>+			isa = PBXFrameworksBuildPhase;
>+			buildActionMask = 2147483647;
>+			files = (
>+				CE3F4426205C6A01007195B3 /* JavaScriptCore.framework in Frameworks */,
>+			);
>+			runOnlyForDeploymentPostprocessing = 0;
>+		};
>+/* End PBXFrameworksBuildPhase section */
>+
>+/* Begin PBXGroup section */
>+		7C2227501AFC4D0A008C3338 /* Configurations */ = {
>+			isa = PBXGroup;
>+			children = (
>+				7C2227511AFC4D9C008C3338 /* Base.xcconfig */,
>+				7C2227531AFC4D9C008C3338 /* DebugRelease.xcconfig */,
>+				7C2227521AFC4D9C008C3338 /* lldbWebKitTester.xcconfig */,
>+			);
>+			path = Configurations;
>+			sourceTree = "<group>";
>+		};
>+		7C4AB3981AF0276C003FC8D1 = {
>+			isa = PBXGroup;
>+			children = (
>+				7C2227501AFC4D0A008C3338 /* Configurations */,
>+				CE3F4425205C6A01007195B3 /* Frameworks */,
>+				CE3F4424205C66D9007195B3 /* lldbWebKitTester */,
>+				7C4AB3A21AF0276C003FC8D1 /* Products */,
>+				CE3F4422205C669C007195B3 /* JavaScriptCore.framework */,
>+			);
>+			sourceTree = "<group>";
>+		};
>+		7C4AB3A21AF0276C003FC8D1 /* Products */ = {
>+			isa = PBXGroup;
>+			children = (
>+				7C4AB3A11AF0276C003FC8D1 /* lldbWebKitTester */,
>+			);
>+			name = Products;
>+			sourceTree = "<group>";
>+		};
>+		CE3F4424205C66D9007195B3 /* lldbWebKitTester */ = {
>+			isa = PBXGroup;
>+			children = (
>+				7CB6844A1AFA7978002B305C /* main.cpp */,
>+			);
>+			name = lldbWebKitTester;
>+			sourceTree = "<group>";
>+		};
>+		CE3F4425205C6A01007195B3 /* Frameworks */ = {
>+			isa = PBXGroup;
>+			children = (
>+			);
>+			name = Frameworks;
>+			sourceTree = "<group>";
>+		};
>+/* End PBXGroup section */
>+
>+/* Begin PBXNativeTarget section */
>+		7C4AB3A01AF0276C003FC8D1 /* lldbWebKitTester */ = {
>+			isa = PBXNativeTarget;
>+			buildConfigurationList = 7C4AB3A81AF0276C003FC8D1 /* Build configuration list for PBXNativeTarget "lldbWebKitTester" */;
>+			buildPhases = (
>+				7C4AB39D1AF0276C003FC8D1 /* Sources */,
>+				7C4AB39E1AF0276C003FC8D1 /* Frameworks */,
>+				7C4AB39F1AF0276C003FC8D1 /* CopyFiles */,
>+			);
>+			buildRules = (
>+			);
>+			dependencies = (
>+			);
>+			name = lldbWebKitTester;
>+			productName = lldbWebKitTester;
>+			productReference = 7C4AB3A11AF0276C003FC8D1 /* lldbWebKitTester */;
>+			productType = "com.apple.product-type.tool";
>+		};
>+/* End PBXNativeTarget section */
>+
>+/* Begin PBXProject section */
>+		7C4AB3991AF0276C003FC8D1 /* Project object */ = {
>+			isa = PBXProject;
>+			attributes = {
>+				LastUpgradeCheck = 0700;
>+			};
>+			buildConfigurationList = 7C4AB39C1AF0276C003FC8D1 /* Build configuration list for PBXProject "lldbWebKitTester" */;
>+			compatibilityVersion = "Xcode 3.2";
>+			developmentRegion = English;
>+			hasScannedForEncodings = 0;
>+			knownRegions = (
>+				en,
>+			);
>+			mainGroup = 7C4AB3981AF0276C003FC8D1;
>+			productRefGroup = 7C4AB3A21AF0276C003FC8D1 /* Products */;
>+			projectDirPath = "";
>+			projectRoot = "";
>+			targets = (
>+				7C4AB3A01AF0276C003FC8D1 /* lldbWebKitTester */,
>+			);
>+		};
>+/* End PBXProject section */
>+
>+/* Begin PBXSourcesBuildPhase section */
>+		7C4AB39D1AF0276C003FC8D1 /* Sources */ = {
>+			isa = PBXSourcesBuildPhase;
>+			buildActionMask = 2147483647;
>+			files = (
>+				7CB6844B1AFA7978002B305C /* main.cpp in Sources */,
>+			);
>+			runOnlyForDeploymentPostprocessing = 0;
>+		};
>+/* End PBXSourcesBuildPhase section */
>+
>+/* Begin XCBuildConfiguration section */
>+		7C4AB3A61AF0276C003FC8D1 /* Debug */ = {
>+			isa = XCBuildConfiguration;
>+			baseConfigurationReference = 7C2227531AFC4D9C008C3338 /* DebugRelease.xcconfig */;
>+			buildSettings = {
>+				DEBUG_DEFINES = "$(DEBUG_DEFINES_debug)";
>+				GCC_OPTIMIZATION_LEVEL = "$(GCC_OPTIMIZATION_LEVEL_debug)";
>+			};
>+			name = Debug;
>+		};
>+		7C4AB3A71AF0276C003FC8D1 /* Release */ = {
>+			isa = XCBuildConfiguration;
>+			baseConfigurationReference = 7C2227531AFC4D9C008C3338 /* DebugRelease.xcconfig */;
>+			buildSettings = {
>+			};
>+			name = Release;
>+		};
>+		7C4AB3A91AF0276C003FC8D1 /* Debug */ = {
>+			isa = XCBuildConfiguration;
>+			baseConfigurationReference = 7C2227521AFC4D9C008C3338 /* lldbWebKitTester.xcconfig */;
>+			buildSettings = {
>+			};
>+			name = Debug;
>+		};
>+		7C4AB3AA1AF0276C003FC8D1 /* Release */ = {
>+			isa = XCBuildConfiguration;
>+			baseConfigurationReference = 7C2227521AFC4D9C008C3338 /* lldbWebKitTester.xcconfig */;
>+			buildSettings = {
>+			};
>+			name = Release;
>+		};
>+/* End XCBuildConfiguration section */
>+
>+/* Begin XCConfigurationList section */
>+		7C4AB39C1AF0276C003FC8D1 /* Build configuration list for PBXProject "lldbWebKitTester" */ = {
>+			isa = XCConfigurationList;
>+			buildConfigurations = (
>+				7C4AB3A61AF0276C003FC8D1 /* Debug */,
>+				7C4AB3A71AF0276C003FC8D1 /* Release */,
>+			);
>+			defaultConfigurationIsVisible = 0;
>+			defaultConfigurationName = Release;
>+		};
>+		7C4AB3A81AF0276C003FC8D1 /* Build configuration list for PBXNativeTarget "lldbWebKitTester" */ = {
>+			isa = XCConfigurationList;
>+			buildConfigurations = (
>+				7C4AB3A91AF0276C003FC8D1 /* Debug */,
>+				7C4AB3AA1AF0276C003FC8D1 /* Release */,
>+			);
>+			defaultConfigurationIsVisible = 0;
>+			defaultConfigurationName = Release;
>+		};
>+/* End XCConfigurationList section */
>+	};
>+	rootObject = 7C4AB3991AF0276C003FC8D1 /* Project object */;
>+}
>diff --git a/Tools/lldb/lldbWebKitTester/main.cpp b/Tools/lldb/lldbWebKitTester/main.cpp
>new file mode 100644
>index 0000000000000000000000000000000000000000..bea464e48cc19b261fbb75e2f7dfa84c3b4a7989
>--- /dev/null
>+++ b/Tools/lldb/lldbWebKitTester/main.cpp
>@@ -0,0 +1,66 @@
>+/*
>+ * Copyright (C) 2018 Apple Inc. All rights reserved.
>+ *
>+ * Redistribution and use in source and binary forms, with or without
>+ * modification, are permitted provided that the following conditions
>+ * are met:
>+ * 1. Redistributions of source code must retain the above copyright
>+ *    notice, this list of conditions and the following disclaimer.
>+ * 2. Redistributions in binary form must reproduce the above copyright
>+ *    notice, this list of conditions and the following disclaimer in the
>+ *    documentation and/or other materials provided with the distribution.
>+ *
>+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
>+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
>+ * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
>+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
>+ * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
>+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
>+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
>+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
>+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
>+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
>+ * THE POSSIBILITY OF SUCH DAMAGE.
>+ */
>+
>+#include <iostream>
>+#include <wtf/text/StringBuilder.h>
>+#include <wtf/text/WTFString.h>
>+
>+extern void breakForTestingSummaryProviders();
>+void breakForTestingSummaryProviders() { return; }
>+
>+// From Tools/TestWebKitAPI/WTFStringUtilities.h
>+template<size_t length>
>+static String utf16String(const char16_t (&string)[length])
>+{
>+    StringBuilder builder;
>+    builder.reserveCapacity(length - 1);
>+    for (auto c : string)
>+        builder.append(static_cast<UChar>(c));
>+    return builder.toString();
>+}
>+
>+static void testSummaryProviders()
>+{
>+    String aNullString { "" };
>+    StringImpl* aNullStringImpl = aNullString.impl();
>+
>+    String anEmptyString { "" };
>+    StringImpl* anEmptyStringImpl = anEmptyString.impl();
>+
>+    String an8BitString { "rÃ©sumÃ©" };
>+    StringImpl* an8BitStringImpl = an8BitString.impl();
>+
>+    String a16BitString = utf16String(u"\u1680Cappuccino\u1680");
>+    StringImpl* a16BitStringImpl = a16BitString.impl();
>+
>+    breakForTestingSummaryProviders();
>+}
>+
>+int main(int argc, const char* argv[])
>+{
>+    testSummaryProviders();
>+    std::cerr << "This executable does nothing and is only meant for debugging lldb_webkit.py." << std::endl;
>+    return 0;
>+}
>diff --git a/Tools/lldb/lldb_webkit_unittest.py b/Tools/lldb/lldb_webkit_unittest.py
>new file mode 100755
>index 0000000000000000000000000000000000000000..7a5628d4508a4dd189785e2953bda8b5bdb67abb
>--- /dev/null
>+++ b/Tools/lldb/lldb_webkit_unittest.py
>@@ -0,0 +1,111 @@
>+#!/usr/bin/env python
>+# -*- coding: utf-8 -*-
>+#
>+# Copyright (C) 2018 Apple Inc. All rights reserved.
>+#
>+# Redistribution and use in source and binary forms, with or without
>+# modification, are permitted provided that the following conditions
>+# are met:
>+# 1.  Redistributions of source code must retain the above copyright
>+#     notice, this list of conditions and the following disclaimer.
>+# 2.  Redistributions in binary form must reproduce the above copyright
>+#     notice, this list of conditions and the following disclaimer in the
>+#     documentation and/or other materials provided with the distribution.
>+#
>+# THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' AND ANY
>+# EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
>+# WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
>+# DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS BE LIABLE FOR ANY
>+# DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
>+# (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
>+# LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON
>+# ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
>+# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
>+# SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>+
>+import lldb
>+import lldb_webkit
>+import os
>+import sys
>+import unittest
>+
>+from webkitpy.common.system.systemhost import SystemHost
>+from webkitpy.port.config import Config
>+
>+
>+class TestSummaryProviders(unittest.TestCase):
>+    @classmethod
>+    def setUpClass(cls):
>+        LLDB_WEBKIT_TESTER_NAME = 'lldbWebKitTester'
>+        BREAK_FOR_TESTING_FUNCTION_NAME = 'breakForTestingSummaryProviders'
>+
>+        cls.sbDebugger = lldb.SBDebugger.Create()
>+        cls.sbDebugger.SetAsync(False)
>+
>+        host = SystemHost()
>+        config = Config(host.executive, host.filesystem)
>+        cls.lldbWebKitTesterExecutable = host.filesystem.join(config.build_directory('Debug'), LLDB_WEBKIT_TESTER_NAME)
>+
>+        cls.sbTarget = cls.sbDebugger.CreateTargetWithFileAndArch(str(cls.lldbWebKitTesterExecutable), lldb.LLDB_ARCH_DEFAULT)
>+        assert cls.sbTarget
>+        cls.sbTarget.BreakpointCreateByName(BREAK_FOR_TESTING_FUNCTION_NAME, cls.sbTarget.GetExecutable().GetFilename())
>+
>+        argv = None
>+        envp = None
>+        cls.sbProcess = cls.sbTarget.LaunchSimple(argv, envp, os.getcwd())
>+        assert cls.sbProcess
>+        assert cls.sbProcess.GetState() == lldb.eStateStopped
>+
>+        cls.sbThread = cls.sbProcess.GetThreadAtIndex(0)
>+        assert cls.sbThread
>+
>+        # Frame 0 is the function with name BREAK_FOR_TESTING_FUNCTION_NAME. We want the frame of the caller of
>+        # BREAK_FOR_TESTING_FUNCTION_NAME because it has all the interesting local variables we want to test.
>+        cls.sbFrame = cls.sbThread.GetFrameAtIndex(1)
>+        assert cls.sbFrame
>+
>+    @classmethod
>+    def tearDownClass(cls):
>+        cls.sbProcess.Kill()
>+        cls.sbTarget.DeleteAllBreakpoints()
>+
>+    # The LLDB Python module does not work with Python multiprocessing and causes errors of the form:
>+    #     objc[76794]: +[__MDQuery initialize] may have been in progress in another thread when fork() was called.
>+    #                  We cannot safely call it or ignore it in the fork() child process. Crashing instead.
>+    # So, we run the following tests serially.
>+
>+    # MARK: WTFStringImpl_SummaryProvider test cases
>+
>+    def stateless_process_test_WTFStringImpl_SummaryProvider_null_string(self):
>+        summary = lldb_webkit.WTFStringImpl_SummaryProvider(self.sbFrame.FindVariable('aNullStringImpl'), {})
>+        self.assertEqual(summary, "{ length = 0, is8bit = 1, contents = '' }")
>+
>+    def stateless_process_test_WTFStringImpl_SummaryProvider_empty_string(self):
>+        summary = lldb_webkit.WTFStringImpl_SummaryProvider(self.sbFrame.FindVariable('anEmptyStringImpl'), {})
>+        self.assertEqual(summary, "{ length = 0, is8bit = 1, contents = '' }")
>+
>+    def stateless_process_test_WTFStringImpl_SummaryProvider_8bit_string(self):
>+        summary = lldb_webkit.WTFStringImpl_SummaryProvider(self.sbFrame.FindVariable('an8BitStringImpl'), {})
>+        self.assertEqual(summary, "{ length = 8, is8bit = 1, contents = 'r\\xe9sum\\xe9' }")
>+
>+    def stateless_process_test_WTFStringImpl_SummaryProvider_16bit_string(self):
>+        summary = lldb_webkit.WTFStringImpl_SummaryProvider(self.sbFrame.FindVariable('a16BitStringImpl'), {})
>+        self.assertEqual(summary, u"{ length = 13, is8bit = 0, contents = '\\u1680Cappuccino\\u1680\\x00' }")
>+
>+    # MARK: WTFString_SummaryProvider test cases
>+
>+    def stateless_process_test_WTFString_SummaryProvider_null_string(self):
>+        summary = lldb_webkit.WTFString_SummaryProvider(self.sbFrame.FindVariable('aNullString'), {})
>+        self.assertEqual(summary, "{ length = 0, contents = '' }")
>+
>+    def stateless_process_test_WTFString_SummaryProvider_empty_string(self):
>+        summary = lldb_webkit.WTFString_SummaryProvider(self.sbFrame.FindVariable('anEmptyString'), {})
>+        self.assertEqual(summary, "{ length = 0, contents = '' }")
>+
>+    def stateless_process_test_WTFString_SummaryProvider_8bit_string(self):
>+        summary = lldb_webkit.WTFString_SummaryProvider(self.sbFrame.FindVariable('an8BitString'), {})
>+        self.assertEqual(summary, "{ length = 8, contents = 'r\\xe9sum\\xe9' }")
>+
>+    def stateless_process_test_WTFString_SummaryProvider_16bit_string(self):
>+        summary = lldb_webkit.WTFString_SummaryProvider(self.sbFrame.FindVariable('a16BitString'), {})
>+        self.assertEqual(summary, u"{ length = 13, contents = '\\u1680Cappuccino\\u1680\\x00' }")

Actions: View | Formatted Diff | Diff

Attachments on bug 183744: 336054 | 336055 | 336057 | 340870 | 340913 | 341110 | 341210 | 341388 | 341691 | 341712 | 341714 | 341716 | 341731 | 341733 | 341791 | 341794 | 343791