Attachment 340864 Details for Bug 185823 – Patch

[patch] Patch

bug-185823-20180521110207.patch (text/plain), 2.18 KB, created by Daniel Bates on 2018-05-21 11:02:07 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Daniel Bates

Created: 2018-05-21 11:02:07 PDT

Size: 2.18 KB

patch

obsolete

>Subversion Revision: 231991
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index e64ddb8007356cfe3c31ca7bf88af7235df823e0..f569f3b1a2ad65a61dd5e388e96f09e05b8adb02 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,24 @@
>+2018-05-21  Daniel Bates  <dabates@apple.com>
>+
>+        test-webkitpy messages logged using __main__ logger are not displayed
>+        https://bugs.webkit.org/show_bug.cgi?id=185823
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Configure the logger for __main__ so that messages that are logged before it parses its
>+        command line arguments are printed to standard error.
>+
>+        Currently test-webkitpy creates a named logger (__main__) for its logging. However it does
>+        not configure a stream to use for printing until after it parses its command line arguments
>+        via webkitpy.test.printer.Printer.configure(). Messages logged until then are never written
>+        to the console. We explicitly configure the __main__ logger instead of calling webkitpy.test.printer.Printer.configure()
>+        earlier because the latter both configures a stream and filters logged messages based on
>+        the specified verbosity. Logged messaged from code in __main__ should not be subject to
>+        such filtering. So, we explicitly configure the __main__ logger.
>+
>+        * Scripts/webkitpy/test/main.py:
>+        (main):
>+
> 2018-05-18  Jer Noble  <jer.noble@apple.com>
> 
>         Complete fix for enabling modern EME by default
>diff --git a/Tools/Scripts/webkitpy/test/main.py b/Tools/Scripts/webkitpy/test/main.py
>index d811372061d63a07cc43d9463aa804580af70752..5facaa546dee9658bac9848ea02e1fc482a0f2ef 100644
>--- a/Tools/Scripts/webkitpy/test/main.py
>+++ b/Tools/Scripts/webkitpy/test/main.py
>@@ -36,6 +36,7 @@ import time
> import traceback
> import unittest
> 
>+from webkitpy.common.system.logutils import configure_logging
> from webkitpy.common.system.filesystem import FileSystem
> from webkitpy.test.finder import Finder
> from webkitpy.test.printer import Printer
>@@ -45,6 +46,8 @@ _log = logging.getLogger(__name__)
> 
> 
> def main():
>+    configure_logging(logger=_log)
>+
>     up = os.path.dirname
>     webkit_root = up(up(up(up(up(os.path.abspath(__file__))))))
>

Flags:

aakash_jain: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 185823: 340864