Attachment 340858 Details for Bug 185176 – Patch

[patch] Patch

bug-185176-20180522021537.patch (text/plain), 29.68 KB, created by Yusuke Suzuki on 2018-05-21 10:15:38 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Yusuke Suzuki

Created: 2018-05-21 10:15:38 PDT

Size: 29.68 KB

patch

obsolete

>Subversion Revision: 232017
>diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog
>index a6dc21c321bbaf708e0bb8243ee2467fc72ce379..3cc89616f4b3f0add33056d833a7bc0c2543e60f 100644
>--- a/Source/JavaScriptCore/ChangeLog
>+++ b/Source/JavaScriptCore/ChangeLog
>@@ -1,3 +1,12 @@
>+2018-05-21  Yusuke Suzuki  <utatane.tea@gmail.com>
>+
>+        Use more C++17
>+        https://bugs.webkit.org/show_bug.cgi?id=185176
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Configurations/Base.xcconfig:
>+
> 2018-05-21  Yusuke Suzuki  <utatane.tea@gmail.com>
> 
>         Unreviewed, fix 32bit and scope release
>diff --git a/Source/ThirdParty/ANGLE/ChangeLog b/Source/ThirdParty/ANGLE/ChangeLog
>index cb0e3b863b0e34293328269e56d3e7e6ef4a5c9c..9c724dcd6093aec855c76dfcb3422d9143c99f57 100644
>--- a/Source/ThirdParty/ANGLE/ChangeLog
>+++ b/Source/ThirdParty/ANGLE/ChangeLog
>@@ -1,3 +1,12 @@
>+2018-05-21  Yusuke Suzuki  <utatane.tea@gmail.com>
>+
>+        Use more C++17
>+        https://bugs.webkit.org/show_bug.cgi?id=185176
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Configurations/Base.xcconfig:
>+
> 2018-04-18  Jer Noble  <jer.noble@apple.com>
> 
>         Don't put build products into WK_ALTERNATE_WEBKIT_SDK_PATH for engineering builds
>diff --git a/Source/ThirdParty/ChangeLog b/Source/ThirdParty/ChangeLog
>index a0917c0eca86e47a6284488b674ada5b7df58dbd..4450ce007f9eb97a8e5db24004ae105233909f37 100644
>--- a/Source/ThirdParty/ChangeLog
>+++ b/Source/ThirdParty/ChangeLog
>@@ -1,3 +1,12 @@
>+2018-05-21  Yusuke Suzuki  <utatane.tea@gmail.com>
>+
>+        Use more C++17
>+        https://bugs.webkit.org/show_bug.cgi?id=185176
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * gtest/xcode/Config/General.xcconfig:
>+
> 2018-05-14  Yusuke Suzuki  <utatane.tea@gmail.com>
> 
>         [Win] Use C++17 in MSVC
>diff --git a/Source/WTF/ChangeLog b/Source/WTF/ChangeLog
>index 44e7a19b3ebc4842f2084973d1fdb348cf25aa84..4a377c438460e13d163a2f81f026639008d76404 100644
>--- a/Source/WTF/ChangeLog
>+++ b/Source/WTF/ChangeLog
>@@ -1,3 +1,13 @@
>+2018-05-21  Yusuke Suzuki  <utatane.tea@gmail.com>
>+
>+        Use more C++17
>+        https://bugs.webkit.org/show_bug.cgi?id=185176
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Configurations/Base.xcconfig:
>+        * wtf/StdLibExtras.h:
>+
> 2018-05-18  Filip Pizlo  <fpizlo@apple.com>
> 
>         DFG should inline InstanceOf ICs
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 43ab552a1e97453264e3da8c8090afc9382cced8..48aff088ca81fa62cb98cd0dbd20bf97ce0aaf55 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,15 @@
>+2018-05-21  Yusuke Suzuki  <utatane.tea@gmail.com>
>+
>+        Use more C++17
>+        https://bugs.webkit.org/show_bug.cgi?id=185176
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Configurations/Base.xcconfig:
>+        * DerivedSources.make:
>+        * platform/ios/LegacyTileGrid.mm:
>+        (WebCore::LegacyTileGrid::dropDistantTiles):
>+
> 2018-05-21  Alicia Boya GarcÃa  <aboya@igalia.com>
> 
>         [MSE][GStreamer] Stream::decodebinSinkPad is read but never assigned
>diff --git a/Source/WebCore/PAL/ChangeLog b/Source/WebCore/PAL/ChangeLog
>index 423c5b01152566dd6570099aba3196db150284df..9205d36e2cc73e2673017e916e9c2c281fc1f726 100644
>--- a/Source/WebCore/PAL/ChangeLog
>+++ b/Source/WebCore/PAL/ChangeLog
>@@ -1,3 +1,12 @@
>+2018-05-21  Yusuke Suzuki  <utatane.tea@gmail.com>
>+
>+        Use more C++17
>+        https://bugs.webkit.org/show_bug.cgi?id=185176
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Configurations/Base.xcconfig:
>+
> 2018-05-18  Commit Queue  <commit-queue@webkit.org>
> 
>         Unreviewed, rolling out r231982.
>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index 71126dcd63166acabffd702e2491371cfce93b6e..e15624d4b92533dedfe897eea6c96f53ff6a96b8 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,12 @@
>+2018-05-21  Yusuke Suzuki  <utatane.tea@gmail.com>
>+
>+        Use more C++17
>+        https://bugs.webkit.org/show_bug.cgi?id=185176
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Configurations/Base.xcconfig:
>+
> 2018-05-18  Devin Rousso  <webkit@devinrousso.com>
> 
>         Web Inspector: Canvas: put `hasVisualEffect` behind an experimental setting
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 35dc9aa5744131177495eb730597fae12002b943..4677cad278e118eb8a52fcae090f0d57eda653f6 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,13 @@
>+2018-05-21  Yusuke Suzuki  <utatane.tea@gmail.com>
>+
>+        Use more C++17
>+        https://bugs.webkit.org/show_bug.cgi?id=185176
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Configurations/Base.xcconfig:
>+        * DerivedSources.make:
>+
> 2018-05-21  Carlos Garcia Campos  <cgarcia@igalia.com>
> 
>         Unreviewed. Update OptionsGTK.cmake and NEWS for 2.21.2 release.
>diff --git a/Source/WebKitLegacy/mac/ChangeLog b/Source/WebKitLegacy/mac/ChangeLog
>index fa88b46af23209eb05211e5e83fc04c689567d19..9d18f2886246ed88cbb0298b19a69031718fdb01 100644
>--- a/Source/WebKitLegacy/mac/ChangeLog
>+++ b/Source/WebKitLegacy/mac/ChangeLog
>@@ -1,3 +1,13 @@
>+2018-05-21  Yusuke Suzuki  <utatane.tea@gmail.com>
>+
>+        Use more C++17
>+        https://bugs.webkit.org/show_bug.cgi?id=185176
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Configurations/Base.xcconfig:
>+        * Configurations/WebKitLegacy.xcconfig:
>+
> 2018-05-21  Antti Koivisto  <antti@apple.com>
> 
>         WebView._preferencesChanged should apply colorFilterEnabled preference before parsing user stylesheet
>diff --git a/Source/bmalloc/ChangeLog b/Source/bmalloc/ChangeLog
>index 87820a7b67157c9460693b4062fe94ffa83683ec..5b3e1ab3a4525237bf7baeb6166dfe96706a0fc0 100644
>--- a/Source/bmalloc/ChangeLog
>+++ b/Source/bmalloc/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-05-21  Yusuke Suzuki  <utatane.tea@gmail.com>
>+
>+        Use more C++17
>+        https://bugs.webkit.org/show_bug.cgi?id=185176
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Add BNO_RETURN.
>+
>+        * Configurations/Base.xcconfig:
>+        * bmalloc/BCompiler.h:
>+        * bmalloc/Scavenger.h:
>+
> 2018-05-06  Yusuke Suzuki  <utatane.tea@gmail.com>
> 
>         [JSC] Remove "using namespace std;" from JSC, bmalloc, WTF
>diff --git a/Source/JavaScriptCore/Configurations/Base.xcconfig b/Source/JavaScriptCore/Configurations/Base.xcconfig
>index d11c7d4526316082cad015894422c0c97a8c5f26..ea8f44582b01aa7f2b45be5bf398bef4145ba1a3 100644
>--- a/Source/JavaScriptCore/Configurations/Base.xcconfig
>+++ b/Source/JavaScriptCore/Configurations/Base.xcconfig
>@@ -30,7 +30,7 @@ USE_INTERNAL_SDK_Release = $(HAVE_INTERNAL_SDK);
> 
> ALWAYS_SEARCH_USER_PATHS = NO;
> 
>-CLANG_CXX_LANGUAGE_STANDARD = gnu++14;
>+CLANG_CXX_LANGUAGE_STANDARD = gnu++1z;
> CLANG_CXX_LIBRARY = libc++;
> CLANG_ENABLE_OBJC_WEAK = YES;
> CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES;
>diff --git a/Source/ThirdParty/ANGLE/Configurations/Base.xcconfig b/Source/ThirdParty/ANGLE/Configurations/Base.xcconfig
>index 0f6d6eda0f69f5932b5b80d673b64c976c175591..9128f514341054b6a884ba260770811faa06574c 100644
>--- a/Source/ThirdParty/ANGLE/Configurations/Base.xcconfig
>+++ b/Source/ThirdParty/ANGLE/Configurations/Base.xcconfig
>@@ -7,7 +7,7 @@ USE_INTERNAL_SDK_Release = $(HAVE_INTERNAL_SDK);
> 
> ALWAYS_SEARCH_USER_PATHS = NO;
> 
>-CLANG_CXX_LANGUAGE_STANDARD = gnu++14;
>+CLANG_CXX_LANGUAGE_STANDARD = gnu++1z;
> CLANG_CXX_LIBRARY = libc++;
> CLANG_ENABLE_OBJC_WEAK = YES;
> CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES;
>diff --git a/Source/ThirdParty/gtest/xcode/Config/General.xcconfig b/Source/ThirdParty/gtest/xcode/Config/General.xcconfig
>index 3bd2a586a5705fcf66ec2d9592afac3d8d6d7de0..69eca8c11e9d8eec4213484dd6ac797ec3278d04 100644
>--- a/Source/ThirdParty/gtest/xcode/Config/General.xcconfig
>+++ b/Source/ThirdParty/gtest/xcode/Config/General.xcconfig
>@@ -51,7 +51,7 @@ SEPARATE_STRIP = YES
> GCC_C_LANGUAGE_STANDARD = c99
> 
> // Force C++14
>-CLANG_CXX_LANGUAGE_STANDARD = gnu++14;
>+CLANG_CXX_LANGUAGE_STANDARD = gnu++1z;
> 
> // not sure why apple defaults this on, but it's pretty risky
> ALWAYS_SEARCH_USER_PATHS = NO
>diff --git a/Source/WTF/Configurations/Base.xcconfig b/Source/WTF/Configurations/Base.xcconfig
>index a7bf7933c0c34be9175de831a3c9451eaf85a23a..37b85d7084f3ced7202548277e4d1b2b80ae0e98 100644
>--- a/Source/WTF/Configurations/Base.xcconfig
>+++ b/Source/WTF/Configurations/Base.xcconfig
>@@ -30,7 +30,7 @@ USE_INTERNAL_SDK_Release = $(HAVE_INTERNAL_SDK);
> 
> ALWAYS_SEARCH_USER_PATHS = NO;
> 
>-CLANG_CXX_LANGUAGE_STANDARD = gnu++14;
>+CLANG_CXX_LANGUAGE_STANDARD = gnu++1z;
> CLANG_CXX_LIBRARY = libc++;
> CLANG_ENABLE_OBJC_WEAK = YES;
> CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES;
>diff --git a/Source/WTF/wtf/StdLibExtras.h b/Source/WTF/wtf/StdLibExtras.h
>index 760b2ad9302d481eb1e9a7190969970f93f85210..6e3c94d1a5052921dd85b8047ff5ef078bc0eba0 100644
>--- a/Source/WTF/wtf/StdLibExtras.h
>+++ b/Source/WTF/wtf/StdLibExtras.h
>@@ -543,9 +543,9 @@ template<class B0, class B1, class B2, class... Bn> struct wtf_conjunction_impl<
> template<class... _Args> struct conjunction : wtf_conjunction_impl<_Args...> { };
> #endif
> 
>-// Provide in_place_t when not building with -std=c++17, or when building with libstdc++ 6
>+// Provide in_place_t when not building with -std=c++17 or when building with libstdc++ 6, or when building with < Xcode 9.0.
> // (which doesn't define the _GLIBCXX_RELEASE macro that's been introduced in libstdc++ 7).
>-#if (__cplusplus < 201703L || (defined(__GLIBCXX__) && !defined(_GLIBCXX_RELEASE))) && (!defined(_MSC_FULL_VER) || _MSC_FULL_VER < 190023918)
>+#if (__cplusplus < 201703L || (defined(__GLIBCXX__) && !defined(_GLIBCXX_RELEASE))) && (!defined(_MSC_FULL_VER) || _MSC_FULL_VER < 190023918) && !(PLATFORM(COCOA) && __clang_major__ >= 9)
> 
> // These are inline variable for C++17 and later.
> #define __IN_PLACE_INLINE_VARIABLE static const
>diff --git a/Source/WebCore/Configurations/Base.xcconfig b/Source/WebCore/Configurations/Base.xcconfig
>index 412ac21c2d17a7fcaf1c7bfbdc7eb3904b098c67..aceb6753b011542ae902d251cb0036c26067bdc5 100644
>--- a/Source/WebCore/Configurations/Base.xcconfig
>+++ b/Source/WebCore/Configurations/Base.xcconfig
>@@ -30,7 +30,7 @@ USE_INTERNAL_SDK_Release = $(HAVE_INTERNAL_SDK);
> 
> ALWAYS_SEARCH_USER_PATHS = NO;
> 
>-CLANG_CXX_LANGUAGE_STANDARD = gnu++14;
>+CLANG_CXX_LANGUAGE_STANDARD = gnu++1z;
> CLANG_CXX_LIBRARY = libc++;
> CLANG_ENABLE_OBJC_WEAK = YES;
> CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES;
>diff --git a/Source/WebCore/DerivedSources.make b/Source/WebCore/DerivedSources.make
>index 262e0c7cbb1d4682423ca187b9ef2abbf309084b..608d498f8452d36340d8c476f53a6d4020fd984d 100644
>--- a/Source/WebCore/DerivedSources.make
>+++ b/Source/WebCore/DerivedSources.make
>@@ -1017,19 +1017,19 @@ ifeq ($(USE_LLVM_TARGET_TRIPLES_FOR_CLANG),YES)
> 	TARGET_TRIPLE_FLAGS=-target $(CURRENT_ARCH)-$(LLVM_TARGET_TRIPLE_VENDOR)-$(LLVM_TARGET_TRIPLE_OS_VERSION)$(LLVM_TARGET_TRIPLE_SUFFIX)
> endif
> 
>-ifeq ($(shell $(CC) -std=gnu++17 -x c++ -E -P -dM $(SDK_FLAGS) $(TARGET_TRIPLE_FLAGS) $(FRAMEWORK_FLAGS) $(HEADER_FLAGS) -include "wtf/Platform.h" /dev/null | grep ' WTF_PLATFORM_IOS ' | cut -d' ' -f3), 1)
>+ifeq ($(shell $(CC) -std=gnu++1z -x c++ -E -P -dM $(SDK_FLAGS) $(TARGET_TRIPLE_FLAGS) $(FRAMEWORK_FLAGS) $(HEADER_FLAGS) -include "wtf/Platform.h" /dev/null | grep ' WTF_PLATFORM_IOS ' | cut -d' ' -f3), 1)
>     WTF_PLATFORM_IOS = 1
> else
>     WTF_PLATFORM_IOS = 0
> endif
> 
>-ifeq ($(shell $(CC) -std=gnu++17 -x c++ -E -P -dM $(SDK_FLAGS) $(TARGET_TRIPLE_FLAGS) $(FRAMEWORK_FLAGS) $(HEADER_FLAGS) -include "wtf/Platform.h" /dev/null | grep USE_APPLE_INTERNAL_SDK | cut -d' ' -f3), 1)
>+ifeq ($(shell $(CC) -std=gnu++1z -x c++ -E -P -dM $(SDK_FLAGS) $(TARGET_TRIPLE_FLAGS) $(FRAMEWORK_FLAGS) $(HEADER_FLAGS) -include "wtf/Platform.h" /dev/null | grep USE_APPLE_INTERNAL_SDK | cut -d' ' -f3), 1)
>     USE_APPLE_INTERNAL_SDK = 1
> else
>     USE_APPLE_INTERNAL_SDK = 0
> endif
> 
>-ifeq ($(shell $(CC) -std=gnu++17 -x c++ -E -P -dM $(SDK_FLAGS) $(TARGET_TRIPLE_FLAGS) $(FRAMEWORK_FLAGS) $(HEADER_FLAGS) -include "wtf/Platform.h" /dev/null | grep ENABLE_ORIENTATION_EVENTS | cut -d' ' -f3), 1)
>+ifeq ($(shell $(CC) -std=gnu++1z -x c++ -E -P -dM $(SDK_FLAGS) $(TARGET_TRIPLE_FLAGS) $(FRAMEWORK_FLAGS) $(HEADER_FLAGS) -include "wtf/Platform.h" /dev/null | grep ENABLE_ORIENTATION_EVENTS | cut -d' ' -f3), 1)
>     ENABLE_ORIENTATION_EVENTS = 1
> endif
> 
>diff --git a/Source/WebCore/PAL/Configurations/Base.xcconfig b/Source/WebCore/PAL/Configurations/Base.xcconfig
>index 5826fd0c89fa3f11ccfa752134445cde5ef5abf7..2ac2ddcad1dad827f32604dfef41a4ab6db6c31f 100644
>--- a/Source/WebCore/PAL/Configurations/Base.xcconfig
>+++ b/Source/WebCore/PAL/Configurations/Base.xcconfig
>@@ -30,7 +30,7 @@ USE_INTERNAL_SDK_Release = $(HAVE_INTERNAL_SDK);
> 
> ALWAYS_SEARCH_USER_PATHS = NO;
> 
>-CLANG_CXX_LANGUAGE_STANDARD = gnu++14;
>+CLANG_CXX_LANGUAGE_STANDARD = gnu++1z;
> CLANG_CXX_LIBRARY = libc++;
> CLANG_ENABLE_OBJC_WEAK = YES;
> CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES;
>diff --git a/Source/WebCore/platform/ios/LegacyTileGrid.mm b/Source/WebCore/platform/ios/LegacyTileGrid.mm
>index 11ea51b69d167807cddbc2d2c272c1ad4695c55a..a188ab504c798c1ac708aaa412add74b6e2b1f73 100644
>--- a/Source/WebCore/platform/ios/LegacyTileGrid.mm
>+++ b/Source/WebCore/platform/ios/LegacyTileGrid.mm
>@@ -130,9 +130,13 @@ bool LegacyTileGrid::dropDistantTiles(unsigned tilesNeeded, double shortestDista
>         if (distance <= shortestDistance)
>             continue;
>         toRemove.append(std::make_pair(distance, index));
>-        std::push_heap(toRemove.begin(), toRemove.end(), std::ptr_fun(isFartherAway<TileIndex>));
>+        std::push_heap(toRemove.begin(), toRemove.end(), [] (const auto& left, const auto& right) {
>+            return isFartherAway<TileIndex>(left, right);
>+        });
>         if (toRemove.size() > tilesToRemoveCount) {
>-            std::pop_heap(toRemove.begin(), toRemove.end(), std::ptr_fun(isFartherAway<TileIndex>));
>+            std::pop_heap(toRemove.begin(), toRemove.end(), [] (const auto& left, const auto& right) {
>+                return isFartherAway<TileIndex>(left, right);
>+            });
>             toRemove.removeLast();
>         }
>     }
>diff --git a/Source/WebInspectorUI/Configurations/Base.xcconfig b/Source/WebInspectorUI/Configurations/Base.xcconfig
>index 850c6175f7a1dd8ca9dfd3ca710183441376f6c7..225aab13dff4b39d020fa42d2a9bd26aeab777b7 100644
>--- a/Source/WebInspectorUI/Configurations/Base.xcconfig
>+++ b/Source/WebInspectorUI/Configurations/Base.xcconfig
>@@ -12,7 +12,7 @@ DEBUG_INFORMATION_FORMAT = dwarf-with-dsym;
> ALWAYS_SEARCH_USER_PATHS = NO;
> FRAMEWORK_SEARCH_PATHS = $(WK_QUOTED_OVERRIDE_FRAMEWORKS_DIR) $(SYSTEM_LIBRARY_DIR)/PrivateFrameworks $(inherited);
> 
>-CLANG_CXX_LANGUAGE_STANDARD = gnu++14;
>+CLANG_CXX_LANGUAGE_STANDARD = gnu++1z;
> CLANG_CXX_LIBRARY = libc++;
> CLANG_ENABLE_OBJC_WEAK = YES;
> CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES;
>diff --git a/Source/WebKit/Configurations/Base.xcconfig b/Source/WebKit/Configurations/Base.xcconfig
>index b07a5b1c35cae64a75bec1519598e65b21a03c8c..ae3ab502657133f8b663ca3687a33f116cdecb16 100644
>--- a/Source/WebKit/Configurations/Base.xcconfig
>+++ b/Source/WebKit/Configurations/Base.xcconfig
>@@ -30,7 +30,7 @@ USE_INTERNAL_SDK_Release = $(HAVE_INTERNAL_SDK);
> 
> ALWAYS_SEARCH_USER_PATHS = NO;
> 
>-CLANG_CXX_LANGUAGE_STANDARD = gnu++14;
>+CLANG_CXX_LANGUAGE_STANDARD = gnu++1z;
> CLANG_CXX_LIBRARY = libc++;
> CLANG_ENABLE_OBJC_WEAK = YES;
> CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES;
>@@ -128,7 +128,7 @@ SUPPORTS_TEXT_BASED_API[sdk=appletv*] = NO;
> SUPPORTS_TEXT_BASED_API[sdk=watch*] = NO;
> 
> OTHER_TAPI_FLAGS = $(OTHER_TAPI_FLAGS_$(WK_COCOA_TOUCH));
>-OTHER_TAPI_FLAGS_cocoatouch = -x objective-c++ -std=c++17 -fno-rtti -DRELEASE_WITHOUT_OPTIMIZATIONS;
>+OTHER_TAPI_FLAGS_cocoatouch = -x objective-c++ -std=gnu++1z -fno-rtti -DRELEASE_WITHOUT_OPTIMIZATIONS;
> TAPI_VERIFY_MODE[sdk=iphone*] = Pedantic;
> 
> // This is required to make LLVM_TARGET_TRIPLE_SUFFIX propagate into scripts.
>diff --git a/Source/WebKit/DerivedSources.make b/Source/WebKit/DerivedSources.make
>index f78d02747acb5ebdb72eb29116a8715f65817427..ec1ca3a2c0faf4822781b9d9f7835ceea18bb402 100644
>--- a/Source/WebKit/DerivedSources.make
>+++ b/Source/WebKit/DerivedSources.make
>@@ -268,7 +268,7 @@ AUTOMATION_PROTOCOL_OUTPUT_FILES = \
> #
> 
> ifeq ($(OS),MACOS)
>-ifeq ($(shell $(CC) -std=gnu++17 -x c++ -E -P -dM $(SDK_FLAGS) $(TARGET_TRIPLE_FLAGS) $(FRAMEWORK_FLAGS) $(HEADER_FLAGS) -include "wtf/Platform.h" /dev/null | grep ' WTF_PLATFORM_IOS ' | cut -d' ' -f3), 1)
>+ifeq ($(shell $(CC) -std=gnu++1z -x c++ -E -P -dM $(SDK_FLAGS) $(TARGET_TRIPLE_FLAGS) $(FRAMEWORK_FLAGS) $(HEADER_FLAGS) -include "wtf/Platform.h" /dev/null | grep ' WTF_PLATFORM_IOS ' | cut -d' ' -f3), 1)
> 	AUTOMATION_BACKEND_PLATFORM_ARGUMENTS = --platform iOS
> else
> 	AUTOMATION_BACKEND_PLATFORM_ARGUMENTS = --platform macOS
>diff --git a/Source/WebKitLegacy/mac/Configurations/Base.xcconfig b/Source/WebKitLegacy/mac/Configurations/Base.xcconfig
>index 0a8e2d4dd381cc3e60e2e2583e86342fadb41bbd..19281aa5a7150c20882aa39c400353b4ad44a57c 100644
>--- a/Source/WebKitLegacy/mac/Configurations/Base.xcconfig
>+++ b/Source/WebKitLegacy/mac/Configurations/Base.xcconfig
>@@ -30,7 +30,7 @@ USE_INTERNAL_SDK_Release = $(HAVE_INTERNAL_SDK);
> 
> ALWAYS_SEARCH_USER_PATHS = NO;
> 
>-CLANG_CXX_LANGUAGE_STANDARD = gnu++14;
>+CLANG_CXX_LANGUAGE_STANDARD = gnu++1z;
> CLANG_CXX_LIBRARY = libc++;
> CLANG_ENABLE_OBJC_WEAK = YES;
> CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES;
>diff --git a/Source/WebKitLegacy/mac/Configurations/WebKitLegacy.xcconfig b/Source/WebKitLegacy/mac/Configurations/WebKitLegacy.xcconfig
>index a1a076e56a7cf483e690dd876f49dfd009b5ea0d..2edcc0599c1633440b4547aac0d19f55a9d95af0 100644
>--- a/Source/WebKitLegacy/mac/Configurations/WebKitLegacy.xcconfig
>+++ b/Source/WebKitLegacy/mac/Configurations/WebKitLegacy.xcconfig
>@@ -139,5 +139,5 @@ WK_QUOTED_OVERRIDE_FRAMEWORKS_DIR_YES = "$(WK_OVERRIDE_FRAMEWORKS_DIR)";
> SUPPORTS_TEXT_BASED_API[sdk=iphone*] = $(USE_INTERNAL_SDK);
> SUPPORTS_TEXT_BASED_API[sdk=appletv*] = NO;
> SUPPORTS_TEXT_BASED_API[sdk=watch*] = NO;
>-OTHER_TAPI_FLAGS[sdk=iphone*] = -x objective-c++ -std=c++17 -fno-rtti -DRELEASE_WITHOUT_OPTIMIZATIONS;
>+OTHER_TAPI_FLAGS[sdk=iphone*] = -x objective-c++ -std=gnu++1z -fno-rtti -DRELEASE_WITHOUT_OPTIMIZATIONS;
> TAPI_VERIFY_MODE[sdk=iphone*] = Pedantic;
>diff --git a/Source/bmalloc/Configurations/Base.xcconfig b/Source/bmalloc/Configurations/Base.xcconfig
>index 9f572893580da6a493d1b4522d804f3f95a86012..538891751b8a002ebbb4e5b065ec55c8982dda2d 100644
>--- a/Source/bmalloc/Configurations/Base.xcconfig
>+++ b/Source/bmalloc/Configurations/Base.xcconfig
>@@ -30,7 +30,7 @@ USE_INTERNAL_SDK_Release = $(HAVE_INTERNAL_SDK);
> 
> ALWAYS_SEARCH_USER_PATHS = NO;
> 
>-CLANG_CXX_LANGUAGE_STANDARD = gnu++14;
>+CLANG_CXX_LANGUAGE_STANDARD = gnu++1z;
> CLANG_CXX_LIBRARY = libc++;
> CLANG_ENABLE_OBJC_WEAK = YES;
> CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES;
>diff --git a/Source/bmalloc/bmalloc/BCompiler.h b/Source/bmalloc/bmalloc/BCompiler.h
>index 1a927d8440cdce8006c876e517b4b0d02ad6dd59..b903c5f2c44752a600fc5801173578d20e5d2fcc 100644
>--- a/Source/bmalloc/bmalloc/BCompiler.h
>+++ b/Source/bmalloc/bmalloc/BCompiler.h
>@@ -35,3 +35,16 @@
> 
> #define BASAN_ENABLED BCOMPILER_HAS_CLANG_FEATURE(address_sanitizer)
> 
>+/* NO_RETURN */
>+
>+#if !defined(NO_RETURN) && defined(__GNUC__)
>+#define BNO_RETURN __attribute((__noreturn__))
>+#endif
>+
>+#if !defined(BNO_RETURN) && defined(_MSC_VER)
>+#define BNO_RETURN __declspec(noreturn)
>+#endif
>+
>+#if !defined(BNO_RETURN)
>+#define BNO_RETURN
>+#endif
>diff --git a/Source/bmalloc/bmalloc/Scavenger.h b/Source/bmalloc/bmalloc/Scavenger.h
>index 858d66a94c7ad1df6814a58d2442ac35a2dd2727..a7377c4c0ed4e00e920ae2c2d3880fd80911638d 100644
>--- a/Source/bmalloc/bmalloc/Scavenger.h
>+++ b/Source/bmalloc/bmalloc/Scavenger.h
>@@ -80,8 +80,8 @@ class Scavenger {
> 
>     void scheduleIfUnderMemoryPressureHoldingLock(size_t bytes);
> 
>-    static void threadEntryPoint(Scavenger*);
>-    void threadRunLoop();
>+    BNO_RETURN static void threadEntryPoint(Scavenger*);
>+    BNO_RETURN void threadRunLoop();
>     
>     void setSelfQOSClass();
>     void setThreadName(const char*);
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index ef6de93cde92ec45fa270ddf4430ca1520e8cef6..abc0bc615a6fe9683ba98eb829bf49aeeb653c9a 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,17 @@
>+2018-05-21  Yusuke Suzuki  <utatane.tea@gmail.com>
>+
>+        Use more C++17
>+        https://bugs.webkit.org/show_bug.cgi?id=185176
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * DumpRenderTree/mac/Configurations/Base.xcconfig:
>+        * ImageDiff/cg/Configurations/Base.xcconfig:
>+        * MiniBrowser/Configurations/Base.xcconfig:
>+        * MobileMiniBrowser/Configurations/Base.xcconfig:
>+        * TestWebKitAPI/Configurations/Base.xcconfig:
>+        * WebKitTestRunner/Configurations/Base.xcconfig:
>+
> 2018-05-21  Carlos Garcia Campos  <cgarcia@igalia.com>
> 
>         Unreviewed, rolling out r222967.
>diff --git a/Tools/DumpRenderTree/mac/Configurations/Base.xcconfig b/Tools/DumpRenderTree/mac/Configurations/Base.xcconfig
>index 7f6e9cd19144fed521c6fc75a3a457e596d3eb25..476562603a51b0c8d2121c0035965570ab44421b 100644
>--- a/Tools/DumpRenderTree/mac/Configurations/Base.xcconfig
>+++ b/Tools/DumpRenderTree/mac/Configurations/Base.xcconfig
>@@ -39,7 +39,7 @@ WK_PRIVATE_FRAMEWORK_STUBS_DIR_iphone_YES_ = $(SRCROOT)/../../WebKitLibraries/We
> 
> FRAMEWORK_SEARCH_PATHS[sdk=iphone*] = $(WK_PRIVATE_FRAMEWORK_STUBS_DIR);
> 
>-CLANG_CXX_LANGUAGE_STANDARD = gnu++14;
>+CLANG_CXX_LANGUAGE_STANDARD = gnu++1z;
> CLANG_CXX_LIBRARY = libc++;
> CLANG_ENABLE_OBJC_WEAK = YES;
> CLANG_WARN_CXX0X_EXTENSIONS = NO;
>diff --git a/Tools/ImageDiff/cg/Configurations/Base.xcconfig b/Tools/ImageDiff/cg/Configurations/Base.xcconfig
>index ef77ba9b8ce187703e7e75bfe9d32bfc87472533..1389484e3e2c06b7451e7ffd686082155fb60d8f 100644
>--- a/Tools/ImageDiff/cg/Configurations/Base.xcconfig
>+++ b/Tools/ImageDiff/cg/Configurations/Base.xcconfig
>@@ -28,7 +28,7 @@ USE_INTERNAL_SDK_Production = YES;
> USE_INTERNAL_SDK_Debug = $(HAVE_INTERNAL_SDK);
> USE_INTERNAL_SDK_Release = $(HAVE_INTERNAL_SDK);
> 
>-CLANG_CXX_LANGUAGE_STANDARD = gnu++14;
>+CLANG_CXX_LANGUAGE_STANDARD = gnu++1z;
> CLANG_CXX_LIBRARY = libc++;
> CLANG_ENABLE_OBJC_WEAK = YES;
> CLANG_WARN_CXX0X_EXTENSIONS = NO;
>diff --git a/Tools/MiniBrowser/Configurations/Base.xcconfig b/Tools/MiniBrowser/Configurations/Base.xcconfig
>index 4e07566e0deb89cd3a36401dedc41cd42c5d658e..a230dfadc7d5b9f1d699b8c3de1f0195bc8d9c97 100644
>--- a/Tools/MiniBrowser/Configurations/Base.xcconfig
>+++ b/Tools/MiniBrowser/Configurations/Base.xcconfig
>@@ -30,7 +30,7 @@ USE_INTERNAL_SDK_Release = $(HAVE_INTERNAL_SDK);
> 
> GCC_PREPROCESSOR_DEFINITIONS = DISABLE_LEGACY_WEBKIT_DEPRECATIONS $(inherited);
> 
>-CLANG_CXX_LANGUAGE_STANDARD = gnu++14;
>+CLANG_CXX_LANGUAGE_STANDARD = gnu++1z;
> CLANG_CXX_LIBRARY = libc++;
> CLANG_ENABLE_OBJC_WEAK = YES;
> DEBUG_INFORMATION_FORMAT = dwarf-with-dsym;
>diff --git a/Tools/MobileMiniBrowser/Configurations/Base.xcconfig b/Tools/MobileMiniBrowser/Configurations/Base.xcconfig
>index f9cac161ea48a7229f30220f0f7970d3adbf5c47..2737bc4f201b4a610df6a84ab38db31956f40faa 100644
>--- a/Tools/MobileMiniBrowser/Configurations/Base.xcconfig
>+++ b/Tools/MobileMiniBrowser/Configurations/Base.xcconfig
>@@ -30,7 +30,7 @@ USE_INTERNAL_SDK_Release = $(HAVE_INTERNAL_SDK);
> 
> ALWAYS_SEARCH_USER_PATHS = NO;
> CLANG_ANALYZER_NONNULL = YES;
>-CLANG_CXX_LANGUAGE_STANDARD = gnu++14;
>+CLANG_CXX_LANGUAGE_STANDARD = gnu++1z;
> CLANG_CXX_LIBRARY = libc++;
> CLANG_ENABLE_MODULES = YES;
> CLANG_ENABLE_OBJC_ARC = YES;
>diff --git a/Tools/TestWebKitAPI/Configurations/Base.xcconfig b/Tools/TestWebKitAPI/Configurations/Base.xcconfig
>index d6a844258936602785afba90262fc98d8b020d38..f59a568d9d99e6b259d762b7c4950351b281bd0f 100644
>--- a/Tools/TestWebKitAPI/Configurations/Base.xcconfig
>+++ b/Tools/TestWebKitAPI/Configurations/Base.xcconfig
>@@ -28,7 +28,7 @@ USE_INTERNAL_SDK_Production = YES;
> USE_INTERNAL_SDK_Debug = $(HAVE_INTERNAL_SDK);
> USE_INTERNAL_SDK_Release = $(HAVE_INTERNAL_SDK);
> 
>-CLANG_CXX_LANGUAGE_STANDARD = gnu++14;
>+CLANG_CXX_LANGUAGE_STANDARD = gnu++1z;
> CLANG_CXX_LIBRARY = libc++;
> CLANG_ENABLE_OBJC_WEAK = YES;
> CLANG_WARN_CXX0X_EXTENSIONS = NO;
>diff --git a/Tools/WebKitTestRunner/Configurations/Base.xcconfig b/Tools/WebKitTestRunner/Configurations/Base.xcconfig
>index 019f129846632e6df538c176a285129f26cc0982..976198b9904d4f92eac6282804d4a03a69136936 100644
>--- a/Tools/WebKitTestRunner/Configurations/Base.xcconfig
>+++ b/Tools/WebKitTestRunner/Configurations/Base.xcconfig
>@@ -28,7 +28,7 @@ USE_INTERNAL_SDK_Production = YES;
> USE_INTERNAL_SDK_Debug = $(HAVE_INTERNAL_SDK);
> USE_INTERNAL_SDK_Release = $(HAVE_INTERNAL_SDK);
> 
>-CLANG_CXX_LANGUAGE_STANDARD = gnu++14;
>+CLANG_CXX_LANGUAGE_STANDARD = gnu++1z;
> CLANG_CXX_LIBRARY = libc++;
> CLANG_ENABLE_OBJC_WEAK = YES;
> CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES;
>diff --git a/PerformanceTests/ChangeLog b/PerformanceTests/ChangeLog
>index 7140a9b1ba2a0a15eaeb93c2c7b244783f9a30ec..b8035c673fcea3a6284c63f981c4c55bae0db303 100644
>--- a/PerformanceTests/ChangeLog
>+++ b/PerformanceTests/ChangeLog
>@@ -1,3 +1,14 @@
>+2018-05-21  Yusuke Suzuki  <utatane.tea@gmail.com>
>+
>+        Use more C++17
>+        https://bugs.webkit.org/show_bug.cgi?id=185176
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * MallocBench/MallocBench.xcodeproj/project.pbxproj:
>+        * MediaTime/Configurations/Base.xcconfig:
>+        * MediaTime/MediaTime.xcodeproj/project.pbxproj:
>+
> 2018-04-30  Myles C. Maxfield  <mmaxfield@apple.com>
> 
>         Improve the performance of FontCascadeDescription's effectiveFamilies
>diff --git a/PerformanceTests/MallocBench/MallocBench.xcodeproj/project.pbxproj b/PerformanceTests/MallocBench/MallocBench.xcodeproj/project.pbxproj
>index e1935245fb730e39d5f36dc7a25426e0cf50d177..cb2df2bd58bcd964c525bec5b3f7757c91ccfb1f 100644
>--- a/PerformanceTests/MallocBench/MallocBench.xcodeproj/project.pbxproj
>+++ b/PerformanceTests/MallocBench/MallocBench.xcodeproj/project.pbxproj
>@@ -369,7 +369,7 @@
> 			isa = XCBuildConfiguration;
> 			buildSettings = {
> 				ALWAYS_SEARCH_USER_PATHS = NO;
>-				CLANG_CXX_LANGUAGE_STANDARD = "c++14";
>+				CLANG_CXX_LANGUAGE_STANDARD = "gnu++1z";
> 				CLANG_CXX_LIBRARY = "libc++";
> 				CLANG_ENABLE_MODULES = YES;
> 				CLANG_WARN_BOOL_CONVERSION = YES;
>@@ -408,7 +408,7 @@
> 			isa = XCBuildConfiguration;
> 			buildSettings = {
> 				ALWAYS_SEARCH_USER_PATHS = NO;
>-				CLANG_CXX_LANGUAGE_STANDARD = "c++14";
>+				CLANG_CXX_LANGUAGE_STANDARD = "gnu++1z";
> 				CLANG_CXX_LIBRARY = "libc++";
> 				CLANG_ENABLE_MODULES = YES;
> 				CLANG_WARN_BOOL_CONVERSION = YES;
>diff --git a/PerformanceTests/MediaTime/Configurations/Base.xcconfig b/PerformanceTests/MediaTime/Configurations/Base.xcconfig
>index 0dbe8bf0184801883475c9dbd838c2568d899272..17449c8a5a90b82a1fb19531f71dcbe11fef2b80 100644
>--- a/PerformanceTests/MediaTime/Configurations/Base.xcconfig
>+++ b/PerformanceTests/MediaTime/Configurations/Base.xcconfig
>@@ -28,7 +28,7 @@ USE_INTERNAL_SDK_Production = YES;
> USE_INTERNAL_SDK_Debug = $(HAVE_INTERNAL_SDK);
> USE_INTERNAL_SDK_Release = $(HAVE_INTERNAL_SDK);
> 
>-CLANG_CXX_LANGUAGE_STANDARD = gnu++14;
>+CLANG_CXX_LANGUAGE_STANDARD = gnu++1z;
> CLANG_CXX_LIBRARY = libc++;
> CLANG_WARN_BOOL_CONVERSION = YES;
> CLANG_WARN_CONSTANT_CONVERSION = YES;
>diff --git a/PerformanceTests/MediaTime/MediaTime.xcodeproj/project.pbxproj b/PerformanceTests/MediaTime/MediaTime.xcodeproj/project.pbxproj
>index fcf08a4959556256347be97e2cb79b83a4654f71..b826e9e2bf7f8e2dcf242064f05651335d998048 100644
>--- a/PerformanceTests/MediaTime/MediaTime.xcodeproj/project.pbxproj
>+++ b/PerformanceTests/MediaTime/MediaTime.xcodeproj/project.pbxproj
>@@ -42,9 +42,9 @@
> 			isa = PBXFrameworksBuildPhase;
> 			buildActionMask = 2147483647;
> 			files = (
>-				CDB099EF1E430B550039E198 /* libicucore.dylib in Frameworks */,
>-				CDB099ED1E430B440039E198 /* Foundation.framework in Frameworks */,
> 				CDB099EB1E430B250039E198 /* CoreFoundation.framework in Frameworks */,
>+				CDB099ED1E430B440039E198 /* Foundation.framework in Frameworks */,
>+				CDB099EF1E430B550039E198 /* libicucore.dylib in Frameworks */,
> 				CDB099E91E4308700039E198 /* libWTF.a in Frameworks */,
> 			);
> 			runOnlyForDeploymentPostprocessing = 0;
>@@ -64,10 +64,10 @@
> 		CDB099D41E4308470039E198 = {
> 			isa = PBXGroup;
> 			children = (
>-				CDB099E01E4308470039E198 /* main.cpp */,
> 				CD836CFD1E43BDB4009F8091 /* Configurations */,
>-				CDB099DE1E4308470039E198 /* Products */,
> 				CDB099E71E43086F0039E198 /* Frameworks */,
>+				CDB099DE1E4308470039E198 /* Products */,
>+				CDB099E01E4308470039E198 /* main.cpp */,
> 			);
> 			sourceTree = "<group>";
> 		};
>@@ -82,9 +82,9 @@
> 		CDB099E71E43086F0039E198 /* Frameworks */ = {
> 			isa = PBXGroup;
> 			children = (
>-				CDB099EE1E430B550039E198 /* libicucore.dylib */,
>-				CDB099EC1E430B440039E198 /* Foundation.framework */,
> 				CDB099EA1E430B250039E198 /* CoreFoundation.framework */,
>+				CDB099EC1E430B440039E198 /* Foundation.framework */,
>+				CDB099EE1E430B550039E198 /* libicucore.dylib */,
> 				CDB099E81E4308700039E198 /* libWTF.a */,
> 			);
> 			name = Frameworks;
>@@ -190,7 +190,7 @@
> 		CDB099E51E4308470039E198 /* Debug */ = {
> 			isa = XCBuildConfiguration;
> 			buildSettings = {
>-				CLANG_CXX_LANGUAGE_STANDARD = "c++14";
>+				CLANG_CXX_LANGUAGE_STANDARD = "gnu++1z";
> 				DEVELOPMENT_TEAM = G5UYP5CS7K;
> 				PRODUCT_NAME = "$(TARGET_NAME)";
> 			};
>@@ -199,7 +199,7 @@
> 		CDB099E61E4308470039E198 /* Release */ = {
> 			isa = XCBuildConfiguration;
> 			buildSettings = {
>-				CLANG_CXX_LANGUAGE_STANDARD = "c++14";
>+				CLANG_CXX_LANGUAGE_STANDARD = "gnu++1z";
> 				DEVELOPMENT_TEAM = G5UYP5CS7K;
> 				PRODUCT_NAME = "$(TARGET_NAME)";
> 			};
>@@ -209,7 +209,7 @@
> 			isa = XCBuildConfiguration;
> 			buildSettings = {
> 				ALWAYS_SEARCH_USER_PATHS = YES;
>-				CLANG_CXX_LANGUAGE_STANDARD = "c++0x";
>+				CLANG_CXX_LANGUAGE_STANDARD = "gnu++1z";
> 				CLANG_CXX_LIBRARY = "libc++";
> 				DEBUG_INFORMATION_FORMAT = "dwarf-with-dsym";
> 				GCC_NO_COMMON_BLOCKS = YES;
>@@ -221,7 +221,7 @@
> 		CDB099F11E4394540039E198 /* Control */ = {
> 			isa = XCBuildConfiguration;
> 			buildSettings = {
>-				CLANG_CXX_LANGUAGE_STANDARD = "c++14";
>+				CLANG_CXX_LANGUAGE_STANDARD = "gnu++1z";
> 				DEVELOPMENT_TEAM = G5UYP5CS7K;
> 				PRODUCT_NAME = "$(TARGET_NAME)";
> 			};

Actions: View | Formatted Diff | Diff

Attachments on bug 185176: 339244 | 339245 | 340503 | 340508 | 340557 | 340611 | 340624 | 340697 | 340858