Attachment 340857 Details for Bug 185822 – Patch

[patch] Patch

bug-185822-20180521190706.patch (text/plain), 1.67 KB, created by Olivier Blin on 2018-05-21 10:07:07 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Olivier Blin

Created: 2018-05-21 10:07:07 PDT

Size: 1.67 KB

patch

obsolete

>Subversion Revision: 232013
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 4434c93435d9ae0fa4a8b8b89f16b1e90724690f..5694add529fcf1e529d4a87784fa1e6984ce7111 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,21 @@
>+2018-05-21  Olivier Blin  <olivier.blin@softathome.com>
>+
>+        Propagate WebCore system include dirs in WebCoreHeaderInterface
>+        https://bugs.webkit.org/show_bug.cgi?id=185822
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        System include directories from WebCore are not propagated anymore to its users.
>+        For example gcrypt, sqlite and ICU system headers defined in PAL are not properly passed to WebKit build.
>+
>+        This may have been caused partly by the fix in r230385:
>+        [CMake] WebKit should link to WebCore as a PRIVATE library if WebCore is a static library
>+        https://bugs.webkit.org/show_bug.cgi?id=184127
>+
>+        No new tests, build fix.
>+
>+        * CMakeLists.txt:
>+
> 2018-05-19  Eric Carlson  <eric.carlson@apple.com>
> 
>         Improve NowPlaying "title"
>diff --git a/Source/WebCore/CMakeLists.txt b/Source/WebCore/CMakeLists.txt
>index 5deaeec97188c68584b1ed0f2cf1dcadb81ef8fa..109e28a0faecaef2a2d7230db6c689c4424f1d4b 100644
>--- a/Source/WebCore/CMakeLists.txt
>+++ b/Source/WebCore/CMakeLists.txt
>@@ -1972,6 +1972,7 @@ endif ()
> # paths of WebCore.
> add_library(WebCoreHeaderInterface INTERFACE)
> target_include_directories(WebCoreHeaderInterface INTERFACE ${WebCore_INCLUDE_DIRECTORIES})
>+target_include_directories(WebCoreHeaderInterface SYSTEM INTERFACE ${WebCore_SYSTEM_INCLUDE_DIRECTORIES})
> target_link_libraries(WebCoreHeaderInterface INTERFACE ${WebCore_LIBRARIES})
> 
> if (MSVC)

Actions: View | Formatted Diff | Diff

Attachments on bug 185822: 340857