Attachment 340850 Details for Bug 183329 – Patch

[patch] Patch

bug-183329-20180521223056.patch (text/plain), 1.54 KB, created by Yusuke Suzuki on 2018-05-21 06:30:57 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Yusuke Suzuki

Created: 2018-05-21 06:30:57 PDT

Size: 1.54 KB

patch

obsolete

>Subversion Revision: 232014
>diff --git a/Source/bmalloc/ChangeLog b/Source/bmalloc/ChangeLog
>index 87820a7b67157c9460693b4062fe94ffa83683ec..d5e141fb17a4c1c4639e2ef093e1450164807ce0 100644
>--- a/Source/bmalloc/ChangeLog
>+++ b/Source/bmalloc/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-05-21  Yusuke Suzuki  <utatane.tea@gmail.com>
>+
>+        Improve how Gigacage reserves address space on Linux
>+        https://bugs.webkit.org/show_bug.cgi?id=183329
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        We specify `GIGACAGE_ALLOCATION_CAN_FAIL 1` in Linux since
>+        Linux can fail to `mmap` if `vm.overcommit_memory = 2`.
>+        Users can enable Gigacage if users enable overcommit_memory.
>+
>+        * bmalloc/Gigacage.h:
>+
> 2018-05-06  Yusuke Suzuki  <utatane.tea@gmail.com>
> 
>         [JSC] Remove "using namespace std;" from JSC, bmalloc, WTF
>diff --git a/Source/bmalloc/bmalloc/Gigacage.h b/Source/bmalloc/bmalloc/Gigacage.h
>index 027e280a1842af633883b44ed6148151b9291415..7839f86d61b07b26aa760b7092095169b16a2505 100644
>--- a/Source/bmalloc/bmalloc/Gigacage.h
>+++ b/Source/bmalloc/bmalloc/Gigacage.h
>@@ -43,6 +43,13 @@
> #define GIGACAGE_ALLOCATION_CAN_FAIL 0
> #endif
> 
>+// In Linux, if `vm.overcommit_memory = 2` is specified, mmap with large size can fail if it exceeds the size of RAM.
>+// So we specify GIGACAGE_ALLOCATION_CAN_FAIL = 1.
>+#if BOS(LINUX)
>+#undef GIGACAGE_ALLOCATION_CAN_FAIL
>+#define GIGACAGE_ALLOCATION_CAN_FAIL 1
>+#endif
>+
> static_assert(bmalloc::isPowerOfTwo(PRIMITIVE_GIGACAGE_SIZE), "");
> static_assert(bmalloc::isPowerOfTwo(JSVALUE_GIGACAGE_SIZE), "");
>

Flags:

mcatanzaro: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 183329: 335768 | 340850