Attachment 340839 Details for Bug 185818 – Patch

[patch] Patch

wk2-im-crash.diff (text/plain), 1.55 KB, created by Carlos Garcia Campos on 2018-05-21 03:08:08 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Carlos Garcia Campos

Created: 2018-05-21 03:08:08 PDT

Size: 1.55 KB

patch

obsolete

>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 6e200d30b00..457d02fec58 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,18 @@
>+2018-05-21  Carlos Garcia Campos  <cgarcia@igalia.com>
>+
>+        [GTK][Wayland] UI process crash when closing the window
>+        https://bugs.webkit.org/show_bug.cgi?id=185818
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        This happens when a page containing a text field is loaded but the focus remains in the url bar when the window
>+        is closed. This is because we are sending a notify-in to the IM context, but the focus is still in the URL
>+        bar. That confuses the wayland input method manager that tries to free the text of the web view IM context that has
>+        already been deleted.
>+
>+        * UIProcess/gtk/InputMethodFilter.cpp:
>+        (WebKit::InputMethodFilter::setEnabled): Only send notify-in if the view is actually focused.
>+
> 2018-05-17  Carlos Garcia Campos  <cgarcia@igalia.com>
> 
>         WebDriver: implement maximize, minimize and fullscreen window commands
>diff --git a/Source/WebKit/UIProcess/gtk/InputMethodFilter.cpp b/Source/WebKit/UIProcess/gtk/InputMethodFilter.cpp
>index 701907363e1..2f03d9dd9e2 100644
>--- a/Source/WebKit/UIProcess/gtk/InputMethodFilter.cpp
>+++ b/Source/WebKit/UIProcess/gtk/InputMethodFilter.cpp
>@@ -89,7 +89,7 @@ void InputMethodFilter::setEnabled(bool enabled)
>     if (!enabled)
>         notifyFocusedOut();
>     m_enabled = enabled;
>-    if (enabled)
>+    if (enabled && m_page->isViewFocused())
>         notifyFocusedIn();
> }
>

Flags:

mcatanzaro: review+
ews-watchlist: commit-queue-

Actions: View | Formatted Diff | Diff

Attachments on bug 185818: 340839 | 340947