Attachment 340830 Details for Bug 185815 – patch

[patch] patch

user-sheet-color-filter.patch (text/plain), 2.20 KB, created by Antti Koivisto on 2018-05-21 00:48:01 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Antti Koivisto

Created: 2018-05-21 00:48:01 PDT

Size: 2.20 KB

patch

obsolete

>Index: Source/WebKitLegacy/mac/ChangeLog
>===================================================================
>--- Source/WebKitLegacy/mac/ChangeLog	(revision 232010)
>+++ Source/WebKitLegacy/mac/ChangeLog	(working copy)
>@@ -1,3 +1,16 @@
>+2018-05-21  Antti Koivisto  <antti@apple.com>
>+
>+        WebView._preferencesChanged should apply colorFilterEnabled preference before parsing user stylesheet
>+        https://bugs.webkit.org/show_bug.cgi?id=185815
>+        <rdar://problem/40310069>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        User stylesheet parsing may depend on the colorFilterEnabled preference.
>+
>+        * WebView/WebView.mm:
>+        (-[WebView _preferencesChanged:]):
>+
> 2018-05-18  Commit Queue  <commit-queue@webkit.org>
> 
>         Unreviewed, rolling out r231982.
>Index: Source/WebKitLegacy/mac/WebView/WebView.mm
>===================================================================
>--- Source/WebKitLegacy/mac/WebView/WebView.mm	(revision 231847)
>+++ Source/WebKitLegacy/mac/WebView/WebView.mm	(working copy)
>@@ -2952,6 +2952,7 @@ - (void)_preferencesChanged:(WebPreferen
> 
>     settings.setPlugInSnapshottingEnabled([preferences plugInSnapshottingEnabled]);
>     settings.setHttpEquivEnabled([preferences httpEquivEnabled]);
>+    settings.setColorFilterEnabled([preferences colorFilterEnabled]);
> 
> #if PLATFORM(MAC)
>     settings.setAcceleratedCompositingForFixedPositionEnabled(true);
>@@ -2992,6 +2993,7 @@ - (void)_preferencesChanged:(WebPreferen
> #endif // PLATFORM(IOS)
> 
> #if PLATFORM(MAC)
>+    // This parses the user stylesheet synchronously so anything that may affect it should be done first.
>     if ([preferences userStyleSheetEnabled]) {
>         NSString* location = [[preferences userStyleSheetLocation] _web_originalDataAsString];
>         if ([location isEqualToString:@"apple-dashboard://stylesheet"])
>@@ -3061,7 +3063,6 @@ - (void)_preferencesChanged:(WebPreferen
> 
>     settings.setViewportFitEnabled([preferences viewportFitEnabled]);
>     settings.setConstantPropertiesEnabled([preferences constantPropertiesEnabled]);
>-    settings.setColorFilterEnabled([preferences colorFilterEnabled]);
>     settings.setCrossOriginOptionsSupportEnabled([preferences crossOriginOptionsSupportEnabled]);
> 
> #if ENABLE(GAMEPAD)

Actions: View | Formatted Diff | Diff

Attachments on bug 185815: 340830