Attachment 340806 Details for Bug 185808 – the patch

[patch] the patch

blah.patch (text/plain), 2.00 KB, created by Filip Pizlo on 2018-05-20 14:35:29 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Filip Pizlo

Created: 2018-05-20 14:35:29 PDT

Size: 2.00 KB

patch

obsolete

>Index: Source/JavaScriptCore/ChangeLog
>===================================================================
>--- Source/JavaScriptCore/ChangeLog	(revision 232000)
>+++ Source/JavaScriptCore/ChangeLog	(working copy)
>@@ -1,3 +1,19 @@
>+2018-05-20  Filip Pizlo  <fpizlo@apple.com>
>+
>+        Revert the B3 compiler pipeline's treatment of taildup
>+        https://bugs.webkit.org/show_bug.cgi?id=185808
>+
>+        Reviewed by NOBODY (OOPS!).
>+        
>+        While trying to implement path specialization (bug 185060), I reorganized the B3 pass pipeline.
>+        But then path specialization turned out to be a negative result. This reverts the pipeline to the
>+        way it was before that work.
>+        
>+        1.5% progression on V8Spider-CompileTime.
>+
>+        * b3/B3Generate.cpp:
>+        (JSC::B3::generateToAir):
>+
> 2018-05-18  Filip Pizlo  <fpizlo@apple.com>
> 
>         DFG should inline InstanceOf ICs
>Index: Source/JavaScriptCore/b3/B3Generate.cpp
>===================================================================
>--- Source/JavaScriptCore/b3/B3Generate.cpp	(revision 232000)
>+++ Source/JavaScriptCore/b3/B3Generate.cpp	(working copy)
>@@ -88,6 +88,10 @@ void generateToAir(Procedure& procedure)
>         if (eliminateCommonSubexpressions(procedure))
>             eliminateCommonSubexpressions(procedure);
>         inferSwitches(procedure);
>+        if (Options::useB3TailDup())
>+            duplicateTails(procedure);
>+        fixSSA(procedure);
>+        foldPathConstants(procedure);
>         
>         // FIXME: Add more optimizations here.
>         // https://bugs.webkit.org/show_bug.cgi?id=150507
>@@ -101,11 +105,6 @@ void generateToAir(Procedure& procedure)
> 
>     if (procedure.optLevel() >= 2) {
>         reduceStrength(procedure);
>-        if (Options::useB3TailDup())
>-            duplicateTails(procedure);
>-        fixSSA(procedure);
>-        foldPathConstants(procedure);
>-        reduceStrength(procedure);
> 
>         // FIXME: Add more optimizations here.
>         // https://bugs.webkit.org/show_bug.cgi?id=150507

Flags:

ysuzuki: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 185808: 340806