Attachment 340785 Details for Bug 185802 – Patch

[patch] Patch

bug-185802-20180520042155.patch (text/plain), 2.37 KB, created by Yusuke Suzuki on 2018-05-19 12:21:56 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Yusuke Suzuki

Created: 2018-05-19 12:21:56 PDT

Size: 2.37 KB

patch

obsolete

>Subversion Revision: 231997
>diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog
>index 88cdd95b5162a2c12027f68bfed82e5557792be1..005dfde2b7be88727f635b0644ea2ff0814d3c36 100644
>--- a/Source/JavaScriptCore/ChangeLog
>+++ b/Source/JavaScriptCore/ChangeLog
>@@ -1,3 +1,13 @@
>+2018-05-19  Yusuke Suzuki  <utatane.tea@gmail.com>
>+
>+        [DFG] CheckTypeInfoFlags should say `eliminated` if it is removed in constant folding phase
>+        https://bugs.webkit.org/show_bug.cgi?id=185802
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * dfg/DFGConstantFoldingPhase.cpp:
>+        (JSC::DFG::ConstantFoldingPhase::foldConstants):
>+
> 2018-05-18  Commit Queue  <commit-queue@webkit.org>
> 
>         Unreviewed, rolling out r231982.
>diff --git a/Source/JavaScriptCore/dfg/DFGConstantFoldingPhase.cpp b/Source/JavaScriptCore/dfg/DFGConstantFoldingPhase.cpp
>index 7374185667e0bdb787a83b702cb18959b5069d01..c1ec5ac20a21a266b4b2a8c7d10a75321d08168a 100644
>--- a/Source/JavaScriptCore/dfg/DFGConstantFoldingPhase.cpp
>+++ b/Source/JavaScriptCore/dfg/DFGConstantFoldingPhase.cpp
>@@ -813,7 +813,7 @@ class ConstantFoldingPhase : public Phase {
>                 ASSERT(bits);
>                 if (bits == ImplementsDefaultHasInstance) {
>                     if (abstractValue.m_type == SpecFunctionWithDefaultHasInstance) {
>-                        changed = true;
>+                        eliminated = true;
>                         node->remove(m_graph);
>                         break;
>                     }
>@@ -825,7 +825,7 @@ class ConstantFoldingPhase : public Phase {
>                         // and we can read its inline type info flags. These flags don't change over the
>                         // object's lifetime.
>                         if ((value.asCell()->inlineTypeFlags() & bits) == bits) {
>-                            changed = true;
>+                            eliminated = true;
>                             node->remove(m_graph);
>                             break;
>                         }
>@@ -838,7 +838,7 @@ class ConstantFoldingPhase : public Phase {
>                         ok &= (structure->typeInfo().inlineTypeFlags() & bits) == bits;
>                     });
>                     if (ok) {
>-                        changed = true;
>+                        eliminated = true;
>                         node->remove(m_graph);
>                         break;
>                     }

Actions: View | Formatted Diff | Diff

Attachments on bug 185802: 340785