WebKit Bugzilla
Attachment 340768 Details for
Bug 185796
: [INTL] Call Typed Array elements toLocaleString with locale and options
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-185796-20180518203851.patch (text/plain), 3.64 KB, created by
Andy VanWagoner
on 2018-05-18 19:38:53 PDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Andy VanWagoner
Created:
2018-05-18 19:38:53 PDT
Size:
3.64 KB
patch
obsolete
>Subversion Revision: 231993 >diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog >index 88cdd95b5162a2c12027f68bfed82e5557792be1..5d3721a30d3141a209b2f79f69eb75431fe8b164 100644 >--- a/Source/JavaScriptCore/ChangeLog >+++ b/Source/JavaScriptCore/ChangeLog >@@ -1,3 +1,16 @@ >+2018-05-18 Andy VanWagoner <andy@vanwagoner.family> >+ >+ [INTL] Call Typed Array elements toLocaleString with locale and options >+ https://bugs.webkit.org/show_bug.cgi?id=185796 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ Improve ECMA 402 compliance of typed array toLocaleString, passing along >+ the locale and options to element toLocaleString calls. >+ >+ * builtins/TypedArrayPrototype.js: >+ (toLocaleString): >+ > 2018-05-18 Commit Queue <commit-queue@webkit.org> > > Unreviewed, rolling out r231982. >diff --git a/Source/JavaScriptCore/builtins/TypedArrayPrototype.js b/Source/JavaScriptCore/builtins/TypedArrayPrototype.js >index 66dd6451591e23c28f56fb6b000337f75e290725..989aa606414e647e34cf46d24fffabb480423ead 100644 >--- a/Source/JavaScriptCore/builtins/TypedArrayPrototype.js >+++ b/Source/JavaScriptCore/builtins/TypedArrayPrototype.js >@@ -396,7 +396,7 @@ function filter(callback /*, thisArg */) > return result; > } > >-function toLocaleString() >+function toLocaleString(/* locale, options */) > { > "use strict"; > >@@ -405,9 +405,9 @@ function toLocaleString() > if (length == 0) > return ""; > >- var string = this[0].toLocaleString(); >+ var string = this[0].toLocaleString(@argument(0), @argument(1)); > for (var i = 1; i < length; i++) >- string += "," + this[i].toLocaleString(); >+ string += "," + this[i].toLocaleString(@argument(0), @argument(1)); > > return string; > } >diff --git a/JSTests/ChangeLog b/JSTests/ChangeLog >index b6ad0467d35298f789aae755fbad821b258773b6..2b0ca76178291188a0d065c9f4f9afe133e32d77 100644 >--- a/JSTests/ChangeLog >+++ b/JSTests/ChangeLog >@@ -1,3 +1,14 @@ >+2018-05-18 Andy VanWagoner <andy@vanwagoner.family> >+ >+ [INTL] Call Typed Array elements toLocaleString with locale and options >+ https://bugs.webkit.org/show_bug.cgi?id=185796 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ Remove now passing TypedArray toLocaleString expectation. >+ >+ * test262/expectations.yaml: >+ > 2018-05-18 Keith Miller <keith_miller@apple.com> > > op_in should mark if it sees out of bounds accesses >diff --git a/JSTests/test262/expectations.yaml b/JSTests/test262/expectations.yaml >index ee0b3801600a254346402a1620e8878091611272..6a469f84206a463fd4d02f7804e036887bcc306d 100644 >--- a/JSTests/test262/expectations.yaml >+++ b/JSTests/test262/expectations.yaml >@@ -1997,9 +1997,6 @@ test/intl402/PluralRules/default-options-object-prototype.js: > test/intl402/PluralRules/length.js: > default: 'Test262Error: Expected obj[length] to have configurable:true.' > strict mode: 'Test262Error: Expected obj[length] to have configurable:true.' >-test/intl402/TypedArray/prototype/toLocaleString/calls-toLocaleString-number-elements.js: >- default: 'Test262Error: Expected SameValue(ë0û, Ã«à ¹Â.à ¹Âà ¹Âà ¹Âû) to be true (Testing with Float64Array.)' >- strict mode: 'Test262Error: Expected SameValue(ë0û, Ã«à ¹Â.à ¹Âà ¹Âà ¹Âû) to be true (Testing with Float64Array.)' > test/intl402/fallback-locales-are-supported.js: > default: "Test262Error: Locale zh-Hans-CN is supported, but fallback zh-CN isn't. Expected SameValue(ë-1û, ë-1û) to be false (Testing with NumberFormat.)" > strict mode: "Test262Error: Locale zh-Hans-CN is supported, but fallback zh-CN isn't. Expected SameValue(ë-1û, ë-1û) to be false (Testing with NumberFormat.)"
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 185796
:
340768
|
343721
|
345765