WebKit Bugzilla
Attachment 340761 Details for
Bug 185793
: REGRESSION(r231982): Caused layout test failures (Requested by realdawei on #webkit).
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
ROLLOUT of r231982
bug-185793-20180518200641.patch (text/plain), 11.69 KB, created by
WebKit Commit Bot
on 2018-05-18 17:06:41 PDT
(
hide
)
Description:
ROLLOUT of r231982
Filename:
MIME Type:
Creator:
WebKit Commit Bot
Created:
2018-05-18 17:06:41 PDT
Size:
11.69 KB
patch
obsolete
>Subversion Revision: 231992 >diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog >index c1c8c85bb5269ca6a2d2eac0093c113a7c092146..88cdd95b5162a2c12027f68bfed82e5557792be1 100644 >--- a/Source/JavaScriptCore/ChangeLog >+++ b/Source/JavaScriptCore/ChangeLog >@@ -1,3 +1,17 @@ >+2018-05-18 Commit Queue <commit-queue@webkit.org> >+ >+ Unreviewed, rolling out r231982. >+ https://bugs.webkit.org/show_bug.cgi?id=185793 >+ >+ Caused layout test failures (Requested by realdawei on >+ #webkit). >+ >+ Reverted changeset: >+ >+ "Complete fix for enabling modern EME by default" >+ https://bugs.webkit.org/show_bug.cgi?id=185770 >+ https://trac.webkit.org/changeset/231982 >+ > 2018-05-18 Keith Miller <keith_miller@apple.com> > > op_in should mark if it sees out of bounds accesses >diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog >index ef77cb83859a3bc9b332867e0a88dea75276f71a..65ee6ad9f594df6adf1463d8182b12784c47768b 100644 >--- a/Source/WebCore/ChangeLog >+++ b/Source/WebCore/ChangeLog >@@ -1,3 +1,17 @@ >+2018-05-18 Commit Queue <commit-queue@webkit.org> >+ >+ Unreviewed, rolling out r231982. >+ https://bugs.webkit.org/show_bug.cgi?id=185793 >+ >+ Caused layout test failures (Requested by realdawei on >+ #webkit). >+ >+ Reverted changeset: >+ >+ "Complete fix for enabling modern EME by default" >+ https://bugs.webkit.org/show_bug.cgi?id=185770 >+ https://trac.webkit.org/changeset/231982 >+ > 2018-05-18 Jer Noble <jer.noble@apple.com> > > Complete fix for enabling modern EME by default >diff --git a/Source/WebCore/PAL/ChangeLog b/Source/WebCore/PAL/ChangeLog >index 32732be1f608aa3c9e3ae4f0c8fa2d850c8ec412..423c5b01152566dd6570099aba3196db150284df 100644 >--- a/Source/WebCore/PAL/ChangeLog >+++ b/Source/WebCore/PAL/ChangeLog >@@ -1,3 +1,17 @@ >+2018-05-18 Commit Queue <commit-queue@webkit.org> >+ >+ Unreviewed, rolling out r231982. >+ https://bugs.webkit.org/show_bug.cgi?id=185793 >+ >+ Caused layout test failures (Requested by realdawei on >+ #webkit). >+ >+ Reverted changeset: >+ >+ "Complete fix for enabling modern EME by default" >+ https://bugs.webkit.org/show_bug.cgi?id=185770 >+ https://trac.webkit.org/changeset/231982 >+ > 2018-05-18 Jer Noble <jer.noble@apple.com> > > Complete fix for enabling modern EME by default >diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog >index 3abbd15888ee227cd2c267ff839bc3e1edee6bea..6dabecafe0a28a2a5bc2f0ecf687f19a7f0226a1 100644 >--- a/Source/WebKit/ChangeLog >+++ b/Source/WebKit/ChangeLog >@@ -1,3 +1,17 @@ >+2018-05-18 Commit Queue <commit-queue@webkit.org> >+ >+ Unreviewed, rolling out r231982. >+ https://bugs.webkit.org/show_bug.cgi?id=185793 >+ >+ Caused layout test failures (Requested by realdawei on >+ #webkit). >+ >+ Reverted changeset: >+ >+ "Complete fix for enabling modern EME by default" >+ https://bugs.webkit.org/show_bug.cgi?id=185770 >+ https://trac.webkit.org/changeset/231982 >+ > 2018-05-18 Brian Burg <bburg@apple.com> > > [Cocoa] Add missing nullability annotations to _WKAutomationSessionDelegate >diff --git a/Source/WebKitLegacy/mac/ChangeLog b/Source/WebKitLegacy/mac/ChangeLog >index fb28ebd0f59ef9449d7bad1e7b163780462b7f1b..b18cf3634e25d7519767f6c44a87bd4a21a0e245 100644 >--- a/Source/WebKitLegacy/mac/ChangeLog >+++ b/Source/WebKitLegacy/mac/ChangeLog >@@ -1,3 +1,17 @@ >+2018-05-18 Commit Queue <commit-queue@webkit.org> >+ >+ Unreviewed, rolling out r231982. >+ https://bugs.webkit.org/show_bug.cgi?id=185793 >+ >+ Caused layout test failures (Requested by realdawei on >+ #webkit). >+ >+ Reverted changeset: >+ >+ "Complete fix for enabling modern EME by default" >+ https://bugs.webkit.org/show_bug.cgi?id=185770 >+ https://trac.webkit.org/changeset/231982 >+ > 2018-05-18 Jer Noble <jer.noble@apple.com> > > Complete fix for enabling modern EME by default >diff --git a/Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig b/Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig >index 776ec7cd551c51dcfaff0c5216a9ca5759da3d07..32f3e4ea0e11f3e483e4bb636e35715eddbec1cb 100644 >--- a/Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig >+++ b/Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig >@@ -122,8 +122,7 @@ ENABLE_ENCRYPTED_MEDIA_watchos = ENABLE_ENCRYPTED_MEDIA; > ENABLE_ENCRYPTED_MEDIA_watchsimulator = ENABLE_ENCRYPTED_MEDIA; > ENABLE_ENCRYPTED_MEDIA_appletvos = ENABLE_ENCRYPTED_MEDIA; > ENABLE_ENCRYPTED_MEDIA_appletvsimulator = ENABLE_ENCRYPTED_MEDIA; >-ENABLE_ENCRYPTED_MEDIA_macosx = $(ENABLE_ENCRYPTED_MEDIA$(WK_MACOS_1014)); >-ENABLE_ENCRYPTED_MEDIA_MACOS_SINCE_1014 = ENABLE_ENCRYPTED_MEDIA; >+ENABLE_ENCRYPTED_MEDIA_macosx = ENABLE_ENCRYPTED_MEDIA; > > ENABLE_EXTRA_ZOOM_MODE = ; > >diff --git a/Source/WebCore/Configurations/FeatureDefines.xcconfig b/Source/WebCore/Configurations/FeatureDefines.xcconfig >index 776ec7cd551c51dcfaff0c5216a9ca5759da3d07..32f3e4ea0e11f3e483e4bb636e35715eddbec1cb 100644 >--- a/Source/WebCore/Configurations/FeatureDefines.xcconfig >+++ b/Source/WebCore/Configurations/FeatureDefines.xcconfig >@@ -122,8 +122,7 @@ ENABLE_ENCRYPTED_MEDIA_watchos = ENABLE_ENCRYPTED_MEDIA; > ENABLE_ENCRYPTED_MEDIA_watchsimulator = ENABLE_ENCRYPTED_MEDIA; > ENABLE_ENCRYPTED_MEDIA_appletvos = ENABLE_ENCRYPTED_MEDIA; > ENABLE_ENCRYPTED_MEDIA_appletvsimulator = ENABLE_ENCRYPTED_MEDIA; >-ENABLE_ENCRYPTED_MEDIA_macosx = $(ENABLE_ENCRYPTED_MEDIA$(WK_MACOS_1014)); >-ENABLE_ENCRYPTED_MEDIA_MACOS_SINCE_1014 = ENABLE_ENCRYPTED_MEDIA; >+ENABLE_ENCRYPTED_MEDIA_macosx = ENABLE_ENCRYPTED_MEDIA; > > ENABLE_EXTRA_ZOOM_MODE = ; > >diff --git a/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig b/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig >index 776ec7cd551c51dcfaff0c5216a9ca5759da3d07..32f3e4ea0e11f3e483e4bb636e35715eddbec1cb 100644 >--- a/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig >+++ b/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig >@@ -122,8 +122,7 @@ ENABLE_ENCRYPTED_MEDIA_watchos = ENABLE_ENCRYPTED_MEDIA; > ENABLE_ENCRYPTED_MEDIA_watchsimulator = ENABLE_ENCRYPTED_MEDIA; > ENABLE_ENCRYPTED_MEDIA_appletvos = ENABLE_ENCRYPTED_MEDIA; > ENABLE_ENCRYPTED_MEDIA_appletvsimulator = ENABLE_ENCRYPTED_MEDIA; >-ENABLE_ENCRYPTED_MEDIA_macosx = $(ENABLE_ENCRYPTED_MEDIA$(WK_MACOS_1014)); >-ENABLE_ENCRYPTED_MEDIA_MACOS_SINCE_1014 = ENABLE_ENCRYPTED_MEDIA; >+ENABLE_ENCRYPTED_MEDIA_macosx = ENABLE_ENCRYPTED_MEDIA; > > ENABLE_EXTRA_ZOOM_MODE = ; > >diff --git a/Source/WebKit/Configurations/FeatureDefines.xcconfig b/Source/WebKit/Configurations/FeatureDefines.xcconfig >index 776ec7cd551c51dcfaff0c5216a9ca5759da3d07..32f3e4ea0e11f3e483e4bb636e35715eddbec1cb 100644 >--- a/Source/WebKit/Configurations/FeatureDefines.xcconfig >+++ b/Source/WebKit/Configurations/FeatureDefines.xcconfig >@@ -122,8 +122,7 @@ ENABLE_ENCRYPTED_MEDIA_watchos = ENABLE_ENCRYPTED_MEDIA; > ENABLE_ENCRYPTED_MEDIA_watchsimulator = ENABLE_ENCRYPTED_MEDIA; > ENABLE_ENCRYPTED_MEDIA_appletvos = ENABLE_ENCRYPTED_MEDIA; > ENABLE_ENCRYPTED_MEDIA_appletvsimulator = ENABLE_ENCRYPTED_MEDIA; >-ENABLE_ENCRYPTED_MEDIA_macosx = $(ENABLE_ENCRYPTED_MEDIA$(WK_MACOS_1014)); >-ENABLE_ENCRYPTED_MEDIA_MACOS_SINCE_1014 = ENABLE_ENCRYPTED_MEDIA; >+ENABLE_ENCRYPTED_MEDIA_macosx = ENABLE_ENCRYPTED_MEDIA; > > ENABLE_EXTRA_ZOOM_MODE = ; > >diff --git a/Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig b/Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig >index 776ec7cd551c51dcfaff0c5216a9ca5759da3d07..32f3e4ea0e11f3e483e4bb636e35715eddbec1cb 100644 >--- a/Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig >+++ b/Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig >@@ -122,8 +122,7 @@ ENABLE_ENCRYPTED_MEDIA_watchos = ENABLE_ENCRYPTED_MEDIA; > ENABLE_ENCRYPTED_MEDIA_watchsimulator = ENABLE_ENCRYPTED_MEDIA; > ENABLE_ENCRYPTED_MEDIA_appletvos = ENABLE_ENCRYPTED_MEDIA; > ENABLE_ENCRYPTED_MEDIA_appletvsimulator = ENABLE_ENCRYPTED_MEDIA; >-ENABLE_ENCRYPTED_MEDIA_macosx = $(ENABLE_ENCRYPTED_MEDIA$(WK_MACOS_1014)); >-ENABLE_ENCRYPTED_MEDIA_MACOS_SINCE_1014 = ENABLE_ENCRYPTED_MEDIA; >+ENABLE_ENCRYPTED_MEDIA_macosx = ENABLE_ENCRYPTED_MEDIA; > > ENABLE_EXTRA_ZOOM_MODE = ; > >diff --git a/Tools/ChangeLog b/Tools/ChangeLog >index e9ec5c5af8c4debcd77cbb950a8d73c6c488854c..0e97dc6d45032ab07216a279a3dee6209e1ce309 100644 >--- a/Tools/ChangeLog >+++ b/Tools/ChangeLog >@@ -1,3 +1,17 @@ >+2018-05-18 Commit Queue <commit-queue@webkit.org> >+ >+ Unreviewed, rolling out r231982. >+ https://bugs.webkit.org/show_bug.cgi?id=185793 >+ >+ Caused layout test failures (Requested by realdawei on >+ #webkit). >+ >+ Reverted changeset: >+ >+ "Complete fix for enabling modern EME by default" >+ https://bugs.webkit.org/show_bug.cgi?id=185770 >+ https://trac.webkit.org/changeset/231982 >+ > 2018-05-18 Eric Carlson <eric.carlson@apple.com> > > Handle failure to extend sandbox gracefully >diff --git a/Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig b/Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig >index 776ec7cd551c51dcfaff0c5216a9ca5759da3d07..32f3e4ea0e11f3e483e4bb636e35715eddbec1cb 100644 >--- a/Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig >+++ b/Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig >@@ -122,8 +122,7 @@ ENABLE_ENCRYPTED_MEDIA_watchos = ENABLE_ENCRYPTED_MEDIA; > ENABLE_ENCRYPTED_MEDIA_watchsimulator = ENABLE_ENCRYPTED_MEDIA; > ENABLE_ENCRYPTED_MEDIA_appletvos = ENABLE_ENCRYPTED_MEDIA; > ENABLE_ENCRYPTED_MEDIA_appletvsimulator = ENABLE_ENCRYPTED_MEDIA; >-ENABLE_ENCRYPTED_MEDIA_macosx = $(ENABLE_ENCRYPTED_MEDIA$(WK_MACOS_1014)); >-ENABLE_ENCRYPTED_MEDIA_MACOS_SINCE_1014 = ENABLE_ENCRYPTED_MEDIA; >+ENABLE_ENCRYPTED_MEDIA_macosx = ENABLE_ENCRYPTED_MEDIA; > > ENABLE_EXTRA_ZOOM_MODE = ; > >diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog >index d872f0675d36a689129dc0937053e678a0edaab9..a261cb3715e8ef9e3ac9e7787282de6b1e04fba3 100644 >--- a/LayoutTests/ChangeLog >+++ b/LayoutTests/ChangeLog >@@ -1,3 +1,17 @@ >+2018-05-18 Commit Queue <commit-queue@webkit.org> >+ >+ Unreviewed, rolling out r231982. >+ https://bugs.webkit.org/show_bug.cgi?id=185793 >+ >+ Caused layout test failures (Requested by realdawei on >+ #webkit). >+ >+ Reverted changeset: >+ >+ "Complete fix for enabling modern EME by default" >+ https://bugs.webkit.org/show_bug.cgi?id=185770 >+ https://trac.webkit.org/changeset/231982 >+ > 2018-05-18 Youenn Fablet <youenn@apple.com> > > NetworkLoadChecker should cancel its content extension retrieval task when being destroyed >diff --git a/LayoutTests/platform/mac-wk1/fast/dom/navigator-detached-no-crash-expected.txt b/LayoutTests/platform/mac-wk1/fast/dom/navigator-detached-no-crash-expected.txt >index 9f7621e879e10e0a04c55c09102c0a5c79cdee30..567339c99a232fb0dd2d73e61b11280abd3f27b9 100644 >--- a/LayoutTests/platform/mac-wk1/fast/dom/navigator-detached-no-crash-expected.txt >+++ b/LayoutTests/platform/mac-wk1/fast/dom/navigator-detached-no-crash-expected.txt >@@ -1,3 +1,4 @@ >+CONSOLE MESSAGE: Unhandled Promise Rejection: TypeError: Not enough arguments > This tests that the navigator object of a deleted frame is disconnected properly. Accessing fields or methods shouldn't crash the browser. > Check Navigator > navigator.appCodeName is OK >@@ -16,6 +17,7 @@ navigator.platform is OK > navigator.plugins is OK > navigator.product is OK > navigator.productSub is OK >+navigator.requestMediaKeySystemAccess() is OK > navigator.userAgent is OK > navigator.vendor is OK > navigator.vendorSub is OK >@@ -36,6 +38,7 @@ navigator.platform is OK > navigator.plugins is OK > navigator.product is OK > navigator.productSub is OK >+navigator.requestMediaKeySystemAccess() is OK > navigator.userAgent is OK > navigator.vendor is OK > navigator.vendorSub is OK
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 185793
: 340761