Attachment 340743 Details for Bug 185779 – Fix test results

[patch] Fix test results

bug-185779-20180518151202.patch (text/plain), 1.50 KB, created by Eric Carlson on 2018-05-18 15:12:03 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Eric Carlson

Created: 2018-05-18 15:12:03 PDT

Size: 1.50 KB

patch

obsolete

>Subversion Revision: 231983
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index e64ddb8007356cfe3c31ca7bf88af7235df823e0..e9ec5c5af8c4debcd77cbb950a8d73c6c488854c 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,14 @@
>+2018-05-18  Eric Carlson  <eric.carlson@apple.com>
>+
>+        Handle failure to extend sandbox gracefully
>+        https://bugs.webkit.org/show_bug.cgi?id=185779
>+        <rdar://problem/40316349>
>+
>+        Unreviewed, fix test results.
>+
>+        * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm:
>+        (TEST_F):
>+
> 2018-05-18  Jer Noble  <jer.noble@apple.com>
> 
>         Complete fix for enabling modern EME by default
>diff --git a/Tools/TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm b/Tools/TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm
>index 07d5779c7dcca29f5f5784a62da6d2a857d69e7b..c73c98994e417334902552a878def5d17225bdf4 100644
>--- a/Tools/TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm
>+++ b/Tools/TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm
>@@ -136,7 +136,7 @@ TEST_F(MediaCaptureSimulateFailedSandbox, Test)
>     loadTestAndWaitForMessage("denied");
>     EXPECT_TRUE(wasPrompted);
>     auto* error = [m_webView stringByEvaluatingJavaScript:@"lastError()"];
>-    EXPECT_STREQ([error UTF8String], "AbortError,Unable to extend sandbox");
>+    EXPECT_STREQ([error UTF8String], "AbortError,Unable to extend sandbox.");
> 
>     loadTestAndWaitForMessage("allowed");
>     EXPECT_TRUE(wasPrompted);

Actions: View | Formatted Diff | Diff

Attachments on bug 185779: 340729 | 340743