Attachment 340727 Details for Bug 185140 – Patch

[patch] Patch

bug-185140-20180518122639.patch (text/plain), 2.00 KB, created by Per Arne Vollan on 2018-05-18 12:26:40 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Per Arne Vollan

Created: 2018-05-18 12:26:40 PDT

Size: 2.00 KB

patch

obsolete

>Index: Source/WebKit/ChangeLog
>===================================================================
>--- Source/WebKit/ChangeLog	(revision 231977)
>+++ Source/WebKit/ChangeLog	(working copy)
>@@ -1,3 +1,17 @@
>+2018-05-18  Per Arne Vollan  <pvollan@apple.com>
>+
>+        WebProcess fails to launch
>+        https://bugs.webkit.org/show_bug.cgi?id=185140
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        If the NSApplication runloop is not used in the WebContent process, launchServicesCheckIn() needs to be called
>+        in order for enableSandboxStyleFileQuarantine() to succeed. Determine at runtime if launchServicesCheckIn()
>+        should be called by checking if the NSApplication event loop is running.
>+
>+        * WebProcess/cocoa/WebProcessCocoa.mm:
>+        (WebKit::WebProcess::platformInitializeProcess):
>+
> 2018-05-18  Antoine Quint  <graouts@apple.com>
> 
>         [Web Animations] Turn Web Animations with CSS integration on for test runners
>Index: Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm
>===================================================================
>--- Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm	(revision 231909)
>+++ Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm	(working copy)
>@@ -306,11 +306,11 @@ void WebProcess::platformInitializeProce
>     // Make sure that we close any WindowServer connections after checking in with Launch Services.
>     CGSShutdownServerConnections();
> #else
>-#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400
>-    // This call is needed when the WebProcess is not running the NSApplication event loop.
>-    // Otherwise, calling enableSandboxStyleFileQuarantine() will fail.
>-    launchServicesCheckIn();
>-#endif // __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400
>+    if (![NSApp isRunning]) {
>+        // This call is needed when the WebProcess is not running the NSApplication event loop.
>+        // Otherwise, calling enableSandboxStyleFileQuarantine() will fail.
>+        launchServicesCheckIn();
>+    }
> #endif // ENABLE(WEBPROCESS_WINDOWSERVER_BLOCKING)
> #endif // PLATFORM(MAC)
>

Actions: View | Formatted Diff | Diff

Attachments on bug 185140: 339133 | 339204 | 339213 | 340727