Attachment 340725 Details for Bug 185770 – Patch for landing

[patch] Patch for landing

bug-185770-20180518120818.patch (text/plain), 10.85 KB, created by Jer Noble on 2018-05-18 12:08:19 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Jer Noble

Created: 2018-05-18 12:08:19 PDT

Size: 10.85 KB

patch

obsolete

>Subversion Revision: 231956
>diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog
>index e26319ea6ae19a809084d25afc1e1bf757377ed5..7464cff743a2e552caec442b427283200deb8541 100644
>--- a/Source/JavaScriptCore/ChangeLog
>+++ b/Source/JavaScriptCore/ChangeLog
>@@ -1,3 +1,13 @@
>+2018-05-18  Jer Noble  <jer.noble@apple.com>
>+
>+        Complete fix for enabling modern EME by default
>+        https://bugs.webkit.org/show_bug.cgi?id=185770
>+        <rdar://problem/40368220>
>+
>+        Reviewed by Eric Carlson.
>+
>+        * Configurations/FeatureDefines.xcconfig:
>+
> 2018-05-17  Michael Saboff  <msaboff@apple.com>
> 
>         We don't throw SyntaxErrors for runtime generated regular expressions with errors
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 7d2bfb1006f9d792963781d7dfe4d8bc179ca820..a9f08096a761db79bde5b40d27690765b949f874 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,13 @@
>+2018-05-18  Jer Noble  <jer.noble@apple.com>
>+
>+        Complete fix for enabling modern EME by default
>+        https://bugs.webkit.org/show_bug.cgi?id=185770
>+        <rdar://problem/40368220>
>+
>+        Reviewed by Eric Carlson.
>+
>+        * Configurations/FeatureDefines.xcconfig:
>+
> 2018-04-05  Jer Noble  <jer.noble@apple.com>
> 
>         ASSERTION FAILED: m_scriptExecutionContext under WebCore::AudioContext::isPlayingAudioDidChange()
>diff --git a/Source/WebCore/PAL/ChangeLog b/Source/WebCore/PAL/ChangeLog
>index 0b97a9b9e84962e6d9b2e8126bdca13efe8858d2..32732be1f608aa3c9e3ae4f0c8fa2d850c8ec412 100644
>--- a/Source/WebCore/PAL/ChangeLog
>+++ b/Source/WebCore/PAL/ChangeLog
>@@ -1,3 +1,13 @@
>+2018-05-18  Jer Noble  <jer.noble@apple.com>
>+
>+        Complete fix for enabling modern EME by default
>+        https://bugs.webkit.org/show_bug.cgi?id=185770
>+        <rdar://problem/40368220>
>+
>+        Reviewed by Eric Carlson.
>+
>+        * Configurations/FeatureDefines.xcconfig:
>+
> 2018-05-16  Andy VanWagoner  <andy@vanwagoner.family>
> 
>         Add support for Intl NumberFormat formatToParts
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index d63a4ed2607314bc22fa1d5f572a809d71b2b73d..a62555b32e034100722d3aab54f73c4b72c7b6cf 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,13 @@
>+2018-05-18  Jer Noble  <jer.noble@apple.com>
>+
>+        Complete fix for enabling modern EME by default
>+        https://bugs.webkit.org/show_bug.cgi?id=185770
>+        <rdar://problem/40368220>
>+
>+        Reviewed by Eric Carlson.
>+
>+        * Configurations/FeatureDefines.xcconfig:
>+
> 2018-05-18  Youenn Fablet  <youenn@apple.com>
> 
>         -Wmemset-elt-size warning in LibWebRTCSocket constructor
>diff --git a/Source/WebKitLegacy/mac/ChangeLog b/Source/WebKitLegacy/mac/ChangeLog
>index eb48da8586ce753ed9b7a8e858f5bffdc0308520..147cf7e5c0fe39460f64d609f81bc675de7591a6 100644
>--- a/Source/WebKitLegacy/mac/ChangeLog
>+++ b/Source/WebKitLegacy/mac/ChangeLog
>@@ -1,3 +1,13 @@
>+2018-05-18  Jer Noble  <jer.noble@apple.com>
>+
>+        Complete fix for enabling modern EME by default
>+        https://bugs.webkit.org/show_bug.cgi?id=185770
>+        <rdar://problem/40368220>
>+
>+        Reviewed by Eric Carlson.
>+
>+        * Configurations/FeatureDefines.xcconfig:
>+
> 2018-05-16  Andy VanWagoner  <andy@vanwagoner.family>
> 
>         Add support for Intl NumberFormat formatToParts
>diff --git a/Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig b/Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig
>index 32f3e4ea0e11f3e483e4bb636e35715eddbec1cb..776ec7cd551c51dcfaff0c5216a9ca5759da3d07 100644
>--- a/Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig
>+++ b/Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig
>@@ -122,7 +122,8 @@ ENABLE_ENCRYPTED_MEDIA_watchos = ENABLE_ENCRYPTED_MEDIA;
> ENABLE_ENCRYPTED_MEDIA_watchsimulator = ENABLE_ENCRYPTED_MEDIA;
> ENABLE_ENCRYPTED_MEDIA_appletvos = ENABLE_ENCRYPTED_MEDIA;
> ENABLE_ENCRYPTED_MEDIA_appletvsimulator = ENABLE_ENCRYPTED_MEDIA;
>-ENABLE_ENCRYPTED_MEDIA_macosx = ENABLE_ENCRYPTED_MEDIA;
>+ENABLE_ENCRYPTED_MEDIA_macosx = $(ENABLE_ENCRYPTED_MEDIA$(WK_MACOS_1014));
>+ENABLE_ENCRYPTED_MEDIA_MACOS_SINCE_1014 = ENABLE_ENCRYPTED_MEDIA;
> 
> ENABLE_EXTRA_ZOOM_MODE = ;
> 
>diff --git a/Source/WebCore/Configurations/FeatureDefines.xcconfig b/Source/WebCore/Configurations/FeatureDefines.xcconfig
>index 32f3e4ea0e11f3e483e4bb636e35715eddbec1cb..776ec7cd551c51dcfaff0c5216a9ca5759da3d07 100644
>--- a/Source/WebCore/Configurations/FeatureDefines.xcconfig
>+++ b/Source/WebCore/Configurations/FeatureDefines.xcconfig
>@@ -122,7 +122,8 @@ ENABLE_ENCRYPTED_MEDIA_watchos = ENABLE_ENCRYPTED_MEDIA;
> ENABLE_ENCRYPTED_MEDIA_watchsimulator = ENABLE_ENCRYPTED_MEDIA;
> ENABLE_ENCRYPTED_MEDIA_appletvos = ENABLE_ENCRYPTED_MEDIA;
> ENABLE_ENCRYPTED_MEDIA_appletvsimulator = ENABLE_ENCRYPTED_MEDIA;
>-ENABLE_ENCRYPTED_MEDIA_macosx = ENABLE_ENCRYPTED_MEDIA;
>+ENABLE_ENCRYPTED_MEDIA_macosx = $(ENABLE_ENCRYPTED_MEDIA$(WK_MACOS_1014));
>+ENABLE_ENCRYPTED_MEDIA_MACOS_SINCE_1014 = ENABLE_ENCRYPTED_MEDIA;
> 
> ENABLE_EXTRA_ZOOM_MODE = ;
> 
>diff --git a/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig b/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig
>index 32f3e4ea0e11f3e483e4bb636e35715eddbec1cb..776ec7cd551c51dcfaff0c5216a9ca5759da3d07 100644
>--- a/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig
>+++ b/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig
>@@ -122,7 +122,8 @@ ENABLE_ENCRYPTED_MEDIA_watchos = ENABLE_ENCRYPTED_MEDIA;
> ENABLE_ENCRYPTED_MEDIA_watchsimulator = ENABLE_ENCRYPTED_MEDIA;
> ENABLE_ENCRYPTED_MEDIA_appletvos = ENABLE_ENCRYPTED_MEDIA;
> ENABLE_ENCRYPTED_MEDIA_appletvsimulator = ENABLE_ENCRYPTED_MEDIA;
>-ENABLE_ENCRYPTED_MEDIA_macosx = ENABLE_ENCRYPTED_MEDIA;
>+ENABLE_ENCRYPTED_MEDIA_macosx = $(ENABLE_ENCRYPTED_MEDIA$(WK_MACOS_1014));
>+ENABLE_ENCRYPTED_MEDIA_MACOS_SINCE_1014 = ENABLE_ENCRYPTED_MEDIA;
> 
> ENABLE_EXTRA_ZOOM_MODE = ;
> 
>diff --git a/Source/WebKit/Configurations/FeatureDefines.xcconfig b/Source/WebKit/Configurations/FeatureDefines.xcconfig
>index 32f3e4ea0e11f3e483e4bb636e35715eddbec1cb..776ec7cd551c51dcfaff0c5216a9ca5759da3d07 100644
>--- a/Source/WebKit/Configurations/FeatureDefines.xcconfig
>+++ b/Source/WebKit/Configurations/FeatureDefines.xcconfig
>@@ -122,7 +122,8 @@ ENABLE_ENCRYPTED_MEDIA_watchos = ENABLE_ENCRYPTED_MEDIA;
> ENABLE_ENCRYPTED_MEDIA_watchsimulator = ENABLE_ENCRYPTED_MEDIA;
> ENABLE_ENCRYPTED_MEDIA_appletvos = ENABLE_ENCRYPTED_MEDIA;
> ENABLE_ENCRYPTED_MEDIA_appletvsimulator = ENABLE_ENCRYPTED_MEDIA;
>-ENABLE_ENCRYPTED_MEDIA_macosx = ENABLE_ENCRYPTED_MEDIA;
>+ENABLE_ENCRYPTED_MEDIA_macosx = $(ENABLE_ENCRYPTED_MEDIA$(WK_MACOS_1014));
>+ENABLE_ENCRYPTED_MEDIA_MACOS_SINCE_1014 = ENABLE_ENCRYPTED_MEDIA;
> 
> ENABLE_EXTRA_ZOOM_MODE = ;
> 
>diff --git a/Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig b/Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig
>index 32f3e4ea0e11f3e483e4bb636e35715eddbec1cb..776ec7cd551c51dcfaff0c5216a9ca5759da3d07 100644
>--- a/Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig
>+++ b/Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig
>@@ -122,7 +122,8 @@ ENABLE_ENCRYPTED_MEDIA_watchos = ENABLE_ENCRYPTED_MEDIA;
> ENABLE_ENCRYPTED_MEDIA_watchsimulator = ENABLE_ENCRYPTED_MEDIA;
> ENABLE_ENCRYPTED_MEDIA_appletvos = ENABLE_ENCRYPTED_MEDIA;
> ENABLE_ENCRYPTED_MEDIA_appletvsimulator = ENABLE_ENCRYPTED_MEDIA;
>-ENABLE_ENCRYPTED_MEDIA_macosx = ENABLE_ENCRYPTED_MEDIA;
>+ENABLE_ENCRYPTED_MEDIA_macosx = $(ENABLE_ENCRYPTED_MEDIA$(WK_MACOS_1014));
>+ENABLE_ENCRYPTED_MEDIA_MACOS_SINCE_1014 = ENABLE_ENCRYPTED_MEDIA;
> 
> ENABLE_EXTRA_ZOOM_MODE = ;
> 
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index a73e06358cea14b18b890da87c79adf395690c72..ed37b0584b801ecd281224f51ea4d48fc0d7ecbd 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,13 @@
>+2018-05-18  Jer Noble  <jer.noble@apple.com>
>+
>+        Complete fix for enabling modern EME by default
>+        https://bugs.webkit.org/show_bug.cgi?id=185770
>+        <rdar://problem/40368220>
>+
>+        Reviewed by Eric Carlson.
>+
>+        * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
>+
> 2018-01-23  Jer Noble  <jer.noble@apple.com>
> 
>         REGRESSION (r220052):VideoControlsManager.VideoControlsManagerMultipleVideosWithAudioAndAutoplay is a flaky API test.
>diff --git a/Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig b/Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig
>index 32f3e4ea0e11f3e483e4bb636e35715eddbec1cb..776ec7cd551c51dcfaff0c5216a9ca5759da3d07 100644
>--- a/Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig
>+++ b/Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig
>@@ -122,7 +122,8 @@ ENABLE_ENCRYPTED_MEDIA_watchos = ENABLE_ENCRYPTED_MEDIA;
> ENABLE_ENCRYPTED_MEDIA_watchsimulator = ENABLE_ENCRYPTED_MEDIA;
> ENABLE_ENCRYPTED_MEDIA_appletvos = ENABLE_ENCRYPTED_MEDIA;
> ENABLE_ENCRYPTED_MEDIA_appletvsimulator = ENABLE_ENCRYPTED_MEDIA;
>-ENABLE_ENCRYPTED_MEDIA_macosx = ENABLE_ENCRYPTED_MEDIA;
>+ENABLE_ENCRYPTED_MEDIA_macosx = $(ENABLE_ENCRYPTED_MEDIA$(WK_MACOS_1014));
>+ENABLE_ENCRYPTED_MEDIA_MACOS_SINCE_1014 = ENABLE_ENCRYPTED_MEDIA;
> 
> ENABLE_EXTRA_ZOOM_MODE = ;
> 
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 8052d103bbdedd4ace922554d5a332d6ef6661c2..9ff57990edd562855878e8838908fd57759eed9d 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,13 @@
>+2018-05-18  Jer Noble  <jer.noble@apple.com>
>+
>+        Complete fix for enabling modern EME by default
>+        https://bugs.webkit.org/show_bug.cgi?id=185770
>+        <rdar://problem/40368220>
>+
>+        Reviewed by Eric Carlson.
>+
>+        * platform/mac-wk1/fast/dom/navigator-detached-no-crash-expected.txt:
>+
> 2018-04-05  Jer Noble  <jer.noble@apple.com>
> 
>         ASSERTION FAILED: m_scriptExecutionContext under WebCore::AudioContext::isPlayingAudioDidChange()
>diff --git a/LayoutTests/platform/mac-wk1/fast/dom/navigator-detached-no-crash-expected.txt b/LayoutTests/platform/mac-wk1/fast/dom/navigator-detached-no-crash-expected.txt
>index 567339c99a232fb0dd2d73e61b11280abd3f27b9..9f7621e879e10e0a04c55c09102c0a5c79cdee30 100644
>--- a/LayoutTests/platform/mac-wk1/fast/dom/navigator-detached-no-crash-expected.txt
>+++ b/LayoutTests/platform/mac-wk1/fast/dom/navigator-detached-no-crash-expected.txt
>@@ -1,4 +1,3 @@
>-CONSOLE MESSAGE: Unhandled Promise Rejection: TypeError: Not enough arguments
> This tests that the navigator object of a deleted frame is disconnected properly. Accessing fields or methods shouldn't crash the browser. 
>  Check Navigator
> navigator.appCodeName is OK
>@@ -17,7 +16,6 @@ navigator.platform is OK
> navigator.plugins is OK
> navigator.product is OK
> navigator.productSub is OK
>-navigator.requestMediaKeySystemAccess() is OK
> navigator.userAgent is OK
> navigator.vendor is OK
> navigator.vendorSub is OK
>@@ -38,7 +36,6 @@ navigator.platform is OK
> navigator.plugins is OK
> navigator.product is OK
> navigator.productSub is OK
>-navigator.requestMediaKeySystemAccess() is OK
> navigator.userAgent is OK
> navigator.vendor is OK
> navigator.vendorSub is OK

Actions: View | Formatted Diff | Diff

Attachments on bug 185770: 340705 | 340715 | 340717 | 340720 | 340725 | 340860 | 340869 | 340872