WebKit Bugzilla
Attachment 340722 Details for
Bug 185776
: build-webkit: Perl "use of uninitialized value $previousContents"
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-185776-20180518115757.patch (text/plain), 1.61 KB, created by
Daniel Bates
on 2018-05-18 11:57:58 PDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Daniel Bates
Created:
2018-05-18 11:57:58 PDT
Size:
1.61 KB
patch
obsolete
>Subversion Revision: 231965 >diff --git a/Tools/ChangeLog b/Tools/ChangeLog >index 5dc6da1b4a1356f96d9a1e83f25b403188f149ea..da99ed74e67c2e37d44d13992767888f8af8dbea 100644 >--- a/Tools/ChangeLog >+++ b/Tools/ChangeLog >@@ -1,3 +1,18 @@ >+2018-05-18 Daniel Bates <dabates@apple.com> >+ >+ build-webkit: Perl "use of uninitialized value $previousContents" >+ https://bugs.webkit.org/show_bug.cgi?id=185776 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ Fixes an issue where reading an empty cached argument file would cause >+ Perl "uninitialized value" warnings of the form: >+ Use of uninitialized value $previousContents in chomp at C:/WebKit-BuildWorker/wincairo-wkl-debug/build/Tools/Scripts/webkitdirs.pm line 1969. >+ Use of uninitialized value $previousContents in string ne at C:/WebKit-BuildWorker/wincairo-wkl-debug/build/Tools/Scripts/webkitdirs.pm line 1972. >+ >+ * Scripts/webkitdirs.pm: >+ (isCachedArgumentfileOutOfDate): >+ > 2018-05-18 Fujii Hironori <Hironori.Fujii@sony.com> > > [Win][MiniBrowser] Create MainWindow even in transparent mode >diff --git a/Tools/Scripts/webkitdirs.pm b/Tools/Scripts/webkitdirs.pm >index 7d05f48faa63daabe642f483a930396ce7472983..7bcbf4e366498764a48e89d73a19bbe2849072d0 100755 >--- a/Tools/Scripts/webkitdirs.pm >+++ b/Tools/Scripts/webkitdirs.pm >@@ -1966,7 +1966,7 @@ sub isCachedArgumentfileOutOfDate($@) > } > > open(CONTENTS_FILE, $filename); >- chomp(my $previousContents = <CONTENTS_FILE>); >+ chomp(my $previousContents = <CONTENTS_FILE> || ""); > close(CONTENTS_FILE); > > if ($previousContents ne $currentContents) {
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 185776
: 340722