Attachment 340687 Details for Bug 185763 – Patch

[patch] Patch

mb-crash.diff (text/plain), 1.77 KB, created by Carlos Garcia Campos on 2018-05-18 03:55:29 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Carlos Garcia Campos

Created: 2018-05-18 03:55:29 PDT

Size: 1.77 KB

patch

obsolete

>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 04538594c5d..242f82ef431 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,18 @@
>+2018-05-18  Carlos Garcia Campos  <cgarcia@igalia.com>
>+
>+        [GTK] MiniBrowser crashes when loading twice quickly
>+        https://bugs.webkit.org/show_bug.cgi?id=185763
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        This is very difficult to reproduce manually, but it happens when running WebDriver tests where loads are very
>+        fast and multiple loads are done quickly. The problem is that we use an idle to reset the progress bar, but we
>+        don't reset it when a new load starts. We always reset the last idle on destroy, but if there's another one
>+        leaked, it will crash when scheduled if the window has already been destroyed.
>+
>+        * MiniBrowser/gtk/BrowserWindow.c:
>+        (webViewLoadProgressChanged): Stop any pending reset task when progress != 1.
>+
> 2018-05-17  Carlos Garcia Campos  <cgarcia@igalia.com>
> 
>         WebDriver: implement maximize, minimize and fullscreen window commands
>diff --git a/Tools/MiniBrowser/gtk/BrowserWindow.c b/Tools/MiniBrowser/gtk/BrowserWindow.c
>index 8b8457d0f5a..ece39c1b3c4 100644
>--- a/Tools/MiniBrowser/gtk/BrowserWindow.c
>+++ b/Tools/MiniBrowser/gtk/BrowserWindow.c
>@@ -177,6 +177,9 @@ static void webViewLoadProgressChanged(WebKitWebView *webView, GParamSpec *pspec
>     if (progress == 1.0) {
>         window->resetEntryProgressTimeoutId = g_timeout_add(500, (GSourceFunc)resetEntryProgress, window);
>         g_source_set_name_by_id(window->resetEntryProgressTimeoutId, "[WebKit] resetEntryProgress");
>+    } else if (window->resetEntryProgressTimeoutId) {
>+        g_source_remove(window->resetEntryProgressTimeoutId);
>+        window->resetEntryProgressTimeoutId = 0;
>     }
> }
>

Flags:

mcatanzaro: review+
ews-watchlist: commit-queue-

Actions: View | Formatted Diff | Diff

Attachments on bug 185763: 340687 | 340689