Attachment 340686 Details for Bug 185760 – Patch

[patch] Patch

bug-185760-20180518020511.patch (text/plain), 4.80 KB, created by Myles C. Maxfield on 2018-05-18 02:05:12 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Myles C. Maxfield

Created: 2018-05-18 02:05:12 PDT

Size: 4.80 KB

patch

obsolete

>Subversion Revision: 231834
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index e3fe716b92fa3fb2d4cd0626fdc4882f4233722f..f588d1963b1ff754783f8e4e917a12d6da4c39c7 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,21 @@
>+2018-05-18  Myles C. Maxfield  <mmaxfield@apple.com>
>+
>+        [iOS] Password fields obscure the text with rectangles instead of circles
>+        https://bugs.webkit.org/show_bug.cgi?id=185760
>+        <rdar://problem/38644697>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Password fields are obscured by drawing U+25CF BLACK CIRCLE. On iOS, we have custom handling
>+        for this character. However, this custom handling is unnecessary and isn't present on macOS.
>+        Instead, we should simply unify the password obscuring codepath between iOS and macOS.
>+
>+        Test: fast/text/black-circle.html
>+
>+        * platform/graphics/ios/FontCacheIOS.mm:
>+        (WebCore::requiresCustomFallbackFont):
>+        (WebCore::FontCache::getCustomFallbackFont):
>+
> 2018-05-15  Commit Queue  <commit-queue@webkit.org>
> 
>         Unreviewed, rolling out r231765.
>diff --git a/Source/WebCore/platform/graphics/ios/FontCacheIOS.mm b/Source/WebCore/platform/graphics/ios/FontCacheIOS.mm
>index deeb97a6f734b1b55368e693f7f55b38b65a7f29..9e5ed9e93009e1987723c3e14782319ffe05a257 100644
>--- a/Source/WebCore/platform/graphics/ios/FontCacheIOS.mm
>+++ b/Source/WebCore/platform/graphics/ios/FontCacheIOS.mm
>@@ -45,7 +45,7 @@ namespace WebCore {
> 
> bool requiresCustomFallbackFont(UChar32 character)
> {
>-    return character == AppleLogo || character == blackCircle || character == narrowNonBreakingSpace;
>+    return character == AppleLogo || character == narrowNonBreakingSpace;
> }
> 
> FontPlatformData* FontCache::getCustomFallbackFont(const UInt32 c, const FontDescription& description)
>@@ -53,7 +53,6 @@ FontPlatformData* FontCache::getCustomFallbackFont(const UInt32 c, const FontDes
>     ASSERT(requiresCustomFallbackFont(c));
> 
>     static NeverDestroyed<AtomicString> helveticaFamily("Helvetica Neue", AtomicString::ConstructFromLiteral);
>-    static NeverDestroyed<AtomicString> lockClockFamily("LockClock-Light", AtomicString::ConstructFromLiteral);
>     static NeverDestroyed<AtomicString> timesNewRomanPSMTFamily("TimesNewRomanPSMT", AtomicString::ConstructFromLiteral);
> 
>     AtomicString* family = nullptr;
>@@ -61,9 +60,6 @@ FontPlatformData* FontCache::getCustomFallbackFont(const UInt32 c, const FontDes
>     case AppleLogo:
>         family = &helveticaFamily.get();
>         break;
>-    case blackCircle:
>-        family = &lockClockFamily.get();
>-        break;
>     case narrowNonBreakingSpace:
>         family = &timesNewRomanPSMTFamily.get();
>         break;
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 161e28e4e2dbe35064fe9b34f65c8b61db170394..4c35632a839be3e62c3a6ef08d36246a9821f0f8 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,14 @@
>+2018-05-18  Myles C. Maxfield  <mmaxfield@apple.com>
>+
>+        [iOS] Password fields obscure the text with rectangles instead of circles
>+        https://bugs.webkit.org/show_bug.cgi?id=185760
>+        <rdar://problem/38644697>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * fast/text/black-circle-expected.html: Added.
>+        * fast/text/black-circle.html: Added.
>+
> 2018-05-15  Commit Queue  <commit-queue@webkit.org>
> 
>         Unreviewed, rolling out r231765.
>diff --git a/LayoutTests/fast/text/black-circle-expected.html b/LayoutTests/fast/text/black-circle-expected.html
>new file mode 100644
>index 0000000000000000000000000000000000000000..4e265251ea95ef5a2bac60fec46b032c578d8161
>--- /dev/null
>+++ b/LayoutTests/fast/text/black-circle-expected.html
>@@ -0,0 +1,11 @@
>+<!DOCTYPE html>
>+<html>
>+<head>
>+<meta name="viewport" content="width=device-width, initial-scale=1">
>+</head>
>+<body>
>+This test makes sure that U+25CF BLACK CIRCLE is rendered as an actual dot. The test passes if you see a black square below.
>+<div style="position: relative; width: 50px; height: 50px; overflow: hidden; background-color: black;">
>+</div>
>+</body>
>+</html>
>diff --git a/LayoutTests/fast/text/black-circle.html b/LayoutTests/fast/text/black-circle.html
>new file mode 100644
>index 0000000000000000000000000000000000000000..8afcd11568db20aeb0fef57a5fd7b8fad6016fbc
>--- /dev/null
>+++ b/LayoutTests/fast/text/black-circle.html
>@@ -0,0 +1,12 @@
>+<!DOCTYPE html>
>+<html>
>+<head>
>+<meta name="viewport" content="width=device-width, initial-scale=1">
>+</head>
>+<body>
>+This test makes sure that U+25CF BLACK CIRCLE is rendered as an actual dot. The test passes if you see a black square below.
>+<div style="position: relative; width: 50px; height: 50px; overflow: hidden;">
>+<div style="font-family: 'Courier'; transform-origin: left top; transform: scale(20); position: absolute; left: -60px; top: -150px;">&#x25CF;</div>
>+</div>
>+</body>
>+</html>

Actions: View | Formatted Diff | Diff

Attachments on bug 185760: 340686 | 340690