Attachment 340677 Details for Bug 185758 – Patch

[patch] Patch

bug-185758-20180517212848.patch (text/plain), 6.32 KB, created by Devin Rousso on 2018-05-17 21:28:48 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Devin Rousso

Created: 2018-05-17 21:28:48 PDT

Size: 6.32 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index c736e200fd8d994892a46a4435c676a854fbd5cb..8b2588100bba6c403677f0765e847d97f57860b3 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,23 @@
>+2018-05-17  Devin Rousso  <webkit@devinrousso.com>
>+
>+        Web Inspector: Canvas: put `hasVisualEffect` behind an experimental setting
>+        https://bugs.webkit.org/show_bug.cgi?id=185758
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Localizations/en.lproj/localizedStrings.js:
>+
>+        * UserInterface/Base/Setting.js:
>+
>+        * UserInterface/Models/RecordingAction.js:
>+        (WI.RecordingAction.prototype.process):
>+
>+        * UserInterface/Views/RecordingActionTreeElement.js:
>+        (WI.RecordingActionTreeElement.prototype.onattach):
>+
>+        * UserInterface/Views/SettingsTabContentView.js:
>+        (WI.SettingsTabContentView.prototype._createExperimentalSettingsView):
>+
> 2018-05-16  Devin Rousso  <webkit@devinrousso.com>
> 
>         Web Inspector: create a navigation item for toggling the overlay rulers/guides
>diff --git a/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js b/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
>index 56b699ae26b46c31551d9b29f0cbf31a77efe6ea..0dace4f5911fe1108055a00221a76df7516be3b4 100644
>--- a/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
>+++ b/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
>@@ -170,6 +170,7 @@ localizedStrings["Canvas"] = "Canvas";
> localizedStrings["Canvas %d"] = "Canvas %d";
> localizedStrings["Canvas %s"] = "Canvas %s";
> localizedStrings["Canvas Element"] = "Canvas Element";
>+localizedStrings["Canvas:"] = "Canvas:";
> localizedStrings["Canvases"] = "Canvases";
> localizedStrings["Cap"] = "Cap";
> localizedStrings["Caps"] = "Caps";
>@@ -372,6 +373,7 @@ localizedStrings["Enable Layers Tab"] = "Enable Layers Tab";
> localizedStrings["Enable New Tab Bar"] = "Enable New Tab Bar";
> localizedStrings["Enable Program"] = "Enable Program";
> localizedStrings["Enable Sources Tab"] = "Enable Sources Tab";
>+localizedStrings["Enable Visual Change Detection"] = "Enable Visual Change Detection";
> localizedStrings["Enable all breakpoints (%s)"] = "Enable all breakpoints (%s)";
> localizedStrings["Enable breakpoints"] = "Enable breakpoints";
> localizedStrings["Enable paint flashing"] = "Enable paint flashing";
>diff --git a/Source/WebInspectorUI/UserInterface/Base/Setting.js b/Source/WebInspectorUI/UserInterface/Base/Setting.js
>index 1fbc25130aef10a11694fadd81682e8cedee1cd8..a8ab2b9d7cbaf1c1c45f47e7592ff98b99b876ea 100644
>--- a/Source/WebInspectorUI/UserInterface/Base/Setting.js
>+++ b/Source/WebInspectorUI/UserInterface/Base/Setting.js
>@@ -130,4 +130,5 @@ WI.settings = {
>     experimentalLegacyVisualSidebar: new WI.Setting("experimental-legacy-visual-sidebar", false),
>     experimentalEnableNewTabBar: new WI.Setting("experimental-enable-new-tab-bar", false),
>     experimentalEnableAccessibilityAuditTab: new WI.Setting("experimental-enable-accessibility-audit-tab", false),
>+    experimentalRecordingHasVisualEffect: new WI.Setting("experimental-recording-has-visual-effect", false),
> };
>diff --git a/Source/WebInspectorUI/UserInterface/Models/RecordingAction.js b/Source/WebInspectorUI/UserInterface/Models/RecordingAction.js
>index 129763e8f32d6140ee29faf2a670d9d2b6dcc3bb..0705d12517b609d4d6ba6015ddc03a42013d587f 100644
>--- a/Source/WebInspectorUI/UserInterface/Models/RecordingAction.js
>+++ b/Source/WebInspectorUI/UserInterface/Models/RecordingAction.js
>@@ -139,12 +139,13 @@ WI.RecordingAction = class RecordingAction extends WI.Object
>         }
> 
>         let contentBefore = null;
>-        if (this._valid && this._isVisual)
>+        let shouldCheckHasVisualEffect = WI.settings.experimentalRecordingHasVisualEffect.value && this._valid && this._isVisual;
>+        if (shouldCheckHasVisualEffect)
>             contentBefore = getContent();
> 
>         this.apply(context);
> 
>-        if (this._valid && this._isVisual)
>+        if (shouldCheckHasVisualEffect)
>             this._hasVisibleEffect = !Array.shallowEqual(contentBefore, getContent());
> 
>         if (recording.type === WI.Recording.Type.Canvas2D) {
>diff --git a/Source/WebInspectorUI/UserInterface/Views/RecordingActionTreeElement.js b/Source/WebInspectorUI/UserInterface/Views/RecordingActionTreeElement.js
>index 68d18f0568ef5b2824cf57b375aa1161d1525a32..e6dc51f1b4ab90981bc6c56a151895ea2750f9bc 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/RecordingActionTreeElement.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/RecordingActionTreeElement.js
>@@ -399,7 +399,7 @@ WI.RecordingActionTreeElement = class RecordingActionTreeElement extends WI.Gene
> 
>         this.element.dataset.index = this._index.toLocaleString();
> 
>-        if (this.representedObject.valid && this.representedObject.isVisual && !this.representedObject.hasVisibleEffect) {
>+        if (WI.settings.experimentalRecordingHasVisualEffect.value && this.representedObject.valid && this.representedObject.isVisual && !this.representedObject.hasVisibleEffect) {
>             this.addClassName("no-visible-effect");
> 
>             const title = WI.UIString("This action causes no visual change");
>diff --git a/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js b/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js
>index 2be57b9daf95fec68a8cf6d6efe12c0306a56b21..79cc9cebc81c1bc1a73d5ecd43d1a30feff113bf 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js
>@@ -259,6 +259,9 @@ WI.SettingsTabContentView = class SettingsTabContentView extends WI.TabContentVi
>         experimentalSettingsView.addSetting(WI.UIString("Accessibility Audit:"), WI.settings.experimentalEnableAccessibilityAuditTab, WI.UIString("Enable Accessibility Audit Tab"));
>         experimentalSettingsView.addSeparator();
> 
>+        experimentalSettingsView.addSetting(WI.UIString("Canvas:"), WI.settings.experimentalRecordingHasVisualEffect, WI.UIString("Enable Visual Change Detection"));
>+        experimentalSettingsView.addSeparator();
>+
>         let reloadInspectorButton = document.createElement("button");
>         reloadInspectorButton.textContent = WI.UIString("Reload Web Inspector");
>         reloadInspectorButton.addEventListener("click", () => { window.location.reload(); });

Actions: View | Formatted Diff | Diff

Attachments on bug 185758: 340677 | 340721