Attachment 340653 Details for Bug 185747 – Patch

[patch] Patch

bug-185747-20180517145446.patch (text/plain), 2.47 KB, created by Jeremy Jones on 2018-05-17 14:54:46 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Jeremy Jones

Created: 2018-05-17 14:54:46 PDT

Size: 2.47 KB

patch

obsolete

>Subversion Revision: 231157
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 94ad2070a4ea348dc42026f18b777d87595753d6..bfef7176761cc51db10f60c0973439a7c95008da 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,20 @@
>+2018-05-17  Jeremy Jones  <jeremyj@apple.com>
>+
>+        Remove unnecessary exit fullscreen call on application resume
>+        https://bugs.webkit.org/show_bug.cgi?id=185747
>+        rdar://problem/40345725
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        No new tests because no behavior change.
>+
>+        Auto-PiP doesn't automatically returns to fullscreen on app resume,
>+        so we don't need to keep this vestigial code for handling a corner case of that feature.
>+        Also, this can cause an unnecessary exit fullscreen that could cause debug asserts.
>+
>+        * platform/ios/VideoFullscreenInterfaceAVKit.mm:
>+        (VideoFullscreenInterfaceAVKit::applicationDidBecomeActive):
>+
> 2018-04-30  Michael Catanzaro  <mcatanzaro@igalia.com>
> 
>         [GTK] Webkit should spoof as Safari on a Mac when on Chase.com
>diff --git a/Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm b/Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm
>index f413f15dff45f05894522a0c73791f70a3f3ab6e..cc02b0a085e44817d172b6c8addcfd1601a0cc9a 100644
>--- a/Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm
>+++ b/Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm
>@@ -1282,15 +1282,6 @@ bool VideoFullscreenInterfaceAVKit::shouldExitFullscreenWithReason(VideoFullscre
> void VideoFullscreenInterfaceAVKit::applicationDidBecomeActive()
> {
>     LOG(Fullscreen, "VideoFullscreenInterfaceAVKit::applicationDidBecomeActive(%p)", this);
>-
>-    // If we are both in PiP and in Fullscreen (i.e., via auto-PiP), and we did not stop fullscreen upon returning, it must be
>-    // because the originating view is not visible, so hide the fullscreen window.
>-    if (m_currentMode.hasFullscreen() && m_currentMode.hasPictureInPicture()) {
>-        [[m_playerViewController view] layoutIfNeeded];
>-        [m_playerViewController exitFullScreenAnimated:NO completionHandler:[protectedThis = makeRefPtr(this), this] (BOOL success, NSError *error) {
>-            exitFullscreenHandler(success, error);
>-        }];
>-    }
> }
> 
> void VideoFullscreenInterfaceAVKit::setupFullscreen(UIView& videoView, const IntRect& initialRect, UIView* parentView, HTMLMediaElementEnums::VideoFullscreenMode mode, bool allowsPictureInPicturePlayback, bool standby)

Flags:

jer.noble: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 185747: 340653 | 340655