Attachment 340599 Details for Bug 185736 – Patch

[patch] Patch

bug-185736-20180517105035.patch (text/plain), 2.48 KB, created by Jeremy Jones on 2018-05-17 10:50:36 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Jeremy Jones

Created: 2018-05-17 10:50:36 PDT

Size: 2.48 KB

patch

obsolete

>Subversion Revision: 231157
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index b45b9c8b7b0bf1893057b858c851d46fbe2c2b68..2c277e73876f0a7111740db7f1ff337d25cf3bca 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,17 @@
>+2018-05-17  Jeremy Jones  <jeremyj@apple.com>
>+
>+        Ensure valid rects for fullsceen animation.
>+        https://bugs.webkit.org/show_bug.cgi?id=185736
>+        rdar://problem/40320174
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Protect against zero width and height since those can make for NANs in the animation transforms.
>+
>+        * UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:
>+        (-[WKFullScreenWindowController beganEnterFullScreenWithInitialFrame:finalFrame:]):
>+        (-[WKFullScreenWindowController beganExitFullScreenWithInitialFrame:finalFrame:]):
>+
> 2018-04-30  Andy Estes  <aestes@apple.com>
> 
>         [iOS] Try to unlock PDF documents before printing them
>diff --git a/Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm b/Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm
>index b3de4ddd94a9caa321b68f8103130c0622d55e64..9c9173d18e85ac10cbd7b53452b8195bec913d50 100644
>--- a/Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm
>+++ b/Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm
>@@ -502,7 +502,13 @@ - (void)beganEnterFullScreenWithInitialFrame:(CGRect)initialFrame finalFrame:(CG
> 
>     _initialFrame = initialFrame;
>     _finalFrame = finalFrame;
>+    
>+    _initialFrame.size.width = std::max(_initialFrame.size.width, 1.0);
>+    _initialFrame.size.height = std::max(_initialFrame.size.height, 1.0);
> 
>+    _finalFrame.size.width = std::max(_finalFrame.size.width, 1.0);
>+    _finalFrame.size.height = std::max(_finalFrame.size.height, 1.0);
>+    
>     [CATransaction begin];
>     [CATransaction setDisableActions:YES];
> 
>@@ -568,6 +574,12 @@ - (void)beganExitFullScreenWithInitialFrame:(CGRect)initialFrame finalFrame:(CGR
>     _initialFrame = initialFrame;
>     _finalFrame = finalFrame;
>     
>+    _initialFrame.size.width = std::max(_initialFrame.size.width, 1.0);
>+    _initialFrame.size.height = std::max(_initialFrame.size.height, 1.0);
>+    
>+    _finalFrame.size.width = std::max(_finalFrame.size.width, 1.0);
>+    _finalFrame.size.height = std::max(_finalFrame.size.height, 1.0);
>+    
>     [_webView _page]->setSuppressVisibilityUpdates(true);
> 
>     [_fullscreenViewController setPrefersStatusBarHidden:NO];

Flags:

jer.noble: review+
ews-watchlist: commit-queue-

Actions: View | Formatted Diff | Diff

Attachments on bug 185736: 340599 | 340604 | 340618