Attachment 340589 Details for Bug 185731 – Patch

[patch] Patch

bug-185731-20180517174238.patch (text/plain), 4.06 KB, created by Alicia Boya García on 2018-05-17 08:42:39 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Alicia Boya García

Created: 2018-05-17 08:42:39 PDT

Size: 4.06 KB

patch

obsolete

>Subversion Revision: 231892
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 867b72a7460b1a469dc2ea9294872594335c3a1e..44a9a79d1f6a861326ce8be45790ffc43b721fd0 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,18 @@
>+2018-05-17  Alicia Boya GarcÃa  <aboya@igalia.com>
>+
>+        [MSE][GStreamer] Add patch to jhbuild: matroskademux: Allow Matroska headers to be read more than once
>+        https://bugs.webkit.org/show_bug.cgi?id=185731
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Upstream bug in GStreamer: https://bugzilla.gnome.org/show_bug.cgi?id=793333
>+
>+        This fixes YTTV 35. AppendMultipleInitOpusAudio (and any other use
>+        case where two WebM initialization segments are appended on a row).
>+
>+        * gstreamer/jhbuild.modules:
>+        * gstreamer/patches/gst-plugins-good-0010-matroskademux-allow-matroska-headers-to-be-read-more-than-once.patch: Added.
>+
> 2018-05-16  Leo Balter  <leonardo.balter@gmail.com>
> 
>         Test262-Runner: Adds a --timeout option
>diff --git a/Tools/gstreamer/jhbuild.modules b/Tools/gstreamer/jhbuild.modules
>index 9912b3d6475e871fc2e5e912ff5811be7809d2d4..474102437fbc33e30d827ce84515bf6d9dc3c88c 100644
>--- a/Tools/gstreamer/jhbuild.modules
>+++ b/Tools/gstreamer/jhbuild.modules
>@@ -79,6 +79,7 @@
>       <patch file="gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch" strip="1"/>
>       <patch file="gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch" strip="1"/>
>       <patch file="gst-plugins-good-0009-qtdemux-fix-assert-when-moof-contains-one-sample.patch" strip="1"/>
>+      <patch file="gst-plugins-good-0010-matroskademux-allow-matroska-headers-to-be-read-more-than-once.patch" strip="1"/>
>     </branch>
>   </autotools>
> 
>diff --git a/Tools/gstreamer/patches/gst-plugins-good-0010-matroskademux-allow-matroska-headers-to-be-read-more-than-once.patch b/Tools/gstreamer/patches/gst-plugins-good-0010-matroskademux-allow-matroska-headers-to-be-read-more-than-once.patch
>new file mode 100644
>index 0000000000000000000000000000000000000000..48b2df89835fd9818a70470c051bf07f247d62cb
>--- /dev/null
>+++ b/Tools/gstreamer/patches/gst-plugins-good-0010-matroskademux-allow-matroska-headers-to-be-read-more-than-once.patch
>@@ -0,0 +1,44 @@
>+From f5bad1b59ccc7c27a8d7008e453880c4f24d5493 Mon Sep 17 00:00:00 2001
>+From: =?UTF-8?q?Alicia=20Boya=20Garc=C3=ADa?= <ntrrgc@gmail.com>
>+Date: Thu, 30 Nov 2017 20:44:23 +0100
>+Subject: [PATCH] matroskademux: Allow Matroska headers to be read more than
>+ once
>+
>+This is necessary for MSE, where a new MSE initialization segment may be
>+appended at any point. These MSE initialization segments consist of an
>+entire WebM file until the first Cluster element (not included). [1]
>+
>+Note that track definitions are ignored on successive headers, they must
>+match, but this is not checked by matroskademux (look for
>+`(!demux->tracks_parsed)` in the code).
>+
>+Source pads are not altered when the new headers are read.
>+
>+This patch has been splitted from the original patch from eocanha in [2].
>+
>+[1] https://www.w3.org/TR/mse-byte-stream-format-webm/
>+[2] https://bug334082.bugzilla-attachments.gnome.org/attachment.cgi?id=362212
>+
>+https://bugzilla.gnome.org/show_bug.cgi?id=793333
>+---
>+ gst/matroska/matroska-demux.c | 5 +++++
>+ 1 file changed, 5 insertions(+)
>+
>+diff --git a/gst/matroska/matroska-demux.c b/gst/matroska/matroska-demux.c
>+index eee41d655..fc8651442 100644
>+--- a/gst/matroska/matroska-demux.c
>++++ b/gst/matroska/matroska-demux.c
>+@@ -4658,6 +4658,11 @@ gst_matroska_demux_parse_id (GstMatroskaDemux * demux, guint32 id,
>+     case GST_MATROSKA_READ_STATE_DATA:
>+     case GST_MATROSKA_READ_STATE_SEEK:
>+       switch (id) {
>++        case GST_EBML_ID_HEADER:
>++          GST_READ_CHECK (gst_matroska_demux_flush (demux, read));
>++          demux->common.state = GST_MATROSKA_READ_STATE_SEGMENT;
>++          gst_matroska_demux_check_seekability (demux);
>++          break;
>+         case GST_MATROSKA_ID_SEGMENTINFO:
>+           if (!demux->common.segmentinfo_parsed) {
>+             GST_READ_CHECK (gst_matroska_demux_take (demux, read, &ebml));
>+-- 
>+2.14.3

Actions: View | Formatted Diff | Diff

Attachments on bug 185731: 340589 | 350631