Attachment 340582 Details for Bug 185727 – Patch

[patch] Patch

bug-185727-20180517164009.patch (text/plain), 4.67 KB, created by Rob Buis on 2018-05-17 07:40:10 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Rob Buis

Created: 2018-05-17 07:40:10 PDT

Size: 4.67 KB

patch

obsolete

>Subversion Revision: 231889
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 14c0afc06fd46c38830fe62d643ad5adb5b2ccdc..129232d8e3e99e8a5ed8ac44bd75606892296244 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-05-17  Rob Buis  <rbuis@igalia.com>
>+
>+        Remove cssom-remove-shorthand-property.html test
>+        https://bugs.webkit.org/show_bug.cgi?id=185727
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Exact same test is contained in WPT:
>+        cssom/cssom-setProperty-shorthand.html
>+
>+        * fast/css/cssom-remove-shorthand-property-expected.txt: Removed.
>+        * fast/css/cssom-remove-shorthand-property.html: Removed.
>+
> 2018-05-16  Brady Eidson  <beidson@apple.com>
> 
>         LayoutTest storage/indexeddb/dont-wedge-private.html is a flaky failure
>diff --git a/LayoutTests/fast/css/cssom-remove-shorthand-property-expected.txt b/LayoutTests/fast/css/cssom-remove-shorthand-property-expected.txt
>deleted file mode 100644
>index c8c87506f59a4e8dc53acd7783d75f5c5feb49d8..0000000000000000000000000000000000000000
>--- a/LayoutTests/fast/css/cssom-remove-shorthand-property-expected.txt
>+++ /dev/null
>@@ -1,47 +0,0 @@
>-Tests that shorthand properties can be removed via CSSOM.
>-
>-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
>-
>-
>-PASS canSetProperty('font') is true
>-PASS canRemoveProperty('font') is true
>-PASS canSetProperty('border-top') is true
>-PASS canRemoveProperty('border-top') is true
>-PASS canSetProperty('border-right') is true
>-PASS canRemoveProperty('border-right') is true
>-PASS canSetProperty('border-bottom') is true
>-PASS canRemoveProperty('border-bottom') is true
>-PASS canSetProperty('border-left') is true
>-PASS canRemoveProperty('border-left') is true
>-PASS canSetProperty('border') is true
>-PASS canRemoveProperty('border') is true
>-PASS canSetProperty('border-color') is true
>-PASS canRemoveProperty('border-color') is true
>-PASS canSetProperty('border-style') is true
>-PASS canRemoveProperty('border-style') is true
>-PASS canSetProperty('border-width') is true
>-PASS canRemoveProperty('border-width') is true
>-PASS canSetProperty('background-position') is true
>-PASS canRemoveProperty('background-position') is true
>-PASS canSetProperty('background-repeat') is true
>-PASS canRemoveProperty('background-repeat') is true
>-PASS canSetProperty('border-spacing') is true
>-PASS canRemoveProperty('border-spacing') is true
>-PASS canSetProperty('list-style') is true
>-PASS canRemoveProperty('list-style') is true
>-PASS canSetProperty('margin') is true
>-PASS canRemoveProperty('margin') is true
>-PASS canSetProperty('outline') is true
>-PASS canRemoveProperty('outline') is true
>-PASS canSetProperty('padding') is true
>-PASS canRemoveProperty('padding') is true
>-PASS canSetProperty('background') is true
>-PASS canRemoveProperty('background') is true
>-PASS canSetProperty('overflow') is true
>-PASS canRemoveProperty('overflow') is true
>-PASS canSetProperty('border-radius') is true
>-PASS canRemoveProperty('border-radius') is true
>-PASS successfullyParsed is true
>-
>-TEST COMPLETE
>-
>diff --git a/LayoutTests/fast/css/cssom-remove-shorthand-property.html b/LayoutTests/fast/css/cssom-remove-shorthand-property.html
>deleted file mode 100644
>index 759a4271f38ff6303c72fc8842d016c0dbee314f..0000000000000000000000000000000000000000
>--- a/LayoutTests/fast/css/cssom-remove-shorthand-property.html
>+++ /dev/null
>@@ -1,56 +0,0 @@
>-<!DOCTYPE html>
>-<html>
>-<head>
>-<meta charset="utf-8">
>-<script src="../../resources/js-test-pre.js"></script>
>-</head>
>-<body>
>-<script>
>-
>-shorthandProperties = [
>-    "font",
>-    "border-top",
>-    "border-right",
>-    "border-bottom",
>-    "border-left",
>-    "border",
>-    "border-color",
>-    "border-style",
>-    "border-width",
>-    "background-position",
>-    "background-repeat",
>-    "border-spacing",
>-    "list-style",
>-    "margin",
>-    "outline",
>-    "padding",
>-    "background",
>-    "overflow",
>-    "border-radius"
>-];
>-
>-element = document.createElement('span');
>-
>-function canSetProperty(propertyName) {
>-    element.style.setProperty(propertyName, 'initial');
>-    return element.style.getPropertyValue(propertyName) == 'initial';
>-}
>-
>-function canRemoveProperty(propertyName) {
>-    element.style.removeProperty(propertyName);
>-    return element.style.getPropertyValue(propertyName) != 'initial';
>-}
>-
>-description("Tests that shorthand properties can be removed via CSSOM.");
>-
>-for (i = 0; i < shorthandProperties.length; ++i) {
>-    var propertyName = shorthandProperties[i];
>-
>-    shouldBe("canSetProperty('" + propertyName + "')", "true");
>-    shouldBe("canRemoveProperty('" + propertyName + "')", "true");
>-}
>-
>-</script>
>-<script src="../../resources/js-test-post.js"></script>
>-</body>
>-</html>

Actions: View | Formatted Diff | Diff

Attachments on bug 185727: 340582