Attachment 340578 Details for Bug 185724 – Patch

[patch] Patch

bug-185724-20180517154038.patch (text/plain), 2.82 KB, created by Alicia Boya García on 2018-05-17 06:40:40 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Alicia Boya García

Created: 2018-05-17 06:40:40 PDT

Size: 2.82 KB

patch

obsolete

>Subversion Revision: 231892
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index ae073322d0fbd8ef35315365458b069da8e51084..114add5188499d4b275b511b7c91434ea3ede9bf 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,18 @@
>+2018-05-17  Alicia Boya GarcÃa  <aboya@igalia.com>
>+
>+        [MSE][GStreamer] Stream::decodebinSinkPad is read but never assigned
>+        https://bugs.webkit.org/show_bug.cgi?id=185724
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        This is a dead code removal patch; except when a Stream instance
>+        happens to be instantiated in such a place that the non-initialized
>+        decodeSinkPad is != 0, then it is a crash bug fix.
>+
>+        * platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.cpp:
>+        (webKitMediaSrcLinkStreamToSrcPad):
>+        * platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamerPrivate.h:
>+
> 2018-05-17  Thibault Saunier  <tsaunier@igalia.com>
> 
>         [GStreamer]: Consider GstStream(Collection) as if if was not a GInitiallyUnowned
>diff --git a/Source/WebCore/platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.cpp b/Source/WebCore/platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.cpp
>index bb14f2bce8cdedf6be86726d23209ace0b99cf05..7acff6fa593667d68124157c0694384f2ba74419 100644
>--- a/Source/WebCore/platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.cpp
>+++ b/Source/WebCore/platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.cpp
>@@ -478,14 +478,6 @@ void webKitMediaSrcLinkStreamToSrcPad(GstPad* sourcePad, Stream* stream)
> 
>     gst_pad_set_active(ghostpad, TRUE);
>     gst_element_add_pad(GST_ELEMENT(stream->parent), ghostpad);
>-
>-    if (stream->decodebinSinkPad) {
>-        GST_DEBUG_OBJECT(stream->parent, "A decodebin was previously used for this source, trying to reuse it.");
>-        // FIXME: error checking here. Not sure what to do if linking
>-        // fails though, because decodebin is out of this source
>-        // element's scope, in theory.
>-        gst_pad_link(ghostpad, stream->decodebinSinkPad);
>-    }
> }
> 
> void webKitMediaSrcLinkParser(GstPad* sourcePad, GstCaps* caps, Stream* stream)
>diff --git a/Source/WebCore/platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamerPrivate.h b/Source/WebCore/platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamerPrivate.h
>index a8109017aaf4c5abdbb8c85bd71b75fb03615907..980cec350e99f0a3d06727205645b98cc64cca77 100644
>--- a/Source/WebCore/platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamerPrivate.h
>+++ b/Source/WebCore/platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamerPrivate.h
>@@ -51,7 +51,6 @@ struct _Stream {
> 
>     // AppSrc. Never modified after first assignment.
>     GstElement* appsrc;
>-    GstPad* decodebinSinkPad;
> 
>     // Never modified after first assignment.
>     WebCore::SourceBufferPrivateGStreamer* sourceBuffer;

Actions: View | Formatted Diff | Diff

Attachments on bug 185724: 340578