Attachment 340565 Details for Bug 177684 – Patch

[patch] Patch

bug-177684-20180517110005.patch (text/plain), 1.50 KB, created by Rob Buis on 2018-05-17 02:00:06 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Rob Buis

Created: 2018-05-17 02:00:06 PDT

Size: 1.50 KB

patch

obsolete

>Subversion Revision: 231889
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index c59b643ce2c19e91cb64cb9e4fc03dbc073d392a..c35d244d22637563e9c68dcd53757dbff59da109 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,17 @@
>+2018-05-17  Rob Buis  <rbuis@igalia.com>
>+
>+        Cannot unset transition with important
>+        https://bugs.webkit.org/show_bug.cgi?id=177684
>+
>+        Really unset important in removeProperty
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        No new tests (OOPS!).
>+
>+        * css/StyleProperties.cpp:
>+        (WebCore::MutableStyleProperties::removePropertiesInSet):
>+
> 2018-05-16  Devin Rousso  <webkit@devinrousso.com>
> 
>         Web Inspector: create a navigation item for toggling the overlay rulers/guides
>diff --git a/Source/WebCore/css/StyleProperties.cpp b/Source/WebCore/css/StyleProperties.cpp
>index 3c8ce43b357d2c4ed787f79c5b0684df7864d260..30dbeb42b6b5a67a06fa9c65e0fdfc6deccf9086 100644
>--- a/Source/WebCore/css/StyleProperties.cpp
>+++ b/Source/WebCore/css/StyleProperties.cpp
>@@ -1227,8 +1227,7 @@ bool MutableStyleProperties::removePropertiesInSet(const CSSPropertyID* set, uns
>         toRemove.add(set[i]);
> 
>     return m_propertyVector.removeAllMatching([&toRemove] (const CSSProperty& property) {
>-        // Not quite sure if the isImportant test is needed but it matches the existing behavior.
>-        return !property.isImportant() && toRemove.contains(property.id());
>+        return toRemove.contains(property.id());
>     }) > 0;
> }
>

Actions: View | Formatted Diff | Diff

Attachments on bug 177684: 322231 | 340565 | 340575 | 340609 | 340641 | 340681