Attachment 340546 Details for Bug 185707 – patch

[patch] patch

c-backup.diff (text/plain), 1.20 KB, created by Saam Barati on 2018-05-16 17:57:39 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Saam Barati

Created: 2018-05-16 17:57:39 PDT

Size: 1.20 KB

patch

obsolete

>Index: Source/JavaScriptCore/ChangeLog
>===================================================================
>--- Source/JavaScriptCore/ChangeLog	(revision 231880)
>+++ Source/JavaScriptCore/ChangeLog	(working copy)
>@@ -1,3 +1,13 @@
>+2018-05-16  Saam Barati  <sbarati@apple.com>
>+
>+        VM::shrinkFootprint should call collectNow(Sync) instead of collectSync so it also eagerly sweeps
>+        https://bugs.webkit.org/show_bug.cgi?id=185707
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * runtime/VM.cpp:
>+        (JSC::VM::shrinkFootprint):
>+
> 2018-05-16  Commit Queue  <commit-queue@webkit.org>
> 
>         Unreviewed, rolling out r231845.
>Index: Source/JavaScriptCore/runtime/VM.cpp
>===================================================================
>--- Source/JavaScriptCore/runtime/VM.cpp	(revision 231880)
>+++ Source/JavaScriptCore/runtime/VM.cpp	(working copy)
>@@ -778,7 +778,7 @@ void VM::shrinkFootprint()
> {
>     sanitizeStackForVM(this);
>     deleteAllCode(DeleteAllCodeIfNotCollecting);
>-    heap.collectSync();
>+    heap.collectNow(Synchronousness::Sync);
>     WTF::releaseFastMallocFreeMemory();
>     // FIXME: Consider stopping various automatic threads here.
>     // https://bugs.webkit.org/show_bug.cgi?id=185447

Actions: View | Formatted Diff | Diff

Attachments on bug 185707: 340546