WebKit Bugzilla
Attachment 340534 Details for
Bug 184058
: REGRESSION (r229831?): LayoutTest storage/indexeddb/dont-wedge-private.html is a flaky failure
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-184058-20180516155530.patch (text/plain), 3.95 KB, created by
Brady Eidson
on 2018-05-16 15:55:31 PDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Brady Eidson
Created:
2018-05-16 15:55:31 PDT
Size:
3.95 KB
patch
obsolete
>Subversion Revision: 231818 >diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog >index 20fe42c35b71a0727255195c922cafe012f3cfa7..027d8697d75d0744bffaff6695a55f2e47963634 100644 >--- a/LayoutTests/ChangeLog >+++ b/LayoutTests/ChangeLog >@@ -1,3 +1,19 @@ >+2018-05-16 Brady Eidson <beidson@apple.com> >+ >+ LayoutTest storage/indexeddb/dont-wedge-private.html is a flaky failure >+ <rdar://problem/38975304> and https://bugs.webkit.org/show_bug.cgi?id=184058 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ Make the asynchronous IDB part of this test take way, way longer to always give the location change a chance to happen. >+ >+ * TestExpectations: >+ * storage/indexeddb/dont-wedge-expected.txt: >+ * storage/indexeddb/dont-wedge-private-expected.txt: >+ * storage/indexeddb/resources/dont-wedge.js: >+ (openDatabase1.request.onupgradeneeded.openOnUpgradeNeeded1.putter): >+ (openDatabase1.request.onupgradeneeded): >+ > 2018-05-15 Jer Noble <jer.noble@apple.com> > > Media continues loading after rendered invisible (removed from DOM; scrolled off screen) >diff --git a/LayoutTests/TestExpectations b/LayoutTests/TestExpectations >index d8ad7a168352c9838e85a3fea8f907589b5d494f..e6545f154f1fabc400c439d4ec5db504f73dda1e 100644 >--- a/LayoutTests/TestExpectations >+++ b/LayoutTests/TestExpectations >@@ -1896,8 +1896,6 @@ webkit.org/b/116621 fast/replaced/preferred-widths.html [ Pass Failure ] > > webkit.org/b/184198 imported/w3c/web-platform-tests/html/browsers/offline/appcache/workers/appcache-worker.html [ Pass Failure ] > >-webkit.org/b/184058 storage/indexeddb/dont-wedge-private.html [ Pass Failure ] >- > webkit.org/b/184061 http/tests/appcache/interrupted-update.html [ Pass Failure ] > > webkit.org/b/184453 imported/w3c/web-platform-tests/workers/name-property.html [ Pass Failure ] >diff --git a/LayoutTests/storage/indexeddb/dont-wedge-expected.txt b/LayoutTests/storage/indexeddb/dont-wedge-expected.txt >index b5664884d6090801301890e6a30f95ac68fdc9b4..2498ac7f0355ca05b90539ae565c438075c0d93b 100644 >--- a/LayoutTests/storage/indexeddb/dont-wedge-expected.txt >+++ b/LayoutTests/storage/indexeddb/dont-wedge-expected.txt >@@ -19,9 +19,6 @@ openDatabase1(): > indexedDB.open(dbname1, 1) > > openOnUpgradeNeeded1(): >-db1 = event.target.result >-store1 = db1.createObjectStore('store') >-store1.put(0, 0) > > openOnSuccess1(): > PASS isAfterReload() is true >diff --git a/LayoutTests/storage/indexeddb/dont-wedge-private-expected.txt b/LayoutTests/storage/indexeddb/dont-wedge-private-expected.txt >index b5664884d6090801301890e6a30f95ac68fdc9b4..2498ac7f0355ca05b90539ae565c438075c0d93b 100644 >--- a/LayoutTests/storage/indexeddb/dont-wedge-private-expected.txt >+++ b/LayoutTests/storage/indexeddb/dont-wedge-private-expected.txt >@@ -19,9 +19,6 @@ openDatabase1(): > indexedDB.open(dbname1, 1) > > openOnUpgradeNeeded1(): >-db1 = event.target.result >-store1 = db1.createObjectStore('store') >-store1.put(0, 0) > > openOnSuccess1(): > PASS isAfterReload() is true >diff --git a/LayoutTests/storage/indexeddb/resources/dont-wedge.js b/LayoutTests/storage/indexeddb/resources/dont-wedge.js >index 690ca5f3b5a8ebce88493395b818e6d2aedcdce2..2f8141c326773be3231833815bbe1e8b833b62c1 100644 >--- a/LayoutTests/storage/indexeddb/resources/dont-wedge.js >+++ b/LayoutTests/storage/indexeddb/resources/dont-wedge.js >@@ -54,9 +54,16 @@ function openDatabase1() > request.onblocked = unexpectedBlockedCallback; > request.onupgradeneeded = function openOnUpgradeNeeded1(evt) { > preamble(evt); >- evalAndLog("db1 = event.target.result"); >- evalAndLog("store1 = db1.createObjectStore('store')"); >- evalAndLog("store1.put(0, 0)"); >+ db1 = event.target.result; >+ store1 = db1.createObjectStore('store'); >+ var count = 0; >+ function putter() { >+ ++count; >+ if (count == 50) >+ return; >+ store1.put(0, 0).onsuccess = putter; >+ } >+ putter(); > }; > request.onsuccess = function openOnSuccess1(evt) { > preamble(evt);
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 184058
: 340534