Attachment 340482 Details for Bug 185350 – Patch

[patch] Patch

bug-185350-20180516182038.patch (text/plain), 27.50 KB, created by Yusuke Suzuki on 2018-05-16 02:20:40 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Yusuke Suzuki

Created: 2018-05-16 02:20:40 PDT

Size: 27.50 KB

patch

obsolete

>Subversion Revision: 231840
>diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog
>index df5329c678d14ae59451300711829db751db72ff..4303bcf460c08a62f6ea503415553f1e0daa0c63 100644
>--- a/Source/JavaScriptCore/ChangeLog
>+++ b/Source/JavaScriptCore/ChangeLog
>@@ -1,3 +1,53 @@
>+2018-05-16  Yusuke Suzuki  <utatane.tea@gmail.com>
>+
>+        [JSC] Remove reifyPropertyNameIfNeeded
>+        https://bugs.webkit.org/show_bug.cgi?id=185350
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        reifyPropertyNameIfNeeded is in the middle of putDirectInternal, which is super critical path.
>+        This is a virtual call, and it is only used by JSFunction right now. Since this causes too much
>+        cost, we should remove this from the critical path.
>+
>+        This patch removes this function call from the critical path. And in our slow paths, we call
>+        helper functions which calls reifyLazyPropertyIfNeeded if the given value is a JSFunction.
>+        While putDirect is a bit raw API, our slow paths just call it. This helper wraps this calls
>+        and care the edge cases. The other callsites of putDirect should know the type of the given
>+        object and the name of the property (And avoid these edge cases).
>+
>+        This improves SixSpeed/object-assign.es6 by ~4% on MacBook Pro. And this patch does not cause
>+        regressions of the existing tests.
>+
>+                                           baseline                  patched
>+        Kraken:
>+            json-parse-financial        35.522+-0.069      ^      34.708+-0.097         ^ definitely 1.0234x faster
>+
>+        SixSpeed:
>+            object-assign.es6         145.8779+-0.2838     ^    140.1019+-0.8007        ^ definitely 1.0412x faster
>+
>+        * dfg/DFGOperations.cpp:
>+        (JSC::DFG::putByValInternal):
>+        (JSC::DFG::putByValCellInternal):
>+        * jit/JITOperations.cpp:
>+        * llint/LLIntSlowPaths.cpp:
>+        (JSC::LLInt::LLINT_SLOW_PATH_DECL):
>+        * runtime/ClassInfo.h:
>+        * runtime/CommonSlowPaths.h:
>+        (JSC::CommonSlowPaths::putDirectWithReify):
>+        (JSC::CommonSlowPaths::putDirectAccessorWithReify):
>+        * runtime/JSCell.cpp:
>+        (JSC::JSCell::reifyPropertyNameIfNeeded): Deleted.
>+        * runtime/JSCell.h:
>+        * runtime/JSFunction.cpp:
>+        (JSC::JSFunction::reifyPropertyNameIfNeeded): Deleted.
>+        * runtime/JSFunction.h:
>+        * runtime/JSObject.cpp:
>+        (JSC::JSObject::putDirectAccessor):
>+        (JSC::JSObject::putDirectNonIndexAccessor):
>+        * runtime/JSObject.h:
>+        * runtime/JSObjectInlines.h:
>+        (JSC::JSObject::putDirectInternal):
>+
> 2018-05-15  Yusuke Suzuki  <utatane.tea@gmail.com>
> 
>         [JSC] Check TypeInfo first before calling getCallData when we would like to check whether given object is a function
>diff --git a/Source/JavaScriptCore/dfg/DFGOperations.cpp b/Source/JavaScriptCore/dfg/DFGOperations.cpp
>index 5b0947e3d5f5bd8e6250bd9ec549e8b966eb80fc..3b69d70420a06171549e87116d159d799ada4f6f 100644
>--- a/Source/JavaScriptCore/dfg/DFGOperations.cpp
>+++ b/Source/JavaScriptCore/dfg/DFGOperations.cpp
>@@ -138,12 +138,13 @@ ALWAYS_INLINE static void putByValInternal(ExecState* exec, VM& vm, EncodedJSVal
>     PutPropertySlot slot(baseValue, strict);
>     if (direct) {
>         RELEASE_ASSERT(baseValue.isObject());
>+        JSObject* baseObject = asObject(baseValue);
>         if (std::optional<uint32_t> index = parseIndex(propertyName)) {
>             scope.release();
>-            asObject(baseValue)->putDirectIndex(exec, index.value(), value, 0, strict ? PutDirectIndexShouldThrow : PutDirectIndexShouldNotThrow);
>+            baseObject->putDirectIndex(exec, index.value(), value, 0, strict ? PutDirectIndexShouldThrow : PutDirectIndexShouldNotThrow);
>             return;
>         }
>-        asObject(baseValue)->putDirect(vm, propertyName, value, slot);
>+        CommonSlowPaths::putDirectWithReify(vm, exec, baseObject, propertyName, value, slot);
>         return;
>     }
>     scope.release();
>@@ -156,10 +157,12 @@ ALWAYS_INLINE static void putByValCellInternal(ExecState* exec, VM& vm, JSCell*
>     PutPropertySlot slot(base, strict);
>     if (direct) {
>         RELEASE_ASSERT(base->isObject());
>-        if (std::optional<uint32_t> index = parseIndex(propertyName))
>-            asObject(base)->putDirectIndex(exec, index.value(), value, 0, strict ? PutDirectIndexShouldThrow : PutDirectIndexShouldNotThrow);
>-        else
>-            asObject(base)->putDirect(vm, propertyName, value, slot);
>+        JSObject* baseObject = asObject(base);
>+        if (std::optional<uint32_t> index = parseIndex(propertyName)) {
>+            baseObject->putDirectIndex(exec, index.value(), value, 0, strict ? PutDirectIndexShouldThrow : PutDirectIndexShouldNotThrow);
>+            return;
>+        }
>+        CommonSlowPaths::putDirectWithReify(vm, exec, baseObject, propertyName, value, slot);
>         return;
>     }
>     base->putInline(exec, propertyName, value, slot);
>@@ -822,7 +825,7 @@ void JIT_OPERATION operationPutDoubleByValDirectBeyondArrayBoundsStrict(ExecStat
>     }
> 
>     PutPropertySlot slot(object, true);
>-    object->putDirect(vm, Identifier::from(exec, index), jsValue, slot);
>+    CommonSlowPaths::putDirectWithReify(vm, exec, object, Identifier::from(exec, index), jsValue, slot);
> }
> 
> void JIT_OPERATION operationPutDoubleByValDirectBeyondArrayBoundsNonStrict(ExecState* exec, JSObject* object, int32_t index, double value)
>@@ -838,7 +841,7 @@ void JIT_OPERATION operationPutDoubleByValDirectBeyondArrayBoundsNonStrict(ExecS
>     }
> 
>     PutPropertySlot slot(object, false);
>-    object->putDirect(vm, Identifier::from(exec, index), jsValue, slot);
>+    CommonSlowPaths::putDirectWithReify(vm, exec, object, Identifier::from(exec, index), jsValue, slot);
> }
> 
> void JIT_OPERATION operationPutByValDirectStrict(ExecState* exec, EncodedJSValue encodedBase, EncodedJSValue encodedProperty, EncodedJSValue encodedValue)
>@@ -915,7 +918,7 @@ void JIT_OPERATION operationPutByValDirectBeyondArrayBoundsStrict(ExecState* exe
>     }
>     
>     PutPropertySlot slot(object, true);
>-    object->putDirect(vm, Identifier::from(exec, index), JSValue::decode(encodedValue), slot);
>+    CommonSlowPaths::putDirectWithReify(vm, exec, object, Identifier::from(exec, index), JSValue::decode(encodedValue), slot);
> }
> 
> void JIT_OPERATION operationPutByValDirectBeyondArrayBoundsNonStrict(ExecState* exec, JSObject* object, int32_t index, EncodedJSValue encodedValue)
>@@ -929,7 +932,7 @@ void JIT_OPERATION operationPutByValDirectBeyondArrayBoundsNonStrict(ExecState*
>     }
>     
>     PutPropertySlot slot(object, false);
>-    object->putDirect(vm, Identifier::from(exec, index), JSValue::decode(encodedValue), slot);
>+    CommonSlowPaths::putDirectWithReify(vm, exec, object, Identifier::from(exec, index), JSValue::decode(encodedValue), slot);
> }
> 
> EncodedJSValue JIT_OPERATION operationArrayPush(ExecState* exec, EncodedJSValue encodedValue, JSArray* array)
>diff --git a/Source/JavaScriptCore/jit/JITOperations.cpp b/Source/JavaScriptCore/jit/JITOperations.cpp
>index b288d1e2bc31cbf499c40eeca6570ee1f4f9ceff..b2f62e9cde30a67ab0efa515a77b7a87ea40ce0a 100644
>--- a/Source/JavaScriptCore/jit/JITOperations.cpp
>+++ b/Source/JavaScriptCore/jit/JITOperations.cpp
>@@ -474,32 +474,32 @@ void JIT_OPERATION operationPutByIdDirectStrict(ExecState* exec, StructureStubIn
> {
>     SuperSamplerScope superSamplerScope(false);
>     
>-    VM* vm = &exec->vm();
>-    NativeCallFrameTracer tracer(vm, exec);
>+    VM& vm = exec->vm();
>+    NativeCallFrameTracer tracer(&vm, exec);
>     
>     stubInfo->tookSlowPath = true;
>     
>     JSValue baseValue = JSValue::decode(encodedBase);
>-    Identifier ident = Identifier::fromUid(vm, uid);
>-    LOG_IC((ICEvent::OperationPutByIdDirectStrict, baseValue.classInfoOrNull(*vm), ident));
>+    Identifier ident = Identifier::fromUid(&vm, uid);
>+    LOG_IC((ICEvent::OperationPutByIdDirectStrict, baseValue.classInfoOrNull(vm), ident));
>     PutPropertySlot slot(baseValue, true, exec->codeBlock()->putByIdContext());
>-    asObject(baseValue)->putDirect(*vm, ident, JSValue::decode(encodedValue), slot);
>+    CommonSlowPaths::putDirectWithReify(vm, exec, asObject(baseValue), ident, JSValue::decode(encodedValue), slot);
> }
> 
> void JIT_OPERATION operationPutByIdDirectNonStrict(ExecState* exec, StructureStubInfo* stubInfo, EncodedJSValue encodedValue, EncodedJSValue encodedBase, UniquedStringImpl* uid)
> {
>     SuperSamplerScope superSamplerScope(false);
>     
>-    VM* vm = &exec->vm();
>-    NativeCallFrameTracer tracer(vm, exec);
>+    VM& vm = exec->vm();
>+    NativeCallFrameTracer tracer(&vm, exec);
>     
>     stubInfo->tookSlowPath = true;
>     
>     JSValue baseValue = JSValue::decode(encodedBase);
>-    Identifier ident = Identifier::fromUid(vm, uid);
>-    LOG_IC((ICEvent::OperationPutByIdDirectNonStrict, baseValue.classInfoOrNull(*vm), ident));
>+    Identifier ident = Identifier::fromUid(&vm, uid);
>+    LOG_IC((ICEvent::OperationPutByIdDirectNonStrict, baseValue.classInfoOrNull(vm), ident));
>     PutPropertySlot slot(baseValue, false, exec->codeBlock()->putByIdContext());
>-    asObject(baseValue)->putDirect(*vm, ident, JSValue::decode(encodedValue), slot);
>+    CommonSlowPaths::putDirectWithReify(vm, exec, asObject(baseValue), ident, JSValue::decode(encodedValue), slot);
> }
> 
> void JIT_OPERATION operationPutByIdStrictOptimize(ExecState* exec, StructureStubInfo* stubInfo, EncodedJSValue encodedValue, EncodedJSValue encodedBase, UniquedStringImpl* uid)
>@@ -562,20 +562,21 @@ void JIT_OPERATION operationPutByIdDirectStrictOptimize(ExecState* exec, Structu
> {
>     SuperSamplerScope superSamplerScope(false);
>     
>-    VM* vm = &exec->vm();
>-    NativeCallFrameTracer tracer(vm, exec);
>+    VM& vm = exec->vm();
>+    NativeCallFrameTracer tracer(&vm, exec);
>+    auto scope = DECLARE_THROW_SCOPE(vm);
>     
>-    Identifier ident = Identifier::fromUid(vm, uid);
>+    Identifier ident = Identifier::fromUid(&vm, uid);
>     AccessType accessType = static_cast<AccessType>(stubInfo->accessType);
> 
>     JSValue value = JSValue::decode(encodedValue);
>     JSObject* baseObject = asObject(JSValue::decode(encodedBase));
>-    LOG_IC((ICEvent::OperationPutByIdDirectStrictOptimize, baseObject->classInfo(*vm), ident));
>+    LOG_IC((ICEvent::OperationPutByIdDirectStrictOptimize, baseObject->classInfo(vm), ident));
>     CodeBlock* codeBlock = exec->codeBlock();
>     PutPropertySlot slot(baseObject, true, codeBlock->putByIdContext());
>-    
>-    Structure* structure = baseObject->structure(*vm);
>-    baseObject->putDirect(*vm, ident, value, slot);
>+    Structure* structure = nullptr;
>+    CommonSlowPaths::putDirectWithReify(vm, exec, baseObject, ident, value, slot, &structure);
>+    RETURN_IF_EXCEPTION(scope, void());
>     
>     if (accessType != static_cast<AccessType>(stubInfo->accessType))
>         return;
>@@ -588,20 +589,21 @@ void JIT_OPERATION operationPutByIdDirectNonStrictOptimize(ExecState* exec, Stru
> {
>     SuperSamplerScope superSamplerScope(false);
>     
>-    VM* vm = &exec->vm();
>-    NativeCallFrameTracer tracer(vm, exec);
>+    VM& vm = exec->vm();
>+    NativeCallFrameTracer tracer(&vm, exec);
>+    auto scope = DECLARE_THROW_SCOPE(vm);
>     
>-    Identifier ident = Identifier::fromUid(vm, uid);
>+    Identifier ident = Identifier::fromUid(&vm, uid);
>     AccessType accessType = static_cast<AccessType>(stubInfo->accessType);
> 
>     JSValue value = JSValue::decode(encodedValue);
>     JSObject* baseObject = asObject(JSValue::decode(encodedBase));
>-    LOG_IC((ICEvent::OperationPutByIdDirectNonStrictOptimize, baseObject->classInfo(*vm), ident));
>+    LOG_IC((ICEvent::OperationPutByIdDirectNonStrictOptimize, baseObject->classInfo(vm), ident));
>     CodeBlock* codeBlock = exec->codeBlock();
>     PutPropertySlot slot(baseObject, false, codeBlock->putByIdContext());
>-    
>-    Structure* structure = baseObject->structure(*vm);
>-    baseObject->putDirect(*vm, ident, value, slot);
>+    Structure* structure = nullptr;
>+    CommonSlowPaths::putDirectWithReify(vm, exec, baseObject, ident, value, slot, &structure);
>+    RETURN_IF_EXCEPTION(scope, void());
>     
>     if (accessType != static_cast<AccessType>(stubInfo->accessType))
>         return;
>@@ -710,7 +712,7 @@ static void directPutByVal(CallFrame* callFrame, JSObject* baseObject, JSValue s
>         byValInfo->tookSlowPath = true;
> 
>     PutPropertySlot slot(baseObject, isStrictMode);
>-    baseObject->putDirect(vm, property, value, slot);
>+    CommonSlowPaths::putDirectWithReify(vm, callFrame, baseObject, property, value, slot);
> }
> 
> enum class OptimizationResult {
>@@ -1745,7 +1747,7 @@ void JIT_OPERATION operationPutGetterSetter(ExecState* exec, JSCell* object, Uni
>     NativeCallFrameTracer tracer(&vm, exec);
> 
>     ASSERT(object && object->isObject());
>-    JSObject* baseObj = asObject(object);
>+    JSObject* baseObject = asObject(object);
> 
>     GetterSetter* accessor = GetterSetter::create(vm, exec->lexicalGlobalObject());
> 
>@@ -1759,7 +1761,7 @@ void JIT_OPERATION operationPutGetterSetter(ExecState* exec, JSCell* object, Uni
>         accessor->setGetter(vm, exec->lexicalGlobalObject(), asObject(getter));
>     if (!setter.isUndefined())
>         accessor->setSetter(vm, exec->lexicalGlobalObject(), asObject(setter));
>-    baseObj->putDirectAccessor(exec, uid, accessor, attribute);
>+    CommonSlowPaths::putDirectAccessorWithReify(vm, exec, baseObject, uid, accessor, attribute);
> }
> 
> #else
>@@ -1769,7 +1771,7 @@ void JIT_OPERATION operationPutGetterSetter(ExecState* exec, JSCell* object, Uni
>     NativeCallFrameTracer tracer(&vm, exec);
> 
>     ASSERT(object && object->isObject());
>-    JSObject* baseObj = asObject(object);
>+    JSObject* baseObject = asObject(object);
> 
>     GetterSetter* accessor = GetterSetter::create(vm, exec->lexicalGlobalObject());
> 
>@@ -1781,7 +1783,7 @@ void JIT_OPERATION operationPutGetterSetter(ExecState* exec, JSCell* object, Uni
>         accessor->setGetter(vm, exec->lexicalGlobalObject(), getter->getObject());
>     if (setter)
>         accessor->setSetter(vm, exec->lexicalGlobalObject(), setter->getObject());
>-    baseObj->putDirectAccessor(exec, uid, accessor, attribute);
>+    CommonSlowPaths::putDirectAccessorWithReify(vm, exec, baseObject, uid, accessor, attribute);
> }
> #endif
> 
>diff --git a/Source/JavaScriptCore/llint/LLIntSlowPaths.cpp b/Source/JavaScriptCore/llint/LLIntSlowPaths.cpp
>index 88bcbc98d9fc52df16ff84aabaa4ea2c9e671025..5ccdcfe4146496b9aebe51010a977ca276e1da68 100644
>--- a/Source/JavaScriptCore/llint/LLIntSlowPaths.cpp
>+++ b/Source/JavaScriptCore/llint/LLIntSlowPaths.cpp
>@@ -793,7 +793,7 @@ LLINT_SLOW_PATH_DECL(slow_path_put_by_id)
>     JSValue baseValue = LLINT_OP_C(1).jsValue();
>     PutPropertySlot slot(baseValue, codeBlock->isStrictMode(), codeBlock->putByIdContext());
>     if (pc[8].u.putByIdFlags & PutByIdIsDirect)
>-        asObject(baseValue)->putDirect(vm, ident, LLINT_OP_C(3).jsValue(), slot);
>+        CommonSlowPaths::putDirectWithReify(vm, exec, asObject(baseValue), ident, LLINT_OP_C(3).jsValue(), slot);
>     else
>         baseValue.putInline(exec, ident, LLINT_OP_C(3).jsValue(), slot);
>     LLINT_CHECK_EXCEPTION();
>@@ -1010,7 +1010,7 @@ LLINT_SLOW_PATH_DECL(slow_path_put_by_val_direct)
>         baseObject->putDirectIndex(exec, index.value(), value, 0, isStrictMode ? PutDirectIndexShouldThrow : PutDirectIndexShouldNotThrow);
>     else {
>         PutPropertySlot slot(baseObject, isStrictMode);
>-        baseObject->putDirect(vm, property, value, slot);
>+        CommonSlowPaths::putDirectWithReify(vm, exec, baseObject, property, value, slot);
>     }
>     LLINT_END();
> }
>@@ -1077,7 +1077,7 @@ LLINT_SLOW_PATH_DECL(slow_path_put_getter_setter_by_id)
> {
>     LLINT_BEGIN();
>     ASSERT(LLINT_OP(1).jsValue().isObject());
>-    JSObject* baseObj = asObject(LLINT_OP(1).jsValue());
>+    JSObject* baseObject = asObject(LLINT_OP(1).jsValue());
>     
>     GetterSetter* accessor = GetterSetter::create(vm, exec->lexicalGlobalObject());
>     LLINT_CHECK_EXCEPTION();
>@@ -1092,10 +1092,7 @@ LLINT_SLOW_PATH_DECL(slow_path_put_getter_setter_by_id)
>         accessor->setGetter(vm, exec->lexicalGlobalObject(), asObject(getter));
>     if (!setter.isUndefined())
>         accessor->setSetter(vm, exec->lexicalGlobalObject(), asObject(setter));
>-    baseObj->putDirectAccessor(
>-        exec,
>-        exec->codeBlock()->identifier(pc[2].u.operand),
>-        accessor, pc[3].u.operand);
>+    CommonSlowPaths::putDirectAccessorWithReify(vm, exec, baseObject, exec->codeBlock()->identifier(pc[2].u.operand), accessor, pc[3].u.operand);
>     LLINT_END();
> }
> 
>diff --git a/Source/JavaScriptCore/runtime/ClassInfo.h b/Source/JavaScriptCore/runtime/ClassInfo.h
>index 687bd9ae9ceff3065128c1d4739a4ceb7f2aab0b..42b39e1c68d3ed610a202681ff5acd45d6661300 100644
>--- a/Source/JavaScriptCore/runtime/ClassInfo.h
>+++ b/Source/JavaScriptCore/runtime/ClassInfo.h
>@@ -130,9 +130,6 @@ struct MethodTable {
> 
>     using VisitOutputConstraintsPtr = void (*)(JSCell*, SlotVisitor&);
>     VisitOutputConstraintsPtr WTF_METHOD_TABLE_ENTRY(visitOutputConstraints);
>-
>-    using ReifyPropertyNameIfNeededPtr = PropertyReificationResult (*)(JSCell*, ExecState*, PropertyName&);
>-    ReifyPropertyNameIfNeededPtr WTF_METHOD_TABLE_ENTRY(reifyPropertyNameIfNeeded);
> };
> 
> #define CREATE_MEMBER_CHECKER(member) \
>@@ -187,7 +184,6 @@ struct MethodTable {
>         &ClassName::heapSnapshot, \
>         &ClassName::estimatedSize, \
>         &ClassName::visitOutputConstraints, \
>-        &ClassName::reifyPropertyNameIfNeeded, \
>     }, \
>     ClassName::TypedArrayStorageType
> 
>diff --git a/Source/JavaScriptCore/runtime/CommonSlowPaths.h b/Source/JavaScriptCore/runtime/CommonSlowPaths.h
>index 2549f6caec2374da3ef426811a1db0370ec1dbba..dc395a11c44ae256d66032204a89bd51c7a084f1 100644
>--- a/Source/JavaScriptCore/runtime/CommonSlowPaths.h
>+++ b/Source/JavaScriptCore/runtime/CommonSlowPaths.h
>@@ -225,6 +225,28 @@ inline bool canAccessArgumentIndexQuickly(JSObject& object, uint32_t index)
>     return false;
> }
> 
>+static ALWAYS_INLINE void putDirectWithReify(VM& vm, ExecState* exec, JSObject* baseObject, PropertyName propertyName, JSValue value, PutPropertySlot& slot, Structure** result = nullptr)
>+{
>+    if (baseObject->inherits<JSFunction>(vm)) {
>+        auto scope = DECLARE_THROW_SCOPE(vm);
>+        jsCast<JSFunction*>(baseObject)->reifyLazyPropertyIfNeeded(vm, exec, propertyName);
>+        RETURN_IF_EXCEPTION(scope, void());
>+    }
>+    if (result)
>+        *result = baseObject->structure(vm);
>+    baseObject->putDirect(vm, propertyName, value, slot);
>+}
>+
>+static ALWAYS_INLINE void putDirectAccessorWithReify(VM& vm, ExecState* exec, JSObject* baseObject, PropertyName propertyName, GetterSetter* accessor, unsigned attribute)
>+{
>+    if (baseObject->inherits<JSFunction>(vm)) {
>+        auto scope = DECLARE_THROW_SCOPE(vm);
>+        jsCast<JSFunction*>(baseObject)->reifyLazyPropertyIfNeeded(vm, exec, propertyName);
>+        RETURN_IF_EXCEPTION(scope, void());
>+    }
>+    baseObject->putDirectAccessor(exec, propertyName, accessor, attribute);
>+}
>+
> } // namespace CommonSlowPaths
> 
> class ExecState;
>diff --git a/Source/JavaScriptCore/runtime/JSCell.cpp b/Source/JavaScriptCore/runtime/JSCell.cpp
>index 68bebd699221a6b5b9df18076ad2250ca32bce66..1d0b5cc7cb82c84f317992355e85348e052d94ac 100644
>--- a/Source/JavaScriptCore/runtime/JSCell.cpp
>+++ b/Source/JavaScriptCore/runtime/JSCell.cpp
>@@ -64,11 +64,6 @@ size_t JSCell::estimatedSize(JSCell* cell)
>     return cell->cellSize();
> }
> 
>-PropertyReificationResult JSCell::reifyPropertyNameIfNeeded(JSCell*, ExecState*, PropertyName&)
>-{
>-    return PropertyReificationResult::Nothing;
>-}
>-
> void JSCell::heapSnapshot(JSCell*, HeapSnapshotBuilder&)
> {
> }
>diff --git a/Source/JavaScriptCore/runtime/JSCell.h b/Source/JavaScriptCore/runtime/JSCell.h
>index f509373e31c5d0cf9a236eb83b3e37583d153373..8808cb5aa14297921c5a2430d75fb4202887c46c 100644
>--- a/Source/JavaScriptCore/runtime/JSCell.h
>+++ b/Source/JavaScriptCore/runtime/JSCell.h
>@@ -57,12 +57,6 @@ enum class GCDeferralContextArgPresense {
>     DoesNotHaveArg
> };
> 
>-enum class PropertyReificationResult {
>-    Nothing,
>-    Something,
>-    TriedButFailed, // Sometimes the property name already exists but has special behavior and can't be reified, e.g. Array.length.
>-};
>-
> template<typename T> void* allocateCell(Heap&, size_t = sizeof(T));
> template<typename T> void* tryAllocateCell(Heap&, size_t = sizeof(T));
> template<typename T> void* allocateCell(Heap&, GCDeferralContext*, size_t = sizeof(T));
>@@ -179,8 +173,6 @@ class JSCell : public HeapCell {
>     static void visitChildren(JSCell*, SlotVisitor&);
>     static void visitOutputConstraints(JSCell*, SlotVisitor&);
> 
>-    JS_EXPORT_PRIVATE static PropertyReificationResult reifyPropertyNameIfNeeded(JSCell*, ExecState*, PropertyName&);
>-
>     JS_EXPORT_PRIVATE static void heapSnapshot(JSCell*, HeapSnapshotBuilder&);
> 
>     // Object operations, with the toObject operation included.
>diff --git a/Source/JavaScriptCore/runtime/JSFunction.cpp b/Source/JavaScriptCore/runtime/JSFunction.cpp
>index deb1a67e266d06c1166c363eacc490577542a3e6..c8cf513dd59c2438cd6f4a02be4f5aee57dafd8f 100644
>--- a/Source/JavaScriptCore/runtime/JSFunction.cpp
>+++ b/Source/JavaScriptCore/runtime/JSFunction.cpp
>@@ -233,13 +233,6 @@ void JSFunction::visitChildren(JSCell* cell, SlotVisitor& visitor)
>     visitor.append(thisObject->m_rareData);
> }
> 
>-PropertyReificationResult JSFunction::reifyPropertyNameIfNeeded(JSCell* cell, ExecState* exec, PropertyName& propertyName)
>-{
>-    JSFunction* thisObject = jsCast<JSFunction*>(cell);
>-    PropertyStatus propertyType = thisObject->reifyLazyPropertyIfNeeded(exec->vm(), exec, propertyName);
>-    return isReified(propertyType) ? PropertyReificationResult::Something : PropertyReificationResult::Nothing;
>-}
>-
> CallType JSFunction::getCallData(JSCell* cell, CallData& callData)
> {
>     JSFunction* thisObject = jsCast<JSFunction*>(cell);
>diff --git a/Source/JavaScriptCore/runtime/JSFunction.h b/Source/JavaScriptCore/runtime/JSFunction.h
>index c3fb0c39d2546fb5463c733cb42e06ced563301f..2991affb362912aa162c4cbda56366e09bf2d22a 100644
>--- a/Source/JavaScriptCore/runtime/JSFunction.h
>+++ b/Source/JavaScriptCore/runtime/JSFunction.h
>@@ -156,6 +156,13 @@ class JSFunction : public JSCallee {
>     bool canUseAllocationProfile();
>     bool canUseAllocationProfileNonInline();
> 
>+    enum class PropertyStatus {
>+        Eager,
>+        Lazy,
>+        Reified,
>+    };
>+    PropertyStatus reifyLazyPropertyIfNeeded(VM&, ExecState*, PropertyName);
>+
> protected:
>     JS_EXPORT_PRIVATE JSFunction(VM&, JSGlobalObject*, Structure*);
>     JSFunction(VM&, FunctionExecutable*, JSScope*, Structure*);
>@@ -173,8 +180,6 @@ class JSFunction : public JSCallee {
> 
>     static void visitChildren(JSCell*, SlotVisitor&);
> 
>-    static PropertyReificationResult reifyPropertyNameIfNeeded(JSCell*, ExecState*, PropertyName&);
>-
> private:
>     static JSFunction* createImpl(VM& vm, FunctionExecutable* executable, JSScope* scope, Structure* structure)
>     {
>@@ -194,15 +199,9 @@ class JSFunction : public JSCallee {
>     void reifyName(VM&, ExecState*);
>     void reifyName(VM&, ExecState*, String name);
> 
>-    enum class PropertyStatus {
>-        Eager,
>-        Lazy,
>-        Reified,
>-    };
>     static bool isLazy(PropertyStatus property) { return property == PropertyStatus::Lazy || property == PropertyStatus::Reified; }
>     static bool isReified(PropertyStatus property) { return property == PropertyStatus::Reified; }
> 
>-    PropertyStatus reifyLazyPropertyIfNeeded(VM&, ExecState*, PropertyName);
>     PropertyStatus reifyLazyPropertyForHostOrBuiltinIfNeeded(VM&, ExecState*, PropertyName);
>     PropertyStatus reifyLazyLengthIfNeeded(VM&, ExecState*, PropertyName);
>     PropertyStatus reifyLazyNameIfNeeded(VM&, ExecState*, PropertyName);
>diff --git a/Source/JavaScriptCore/runtime/JSObject.cpp b/Source/JavaScriptCore/runtime/JSObject.cpp
>index 2ac12d9e9a07150683696612f048b56bf628c358..d84f9931e01989a3632b3f8dcd46c79e839207dd 100644
>--- a/Source/JavaScriptCore/runtime/JSObject.cpp
>+++ b/Source/JavaScriptCore/runtime/JSObject.cpp
>@@ -1752,14 +1752,14 @@ bool JSObject::putSetter(ExecState* exec, PropertyName propertyName, JSValue set
>     return defineOwnProperty(this, exec, propertyName, descriptor, true);
> }
> 
>-bool JSObject::putDirectAccessor(ExecState* exec, PropertyName propertyName, JSValue value, unsigned attributes)
>+bool JSObject::putDirectAccessor(ExecState* exec, PropertyName propertyName, GetterSetter* accessor, unsigned attributes)
> {
>-    ASSERT(value.isGetterSetter() && (attributes & PropertyAttribute::Accessor));
>+    ASSERT(attributes & PropertyAttribute::Accessor);
> 
>     if (std::optional<uint32_t> index = parseIndex(propertyName))
>-        return putDirectIndex(exec, index.value(), value, attributes, PutDirectIndexLikePutDirect);
>+        return putDirectIndex(exec, index.value(), accessor, attributes, PutDirectIndexLikePutDirect);
> 
>-    return putDirectNonIndexAccessor(exec->vm(), propertyName, value, attributes);
>+    return putDirectNonIndexAccessor(exec->vm(), propertyName, accessor, attributes);
> }
> 
> bool JSObject::putDirectCustomAccessor(VM& vm, PropertyName propertyName, JSValue value, unsigned attributes)
>@@ -1778,10 +1778,10 @@ bool JSObject::putDirectCustomAccessor(VM& vm, PropertyName propertyName, JSValu
>     return result;
> }
> 
>-bool JSObject::putDirectNonIndexAccessor(VM& vm, PropertyName propertyName, JSValue value, unsigned attributes)
>+bool JSObject::putDirectNonIndexAccessor(VM& vm, PropertyName propertyName, GetterSetter* accessor, unsigned attributes)
> {
>     PutPropertySlot slot(this);
>-    bool result = putDirectInternal<PutModeDefineOwnProperty>(vm, propertyName, value, attributes, slot);
>+    bool result = putDirectInternal<PutModeDefineOwnProperty>(vm, propertyName, accessor, attributes, slot);
> 
>     Structure* structure = this->structure(vm);
>     if (attributes & PropertyAttribute::ReadOnly)
>diff --git a/Source/JavaScriptCore/runtime/JSObject.h b/Source/JavaScriptCore/runtime/JSObject.h
>index e4e9b32ba083d1d98081bccbec68d1df7ab41f85..c811235e914d2a4b2a25e6453055fe6901335a32 100644
>--- a/Source/JavaScriptCore/runtime/JSObject.h
>+++ b/Source/JavaScriptCore/runtime/JSObject.h
>@@ -583,8 +583,8 @@ class JSObject : public JSCell {
>     bool putDirect(VM&, PropertyName, JSValue, unsigned attributes = 0);
>     bool putDirect(VM&, PropertyName, JSValue, PutPropertySlot&);
>     void putDirectWithoutTransition(VM&, PropertyName, JSValue, unsigned attributes = 0);
>-    bool putDirectNonIndexAccessor(VM&, PropertyName, JSValue, unsigned attributes);
>-    bool putDirectAccessor(ExecState*, PropertyName, JSValue, unsigned attributes);
>+    bool putDirectNonIndexAccessor(VM&, PropertyName, GetterSetter*, unsigned attributes);
>+    bool putDirectAccessor(ExecState*, PropertyName, GetterSetter*, unsigned attributes);
>     JS_EXPORT_PRIVATE bool putDirectCustomAccessor(VM&, PropertyName, JSValue, unsigned attributes);
> 
>     bool putGetter(ExecState*, PropertyName, JSValue, unsigned attributes);
>diff --git a/Source/JavaScriptCore/runtime/JSObjectInlines.h b/Source/JavaScriptCore/runtime/JSObjectInlines.h
>index 7209c3a0ad677c97f2f5600cc73e737c82814b91..4b0c8648ae20c973a4c7752f3487cb14961ed066 100644
>--- a/Source/JavaScriptCore/runtime/JSObjectInlines.h
>+++ b/Source/JavaScriptCore/runtime/JSObjectInlines.h
>@@ -272,12 +272,6 @@ ALWAYS_INLINE bool JSObject::putDirectInternal(VM& vm, PropertyName propertyName
>     ASSERT(!Heap::heap(value) || Heap::heap(value) == Heap::heap(this));
>     ASSERT(!parseIndex(propertyName));
> 
>-    switch (methodTable(vm)->reifyPropertyNameIfNeeded(this, globalObject(vm)->globalExec(), propertyName)) {
>-    case PropertyReificationResult::Nothing: break;
>-    case PropertyReificationResult::Something: break;
>-    case PropertyReificationResult::TriedButFailed: RELEASE_ASSERT_NOT_REACHED();
>-    }
>-
>     StructureID structureID = this->structureID();
>     Structure* structure = vm.heap.structureIDTable().get(structureID);
>     if (structure->isDictionary()) {

Flags:

saam: review+
ews-watchlist: commit-queue-

Actions: View | Formatted Diff | Diff

Attachments on bug 185350: 340081 | 340082 | 340083 | 340170 | 340482 | 340515