Attachment 340465 Details for Bug 185384 – Patch

[patch] Patch

bug-185384-20180515195604.patch (text/plain), 1.65 KB, created by youenn fablet on 2018-05-15 19:56:05 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: youenn fablet

Created: 2018-05-15 19:56:05 PDT

Size: 1.65 KB

patch

obsolete

>Subversion Revision: 231744
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index b1ba2e8ba315546bbaf222421754ed830c799ff2..bea779bbcbc9f3b0d19176f7e8e2c87ce02a04d2 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,15 @@
>+2018-05-15  Youenn Fablet  <youenn@apple.com>
>+
>+        Layout Test webrtc/addICECandidate-closed.html is a flaky failure
>+        https://bugs.webkit.org/show_bug.cgi?id=185384
>+        <rdar://problem/40035167>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * webrtc/addICECandidate-closed.html:
>+        Handle sometimes rejected promise to remove a line
>+        in the -expected.txt file that is sometimes added.
>+
> 2018-05-15  Youenn Fablet  <youenn@apple.com>
> 
>         NetworkLoadChecker should cancel its content extension retrieval task when being destroyed
>diff --git a/LayoutTests/webrtc/addICECandidate-closed.html b/LayoutTests/webrtc/addICECandidate-closed.html
>index 39eef0316e416962e9a3e9d84b01b750adeb8ddb..bd419ce3ade0c689d8bcf6c7d537f33def8d440f 100644
>--- a/LayoutTests/webrtc/addICECandidate-closed.html
>+++ b/LayoutTests/webrtc/addICECandidate-closed.html
>@@ -15,10 +15,8 @@ promise_test(async (test) => {
>         const localTracks = stream.getTracks();
>         [[sender, receiver], [receiver, sender]].forEach(([pc1, pc2]) => {
>             pc1.onicecandidate = ({ candidate }) => {
>-                try {
>-                    if (candidate)
>-                        pc2.addIceCandidate(candidate);
>-                } catch (e) { }
>+                if (candidate)
>+                    pc2.addIceCandidate(candidate).then(() => { }, () => { });
>                 pc1.close();
>             };
>         });

Actions: View | Formatted Diff | Diff

Attachments on bug 185384: 339733 | 340175 | 340187 | 340465