Attachment 340438 Details for Bug 185660 – Patch

[patch] Patch

bug-185660-20180515184627.patch (text/plain), 2.22 KB, created by valerie on 2018-05-15 15:46:28 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: valerie

Created: 2018-05-15 15:46:28 PDT

Size: 2.22 KB

patch

obsolete

>Subversion Revision: 231814
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index a043f4b68f9a905e82c0d70d14ff94ccb021e7d9..5a9df5d3baec7bd72410aeb45188f06756089ab7 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,14 @@
>+2018-05-15  Valerie R Young  <valerie@bocoup.com>
>+
>+        test262/Runner.pm: save to supplied expectation file if supplied
>+        https://bugs.webkit.org/show_bug.cgi?id=185660
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Scripts/test262/Runner.pm:
>+        (processCLI):
>+        (main):
>+
> 2018-05-15  Ryan Haddad  <ryanhaddad@apple.com>
> 
>         Unreviewed, rolling out r231763.
>diff --git a/Tools/Scripts/test262/Runner.pm b/Tools/Scripts/test262/Runner.pm
>index 7155b56db90b177a4d33c4e990c5adeef539fa29..f48cca2bf28e6f9a9a30e378410b5d5120d51d12 100755
>--- a/Tools/Scripts/test262/Runner.pm
>+++ b/Tools/Scripts/test262/Runner.pm
>@@ -208,10 +208,11 @@ sub processCLI {
>             " please specify with --results.";
>     }
> 
>-    if (! $ignoreExpectations && $specifiedExpectationsFile) {
>+    if ($specifiedExpectationsFile) {
>         $expectationsFile = abs_path($specifiedExpectationsFile);
>-        if (! -e $expectationsFile) {
>-            die "Error: Supplied expectations file $expectationsFile does not exist!";
>+        if (! -e $expectationsFile && ! $ignoreExpectations) {
>+            print("Warning: Supplied expectations file $expectationsFile does"
>+                  . " not exist. Running tests without expectation file.\n");
>         }
>     }
> 
>@@ -389,7 +390,7 @@ sub main {
>     if ( !$expect ) {
>         print $failcount . " tests failed\n";
>     } else {
>-        print $failcount . " expected tests failed\n";
>+        print $failcount . " tests failed in total\n";
>         print $newfailcount . " tests newly fail\n";
>         print $newpasscount . " tests newly pass\n";
>     }
>@@ -927,7 +928,7 @@ Overwrites the test262-expectations.yaml file with the current list of test262 f
> 
> =item B<--expectations, -e>
> 
>-Specify a expectations file.  If not provided, script will load local JSTests/test262/expectations.yaml
>+Specify a expectations file for loading and saving.  If not provided, script will load and save to JSTests/test262/expectations.yaml.
> 
> =item B<--ignore-expectations, -x>
>

Actions: View | Formatted Diff | Diff

Attachments on bug 185660: 340438