Attachment 340431 Details for Bug 185655 – Patch

[patch] Patch

bug-185655-20180516063003.patch (text/plain), 1.99 KB, created by Dean Jackson on 2018-05-15 13:30:04 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Dean Jackson

Created: 2018-05-15 13:30:04 PDT

Size: 1.99 KB

patch

obsolete

>Subversion Revision: 231578
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index be67c3c92afde02911f7282f4324032e6896f828..6995988efe5b44761c9e97b79c0e9ce86e1d2f99 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,19 @@
>+2018-05-15  Dean Jackson  <dino@apple.com>
>+
>+        Provide UIView and UIImage for zoom transition
>+        https://bugs.webkit.org/show_bug.cgi?id=185655
>+        <rdar://problem/40267224>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Provide a UIView* for the frameForPreviewItem to use as a source view.
>+        Also implement the transitionImageForPreviewItem delegate, even though
>+        we're returning nil.
>+
>+        * UIProcess/Cocoa/SystemPreviewControllerCocoa.mm:
>+        (-[_WKPreviewControllerDelegate previewController:frameForPreviewItem:inSourceView:]):
>+        (-[_WKPreviewControllerDelegate previewController:transitionImageForPreviewItem:contentRect:]):
>+
> 2018-05-15  Dean Jackson  <dino@apple.com>
> 
>         Update animation when presenting QuickLook
>diff --git a/Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm b/Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm
>index d5e7d187ea7cfb2fafb83cb4f6057561b54e6b2c..14b92d8b1a8edd738ef89928c4303c6ccaf72f71 100644
>--- a/Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm
>+++ b/Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm
>@@ -137,6 +137,7 @@ SOFT_LINK_CLASS(QuickLook, QLItem);
>     if (!presentingViewController)
>         return CGRectZero;
> 
>+    *view = presentingViewController.view;
>     CGRect frame = presentingViewController.view.frame;
>     // Create a smaller rectangle centered in the frame.
>     CGFloat halfWidth = frame.size.width / 2;
>@@ -145,6 +146,11 @@ SOFT_LINK_CLASS(QuickLook, QLItem);
>     return frame;
> }
> 
>+- (UIImage *)previewController:(QLPreviewController *)controller transitionImageForPreviewItem:(id <QLPreviewItem>)item contentRect:(CGRect *)contentRect
>+{
>+    return nil;
>+}
>+
> @end
> 
> namespace WebKit {

Flags:

graouts: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 185655: 340431