Attachment 340402 Details for Bug 185648 – Patch

[patch] Patch

bug-185648-20180515202517.patch (text/plain), 2.71 KB, created by Dean Jackson on 2018-05-15 03:25:19 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Dean Jackson

Created: 2018-05-15 03:25:19 PDT

Size: 2.71 KB

patch

obsolete

>Subversion Revision: 231578
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 3bf05b2cd379e4e9d5c45f64c92560978f9b3fb5..dce226ffd062540a2972fd64ab6d72246a25ceae 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,20 @@
>+2018-05-15  Dean Jackson  <dino@apple.com>
>+
>+        Update animation when presenting QuickLook
>+        https://bugs.webkit.org/show_bug.cgi?id=185648
>+        <rdar://problem/39652624>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Implement the QuickLook delegate on _WKPreviewControllerDelegate that
>+        produces a zoom-like animation when the QLPreviewController appears.
>+
>+        * UIProcess/Cocoa/SystemPreviewControllerCocoa.mm:
>+        (-[_WKPreviewControllerDelegate previewController:frameForPreviewItem:inSourceView:]):
>+        * UIProcess/SystemPreviewController.h: Add a reference back to the page, so that
>+        the delegate implementation can access the presentingViewController.
>+        (WebKit::SystemPreviewController::page):
>+
> 2018-05-14  Dean Jackson  <dino@apple.com>
> 
>         Download and present System Preview
>diff --git a/Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm b/Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm
>index 4baaeba54a66015f22c02ceb42655ff8efc82850..3a7cf6753841c80016a8a7f7fe80cbd2d4f5c637 100644
>--- a/Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm
>+++ b/Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm
>@@ -126,6 +126,23 @@ SOFT_LINK_CLASS(QuickLook, QLItem);
>     if (_previewController)
>         _previewController->cancel();
> }
>+
>+- (CGRect)previewController:(QLPreviewController *)controller frameForPreviewItem:(id <QLPreviewItem>)item inSourceView:(UIView * *)view
>+{
>+    if (!_previewController)
>+        return CGRectZero;
>+
>+    UIViewController *presentingViewController = _previewController->page().uiClient().presentingViewController();
>+
>+    if (!presentingViewController)
>+        return CGRectZero;
>+
>+    CGRect frame = presentingViewController.view.frame;
>+    // Create a small rectangle centered in the frame.
>+    frame = CGRectMake(CGRectGetMidX(frame) - 5, CGRectGetMidY(frame) - 5, 10, 10);
>+    return frame;
>+}
>+
> @end
> 
> namespace WebKit {
>diff --git a/Source/WebKit/UIProcess/SystemPreviewController.h b/Source/WebKit/UIProcess/SystemPreviewController.h
>index f9d4c9a883140305aa8259f43f42e1928e49221b..804b228bcc2141583408ad6918650e99940241c6 100644
>--- a/Source/WebKit/UIProcess/SystemPreviewController.h
>+++ b/Source/WebKit/UIProcess/SystemPreviewController.h
>@@ -51,6 +51,8 @@ public:
>     void finish(WebCore::URL);
>     void cancel();
> 
>+    WebPageProxy& page() { return m_webPageProxy; }
>+
> private:
>     WebPageProxy& m_webPageProxy;
> #if USE(QUICK_LOOK)

Flags:

graouts: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 185648: 340402