Attachment 340391 Details for Bug 185640 – Patch

[patch] Patch

bug-185640-20180514201336.patch (text/plain), 3.17 KB, created by Keith Miller on 2018-05-14 20:13:37 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Keith Miller

Created: 2018-05-14 20:13:37 PDT

Size: 3.17 KB

patch

obsolete

>Subversion Revision: 231784
>diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog
>index 088cc11dd416ca1f6e0f389885c8603b2d612757..e197ec1f8f6f2986657ed86b692843bad0b52c6f 100644
>--- a/Source/JavaScriptCore/ChangeLog
>+++ b/Source/JavaScriptCore/ChangeLog
>@@ -1,3 +1,17 @@
>+2018-05-14  Keith Miller  <keith_miller@apple.com>
>+
>+        Remove butterflyMask from DFGAbstractHeap
>+        https://bugs.webkit.org/show_bug.cgi?id=185640
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        We don't have a butterfly indexing mask anymore so we don't need
>+        the abstract heap information for it anymore.
>+
>+        * dfg/DFGAbstractHeap.h:
>+        * dfg/DFGClobberize.h:
>+        (JSC::DFG::clobberize):
>+
> 2018-05-14  Andy VanWagoner  <andy@vanwagoner.family>
> 
>         [INTL] Handle error in defineProperty for supported locales length
>diff --git a/Source/JavaScriptCore/dfg/DFGAbstractHeap.h b/Source/JavaScriptCore/dfg/DFGAbstractHeap.h
>index 20bc12a044b87c54880e01dc8cc317fc76c2dfca..4a4ebb1341fb4facd316838cbf8f68edb66145e6 100644
>--- a/Source/JavaScriptCore/dfg/DFGAbstractHeap.h
>+++ b/Source/JavaScriptCore/dfg/DFGAbstractHeap.h
>@@ -58,7 +58,6 @@ namespace JSC { namespace DFG {
>     macro(JSCell_typeInfoFlags) \
>     macro(JSCell_typeInfoType) \
>     macro(JSObject_butterfly) \
>-    macro(JSObject_butterflyMask) \
>     macro(JSPropertyNameEnumerator_cachedPropertyNames) \
>     macro(RegExpObject_lastIndex) \
>     macro(NamedProperties) \
>diff --git a/Source/JavaScriptCore/dfg/DFGClobberize.h b/Source/JavaScriptCore/dfg/DFGClobberize.h
>index ceeced85d9e7766c0da886a8d43aed336da9370e..0ba017a5edc9c9314268c3383b0fd9202b2fc70a 100644
>--- a/Source/JavaScriptCore/dfg/DFGClobberize.h
>+++ b/Source/JavaScriptCore/dfg/DFGClobberize.h
>@@ -551,7 +551,6 @@ void clobberize(Graph& graph, Node* node, const ReadFunctor& read, const WriteFu
>         read(JSCell_indexingType);
>         read(JSCell_structureID);
>         read(JSObject_butterfly);
>-        read(JSObject_butterflyMask);
>         read(Butterfly_publicLength);
>         read(IndexedDoubleProperties);
>         read(IndexedInt32Properties);
>@@ -567,7 +566,6 @@ void clobberize(Graph& graph, Node* node, const ReadFunctor& read, const WriteFu
>         read(JSCell_indexingType);
>         read(JSCell_structureID);
>         read(JSObject_butterfly);
>-        read(JSObject_butterflyMask);
>         read(Butterfly_publicLength);
>         switch (node->arrayMode().type()) {
>         case Array::Double:
>@@ -1138,7 +1136,6 @@ void clobberize(Graph& graph, Node* node, const ReadFunctor& read, const WriteFu
>         write(JSCell_structureID);
>         write(JSCell_indexingType);
>         write(JSObject_butterfly);
>-        write(JSObject_butterflyMask);
>         write(Watchpoint_fire);
>         return;
>         
>@@ -1190,7 +1187,6 @@ void clobberize(Graph& graph, Node* node, const ReadFunctor& read, const WriteFu
>     case MultiGetByOffset: {
>         read(JSCell_structureID);
>         read(JSObject_butterfly);
>-        read(JSObject_butterflyMask);
>         AbstractHeap heap(NamedProperties, node->multiGetByOffsetData().identifierNumber);
>         read(heap);
>         def(HeapLocation(NamedPropertyLoc, heap, node->child1()), LazyNode(node));

Actions: View | Formatted Diff | Diff

Attachments on bug 185640: 340391