Attachment 340375 Details for Bug 185634 – Patch

[patch] Patch

bug-185634-20180514163655.patch (text/plain), 1.46 KB, created by Megan Gardner on 2018-05-14 16:36:56 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Megan Gardner

Created: 2018-05-14 16:36:56 PDT

Size: 1.46 KB

patch

obsolete

>Index: Source/WebKit/ChangeLog
>===================================================================
>--- Source/WebKit/ChangeLog	(revision 231777)
>+++ Source/WebKit/ChangeLog	(working copy)
>@@ -1,3 +1,16 @@
>+2018-05-14  Megan Gardner  <megan_gardner@apple.com>
>+
>+        Clear selections from web content with single tap
>+        https://bugs.webkit.org/show_bug.cgi?id=185634
>+
>+        Reviewed by NOBODY (OOPS!).
>+        
>+        With the switch to the single text selection assistant, we were not correctly clearing the selection when a
>+        single tap happened.
>+
>+        * UIProcess/ios/WKContentViewInteraction.mm:
>+        (-[WKContentView _singleTapCommited:]):
>+
> 2018-05-14  Chris Dumez  <cdumez@apple.com>
> 
>         Overly aggressive timer throttling in service workers
>Index: Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
>===================================================================
>--- Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm	(revision 231726)
>+++ Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm	(working copy)
>@@ -1869,7 +1869,7 @@ - (void)_singleTapCommited:(UITapGesture
>     // The selection could have been set by autofocusing on page load and not
>     // reflected in the UI process since the user was not interacting with the page.
>     if (!_page->editorState().isContentEditable)
>-        [_webSelectionAssistant clearSelection];
>+        _page->clearSelection();
> 
>     _lastInteractionLocation = gestureRecognizer.location;
>

Flags:

thorton: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 185634: 340375