Attachment 340363 Details for Bug 185629 – Patch

[patch] Patch

bug-185629-20180514174956.patch (text/plain), 2.10 KB, created by valerie on 2018-05-14 14:49:57 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: valerie

Created: 2018-05-14 14:49:57 PDT

Size: 2.10 KB

patch

obsolete

>Subversion Revision: 231767
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 2d5b861428cedc18f6a928735fc2e521cbedd545..03cf5faaadf365f6d4220e8217b36a1392626d12 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,17 @@
>+2018-05-14  Valerie R Young  <valerie@bocoup.com>
>+
>+        test262/Runner.pm: small bugs in CLI and error codes
>+        https://bugs.webkit.org/show_bug.cgi?id=185629
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Fix two commandline args with use '-f', correct
>+        error code of failures.
>+
>+        * Scripts/test262/Runner.pm:
>+        (processCLI):
>+        (main):
>+
> 2018-05-14  Jeremy Jones  <jeremyj@apple.com>
> 
>         NSEvent event trackers don't work from WebKitTestRunner
>diff --git a/Tools/Scripts/test262/Runner.pm b/Tools/Scripts/test262/Runner.pm
>index 523e006883b4c3a5c2b14c859274936e17237bd5..4d4b5be44b55935e5e36c6d7da500e7c215718cf 100755
>--- a/Tools/Scripts/test262/Runner.pm
>+++ b/Tools/Scripts/test262/Runner.pm
>@@ -130,7 +130,7 @@ sub processCLI {
>         's|save' => \$saveExpectations,
>         'e|expectations=s' => \$specifiedExpectationsFile,
>         'x|ignore-expectations' => \$ignoreExpectations,
>-        'f|failing-files' => \$failingOnly,
>+        'F|failing-files' => \$failingOnly,
>         'l|latest-import' => \$latestImport,
>         'stats' => \$stats,
>         'r|results=s' => \$specifiedResultsFile,
>@@ -400,7 +400,8 @@ sub main {
>     my $totalTime = $endTime - $startTime;
>     print "Done in $totalTime seconds!\n";
> 
>-    exit $newfailcount ? 1 : 0;
>+    my $totalfailures = $expect ? $newfailcount : $failcount;
>+    exit ($totalfailures ? 1 : 0);
> }
> 
> sub loadImportFile {
>@@ -931,7 +932,7 @@ Specify a expectations file.  If not provided, script will load local JSTests/te
> 
> Ignores the test262-expectations.yaml file and outputs all failures, instead of only unexpected failures.
> 
>-=item B<--failing-files, -f>
>+=item B<--failing-files, -F>
> 
> Runs all test files that failed in a given results file (specifc with --results). This option will run the rests in both strict and non-strict modes, even if the test only fails in one of the two modes.
>

Actions: View | Formatted Diff | Diff

Attachments on bug 185629: 340363