Attachment 340361 Details for Bug 185627 – Patch

[patch] Patch

bug-185627-20180514143703.patch (text/plain), 3.52 KB, created by Per Arne Vollan on 2018-05-14 14:37:04 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Per Arne Vollan

Created: 2018-05-14 14:37:04 PDT

Size: 3.52 KB

patch

obsolete

>Index: Source/WebKit/ChangeLog
>===================================================================
>--- Source/WebKit/ChangeLog	(revision 231769)
>+++ Source/WebKit/ChangeLog	(working copy)
>@@ -1,3 +1,20 @@
>+2018-05-14  Per Arne Vollan  <pvollan@apple.com>
>+
>+        Pause display links when window is not visible.
>+        https://bugs.webkit.org/show_bug.cgi?id=185627
>+        <rdar://problem/39401106>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Pause/resume display links created in the UI process when the window is hidden/shown.
>+
>+        * UIProcess/WebPageProxy.cpp:
>+        (WebKit::WebPageProxy::dispatchActivityStateChange):
>+        * UIProcess/mac/DisplayLink.cpp:
>+        (WebKit::DisplayLink::pause):
>+        (WebKit::DisplayLink::resume):
>+        * UIProcess/mac/DisplayLink.h:
>+
> 2018-05-11  Brian Burg  <bburg@apple.com>
> 
>         Web Automation: Automation.getBrowsingContext returns window origin that differs from window.screenX/Y
>Index: Source/WebKit/UIProcess/WebPageProxy.cpp
>===================================================================
>--- Source/WebKit/UIProcess/WebPageProxy.cpp	(revision 231704)
>+++ Source/WebKit/UIProcess/WebPageProxy.cpp	(working copy)
>@@ -1582,8 +1582,13 @@ void WebPageProxy::dispatchActivityState
> #endif
> 
>     if (changed & ActivityState::IsVisible) {
>-        if (isViewVisible())
>+        if (isViewVisible()) {
>             m_visiblePageToken = m_process->visiblePageToken();
>+#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400
>+            if (m_displayLink)
>+                m_displayLink->resume();
>+#endif
>+        }
>         else {
>             m_visiblePageToken = nullptr;
> 
>@@ -1591,6 +1596,10 @@ void WebPageProxy::dispatchActivityState
>             // state, it might not send back a reply (since it won't paint anything if the web page is hidden) so we
>             // stop the unresponsiveness timer here.
>             m_process->responsivenessTimer().stop();
>+#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400
>+            if (m_displayLink)
>+                m_displayLink->pause();
>+#endif
>         }
>     }
> 
>Index: Source/WebKit/UIProcess/mac/DisplayLink.cpp
>===================================================================
>--- Source/WebKit/UIProcess/mac/DisplayLink.cpp	(revision 231704)
>+++ Source/WebKit/UIProcess/mac/DisplayLink.cpp	(working copy)
>@@ -81,6 +81,20 @@ bool DisplayLink::hasObservers() const
>     return !m_observers.isEmpty();
> }
> 
>+bool DisplayLink::pause()
>+{
>+    if (!CVDisplayLinkIsRunning(m_displayLink))
>+        return true;
>+    return CVDisplayLinkStop(m_displayLink) == kCVReturnSuccess;
>+}
>+
>+bool DisplayLink::resume()
>+{
>+    if (CVDisplayLinkIsRunning(m_displayLink))
>+        return true;
>+    return CVDisplayLinkStart(m_displayLink) == kCVReturnSuccess;
>+}
>+
> CVReturn DisplayLink::displayLinkCallback(CVDisplayLinkRef displayLinkRef, const CVTimeStamp*, const CVTimeStamp*, CVOptionFlags, CVOptionFlags*, void* data)
> {
>     WebPageProxy* webPageProxy = reinterpret_cast<WebPageProxy*>(data);
>Index: Source/WebKit/UIProcess/mac/DisplayLink.h
>===================================================================
>--- Source/WebKit/UIProcess/mac/DisplayLink.h	(revision 231704)
>+++ Source/WebKit/UIProcess/mac/DisplayLink.h	(working copy)
>@@ -45,6 +45,9 @@ public:
>     void removeObserver(unsigned observerID);
>     bool hasObservers() const;
> 
>+    bool pause();
>+    bool resume();
>+    
> private:
>     static CVReturn displayLinkCallback(CVDisplayLinkRef, const CVTimeStamp*, const CVTimeStamp*, CVOptionFlags, CVOptionFlags*, void* data);
>

Flags:

simon.fraser: review+
simon.fraser: commit-queue-

Actions: View | Formatted Diff | Diff

Attachments on bug 185627: 340361 | 340436 | 340449