WebKit Bugzilla
Attachment 340355 Details for
Bug 185575
: Overly aggressive timer throttling in service workers
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-185575-20180514140915.patch (text/plain), 20.33 KB, created by
Chris Dumez
on 2018-05-14 14:09:16 PDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Chris Dumez
Created:
2018-05-14 14:09:16 PDT
Size:
20.33 KB
patch
obsolete
>Subversion Revision: 231766 >diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog >index 6cd2a3e9b0dca0dd1640dcda71abf555aacb16d6..b843b5a7b40f3ff3d5297adbf4f69e1eba207efd 100644 >--- a/Source/WebKit/ChangeLog >+++ b/Source/WebKit/ChangeLog >@@ -1,3 +1,39 @@ >+2018-05-14 Chris Dumez <cdumez@apple.com> >+ >+ Overly aggressive timer throttling in service workers >+ https://bugs.webkit.org/show_bug.cgi?id=185575 >+ <rdar://problem/40219038> >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ After ~30 seconds, the system would put the service worker process in "App Nap", >+ causing its timers to get aggressively throttled. This happens because the >+ service worker processes are WebProcesses that have no visible WebPages. >+ >+ To address the issue, we now disable process suppression for all service worker >+ processes. This causes those processes to construct a UserActivity which prevents >+ App Nap. >+ >+ This patch also refactors the code a bit to avoid duplication. The ProcessSuppression >+ suppression logic in now all on ChildProcessProxy / ChildProcess. >+ >+ * NetworkProcess/NetworkProcess.messages.in: >+ * PluginProcess/PluginProcess.messages.in: >+ * Shared/ChildProcess.messages.in: >+ * UIProcess/ChildProcessProxy.cpp: >+ (WebKit::ChildProcessProxy::setProcessSuppressionEnabled): >+ * UIProcess/ChildProcessProxy.h: >+ * UIProcess/Network/NetworkProcessProxy.h: >+ * UIProcess/Network/mac/NetworkProcessProxyMac.mm: Removed. >+ * UIProcess/Plugins/PluginProcessProxy.h: >+ * UIProcess/Plugins/mac/PluginProcessProxyMac.mm: >+ * UIProcess/ServiceWorkerProcessProxy.cpp: >+ (WebKit::ServiceWorkerProcessProxy::didFinishLaunching): >+ * UIProcess/ServiceWorkerProcessProxy.h: >+ * UIProcess/WebProcessProxy.h: >+ * WebKit.xcodeproj/project.pbxproj: >+ * WebProcess/WebProcess.messages.in: >+ > 2018-05-14 Michael Catanzaro <mcatanzaro@igalia.com> > > -Wmemset-elt-size warning in LibWebRTCSocket constructor >diff --git a/Source/WebKit/NetworkProcess/NetworkProcess.messages.in b/Source/WebKit/NetworkProcess/NetworkProcess.messages.in >index 1ad1bb432b94be95db980eefe8c6aff190f45635..563a565f3e2bf0ef111afda4c209a5120cfa9b55 100644 >--- a/Source/WebKit/NetworkProcess/NetworkProcess.messages.in >+++ b/Source/WebKit/NetworkProcess/NetworkProcess.messages.in >@@ -52,7 +52,6 @@ messages -> NetworkProcess LegacyReceiver { > ContinueWillSendRequest(WebKit::DownloadID downloadID, WebCore::ResourceRequest request) > ContinueDecidePendingDownloadDestination(WebKit::DownloadID downloadID, String destination, WebKit::SandboxExtension::Handle sandboxExtensionHandle, bool allowOverwrite) > >- SetProcessSuppressionEnabled(bool flag) > #if PLATFORM(COCOA) > SetQOS(int latencyQOS, int throughputQOS) > SetCookieStoragePartitioningEnabled(bool enabled) >diff --git a/Source/WebKit/PluginProcess/PluginProcess.messages.in b/Source/WebKit/PluginProcess/PluginProcess.messages.in >index 1792f92500c7fb00ffaf7e6a99105d2fb51246f6..f346f7eb10f86a267c84f1fe73470b540b560c08 100644 >--- a/Source/WebKit/PluginProcess/PluginProcess.messages.in >+++ b/Source/WebKit/PluginProcess/PluginProcess.messages.in >@@ -38,7 +38,6 @@ messages -> PluginProcess LegacyReceiver { > DeleteWebsiteData(WallTime modifiedSince, uint64_t callbackID) > DeleteWebsiteDataForHostNames(Vector<String> hostNames, uint64_t callbackID) > >- SetProcessSuppressionEnabled(bool flag) > #if PLATFORM(COCOA) > SetQOS(int latencyQOS, int throughputQOS) > #endif >diff --git a/Source/WebKit/Shared/ChildProcess.messages.in b/Source/WebKit/Shared/ChildProcess.messages.in >index 062691fd271faa67ef1c4ae3cf39004877836e97..1dd1b1a32726a5835217dda0690a16ef2fb353e7 100644 >--- a/Source/WebKit/Shared/ChildProcess.messages.in >+++ b/Source/WebKit/Shared/ChildProcess.messages.in >@@ -23,4 +23,5 @@ > messages -> ChildProcess { > ShutDown() > RegisterURLSchemeServiceWorkersCanHandle(String scheme) >+ SetProcessSuppressionEnabled(bool flag) > } >diff --git a/Source/WebKit/UIProcess/ChildProcessProxy.cpp b/Source/WebKit/UIProcess/ChildProcessProxy.cpp >index 96511fdc04a015e9c94f01b8264eff0823f4e3e9..bdff583d3b1b92240f272775e14b03ecc017e40e 100644 >--- a/Source/WebKit/UIProcess/ChildProcessProxy.cpp >+++ b/Source/WebKit/UIProcess/ChildProcessProxy.cpp >@@ -213,6 +213,18 @@ void ChildProcessProxy::shutDownProcess() > m_connection = nullptr; > } > >+void ChildProcessProxy::setProcessSuppressionEnabled(bool processSuppressionEnabled) >+{ >+#if PLATFORM(COCOA) >+ if (state() != State::Running) >+ return; >+ >+ connection()->send(Messages::ChildProcess::SetProcessSuppressionEnabled(processSuppressionEnabled), 0); >+#else >+ UNUSED_PARAM(processSuppressionEnabled); >+#endif >+} >+ > void ChildProcessProxy::connectionWillOpen(IPC::Connection&) > { > } >diff --git a/Source/WebKit/UIProcess/ChildProcessProxy.h b/Source/WebKit/UIProcess/ChildProcessProxy.h >index 6d4802f60acf071d13dc065fcb7bca502a02e356..2d5f15c6f48398e1d70aaa43cfe27b63670c8edc 100644 >--- a/Source/WebKit/UIProcess/ChildProcessProxy.h >+++ b/Source/WebKit/UIProcess/ChildProcessProxy.h >@@ -83,6 +83,8 @@ public: > > WebCore::ProcessIdentifier coreProcessIdentifier() const { return m_processIdentifier; } > >+ void setProcessSuppressionEnabled(bool); >+ > protected: > // ProcessLauncher::Client > void didFinishLaunching(ProcessLauncher*, IPC::Connection::Identifier) override; >diff --git a/Source/WebKit/UIProcess/Network/NetworkProcessProxy.h b/Source/WebKit/UIProcess/Network/NetworkProcessProxy.h >index 6c690f3ed8a827743ecff1fa2eae47e2e411216a..8fc94db1da05958385ea9946075ca666bbb1c935 100644 >--- a/Source/WebKit/UIProcess/Network/NetworkProcessProxy.h >+++ b/Source/WebKit/UIProcess/Network/NetworkProcessProxy.h >@@ -76,10 +76,6 @@ public: > void deleteWebsiteData(PAL::SessionID, OptionSet<WebsiteDataType>, WallTime modifiedSince, WTF::Function<void()>&& completionHandler); > void deleteWebsiteDataForOrigins(PAL::SessionID, OptionSet<WebKit::WebsiteDataType>, const Vector<WebCore::SecurityOriginData>& origins, const Vector<String>& cookieHostNames, WTF::Function<void()>&& completionHandler); > >-#if PLATFORM(COCOA) >- void setProcessSuppressionEnabled(bool); >-#endif >- > #if HAVE(CFNETWORK_STORAGE_PARTITIONING) > void hasStorageAccessForFrame(PAL::SessionID, const String& resourceDomain, const String& firstPartyDomain, uint64_t frameID, uint64_t pageID, CompletionHandler<void(bool)>&& callback); > void getAllStorageAccessEntries(PAL::SessionID, CompletionHandler<void(Vector<String>&& domains)>&&); >diff --git a/Source/WebKit/UIProcess/Network/mac/NetworkProcessProxyMac.mm b/Source/WebKit/UIProcess/Network/mac/NetworkProcessProxyMac.mm >deleted file mode 100644 >index b8601e8391a9738ab99407443dd5fbf3d8095ee0..0000000000000000000000000000000000000000 >--- a/Source/WebKit/UIProcess/Network/mac/NetworkProcessProxyMac.mm >+++ /dev/null >@@ -1,43 +0,0 @@ >-/* >- * Copyright (C) 2012 Apple Inc. All rights reserved. >- * >- * Redistribution and use in source and binary forms, with or without >- * modification, are permitted provided that the following conditions >- * are met: >- * 1. Redistributions of source code must retain the above copyright >- * notice, this list of conditions and the following disclaimer. >- * 2. Redistributions in binary form must reproduce the above copyright >- * notice, this list of conditions and the following disclaimer in the >- * documentation and/or other materials provided with the distribution. >- * >- * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' >- * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, >- * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR >- * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS >- * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR >- * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF >- * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS >- * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN >- * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) >- * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF >- * THE POSSIBILITY OF SUCH DAMAGE. >- */ >- >-#import "config.h" >-#import "NetworkProcessProxy.h" >- >-#import "NetworkProcessMessages.h" >- >-using namespace WebCore; >- >-namespace WebKit { >- >-void NetworkProcessProxy::setProcessSuppressionEnabled(bool processSuppressionEnabled) >-{ >- if (state() != State::Running) >- return; >- >- connection()->send(Messages::NetworkProcess::SetProcessSuppressionEnabled(processSuppressionEnabled), 0); >-} >- >-} // namespace WebKit >diff --git a/Source/WebKit/UIProcess/Plugins/PluginProcessProxy.h b/Source/WebKit/UIProcess/Plugins/PluginProcessProxy.h >index 2530ffe34b4ed403c6c8c8d420db1574cbb4af3b..6c309708735c0a0fa7fbb82e05ddc108b5a29ad2 100644 >--- a/Source/WebKit/UIProcess/Plugins/PluginProcessProxy.h >+++ b/Source/WebKit/UIProcess/Plugins/PluginProcessProxy.h >@@ -84,11 +84,6 @@ public: > > bool isValid() const { return m_connection; } > >-#if PLATFORM(COCOA) >- void setProcessSuppressionEnabled(bool); >- >-#endif >- > #if PLUGIN_ARCHITECTURE(UNIX) > static bool scanPlugin(const String& pluginPath, RawPluginMetaData& result); > #endif >diff --git a/Source/WebKit/UIProcess/Plugins/mac/PluginProcessProxyMac.mm b/Source/WebKit/UIProcess/Plugins/mac/PluginProcessProxyMac.mm >index b7f7f1cd8c6e13dac7d42defbb73cef5034e42b5..73a132e9761c5406a2f7867c06a6c2bd83e88f5f 100644 >--- a/Source/WebKit/UIProcess/Plugins/mac/PluginProcessProxyMac.mm >+++ b/Source/WebKit/UIProcess/Plugins/mac/PluginProcessProxyMac.mm >@@ -230,14 +230,6 @@ void PluginProcessProxy::applicationDidBecomeActive() > makePluginProcessTheFrontProcess(); > } > >-void PluginProcessProxy::setProcessSuppressionEnabled(bool processSuppressionEnabled) >-{ >- if (!isValid()) >- return; >- >- m_connection->send(Messages::PluginProcess::SetProcessSuppressionEnabled(processSuppressionEnabled), 0); >-} >- > static bool isFlashUpdater(const String& launchPath, const Vector<String>& arguments) > { > if (launchPath != "/Applications/Utilities/Adobe Flash Player Install Manager.app/Contents/MacOS/Adobe Flash Player Install Manager") >diff --git a/Source/WebKit/UIProcess/ServiceWorkerProcessProxy.cpp b/Source/WebKit/UIProcess/ServiceWorkerProcessProxy.cpp >index b70b6734e1c9344436f741bc6be0022d22738570..e9956e417daef4cab22e4af8c0e87786fa31ef21 100644 >--- a/Source/WebKit/UIProcess/ServiceWorkerProcessProxy.cpp >+++ b/Source/WebKit/UIProcess/ServiceWorkerProcessProxy.cpp >@@ -105,6 +105,14 @@ void ServiceWorkerProcessProxy::didReceiveAuthenticationChallenge(uint64_t pageI > challenge->performDefaultHandling(); > } > >+void ServiceWorkerProcessProxy::didFinishLaunching(ProcessLauncher* launcher, IPC::Connection::Identifier connectionIdentifier) >+{ >+ WebProcessProxy::didFinishLaunching(launcher, connectionIdentifier); >+ >+ // Prevent App Nap for Service Worker processes. >+ setProcessSuppressionEnabled(false); >+} >+ > } // namespace WebKit > > #endif // ENABLE(SERVICE_WORKER) >diff --git a/Source/WebKit/UIProcess/ServiceWorkerProcessProxy.h b/Source/WebKit/UIProcess/ServiceWorkerProcessProxy.h >index 3351b74094be47e830e397c40681baa08298b5a3..cbdefdc38056b12dfc6b5f1c0ddd840c1ea6fe85 100644 >--- a/Source/WebKit/UIProcess/ServiceWorkerProcessProxy.h >+++ b/Source/WebKit/UIProcess/ServiceWorkerProcessProxy.h >@@ -54,6 +54,9 @@ private: > // ChildProcessProxy > void getLaunchOptions(ProcessLauncher::LaunchOptions&) final; > >+ // ProcessLauncher::Client >+ void didFinishLaunching(ProcessLauncher*, IPC::Connection::Identifier) final; >+ > bool isServiceWorkerProcess() const final { return true; } > > ServiceWorkerProcessProxy(WebProcessPool&, const WebCore::SecurityOriginData&, WebsiteDataStore&); >diff --git a/Source/WebKit/UIProcess/WebProcessProxy.h b/Source/WebKit/UIProcess/WebProcessProxy.h >index 6f5c8ae94fd6122c822e3e9d44ac3e6578cc63c5..964204a59e22c92814bef285affc4d02f7805b40 100644 >--- a/Source/WebKit/UIProcess/WebProcessProxy.h >+++ b/Source/WebKit/UIProcess/WebProcessProxy.h >@@ -230,6 +230,9 @@ protected: > void connectionWillOpen(IPC::Connection&) override; > void processWillShutDown(IPC::Connection&) override; > >+ // ProcessLauncher::Client >+ void didFinishLaunching(ProcessLauncher*, IPC::Connection::Identifier) override; >+ > private: > // Called when the web process has crashed or we know that it will terminate soon. > // Will potentially cause the WebProcessProxy object to be freed. >@@ -293,9 +296,6 @@ private: > void sendProcessDidResume() override; > void didSetAssertionState(AssertionState) override; > >- // ProcessLauncher::Client >- void didFinishLaunching(ProcessLauncher*, IPC::Connection::Identifier) override; >- > // Implemented in generated WebProcessProxyMessageReceiver.cpp > void didReceiveWebProcessProxyMessage(IPC::Connection&, IPC::Decoder&); > void didReceiveSyncWebProcessProxyMessage(IPC::Connection&, IPC::Decoder&, std::unique_ptr<IPC::Encoder>&); >diff --git a/Source/WebKit/WebKit.xcodeproj/project.pbxproj b/Source/WebKit/WebKit.xcodeproj/project.pbxproj >index 9fd2227f417143a663cb194e1a235a7a33d7ef93..37550be0e0c1d7ddbd0592a9db80cd4ed0379acc 100644 >--- a/Source/WebKit/WebKit.xcodeproj/project.pbxproj >+++ b/Source/WebKit/WebKit.xcodeproj/project.pbxproj >@@ -1074,7 +1074,6 @@ > 515E7727183DD6F60007203F /* AsyncRequest.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 515E7725183DD6F60007203F /* AsyncRequest.cpp */; }; > 515E7728183DD6F60007203F /* AsyncRequest.h in Headers */ = {isa = PBXBuildFile; fileRef = 515E7726183DD6F60007203F /* AsyncRequest.h */; }; > 5160BFE113381DF900918999 /* LoggingFoundation.mm in Sources */ = {isa = PBXBuildFile; fileRef = 5160BFE013381DF900918999 /* LoggingFoundation.mm */; }; >- 516319921628980A00E22F00 /* NetworkProcessProxyMac.mm in Sources */ = {isa = PBXBuildFile; fileRef = 516319911628980A00E22F00 /* NetworkProcessProxyMac.mm */; }; > 5163199416289A6000E22F00 /* NetworkProcessMessageReceiver.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 51ACC9341628064800342550 /* NetworkProcessMessageReceiver.cpp */; }; > 5163199516289A6300E22F00 /* NetworkProcessMessages.h in Headers */ = {isa = PBXBuildFile; fileRef = 51ACC9351628064800342550 /* NetworkProcessMessages.h */; }; > 516A4A5D120A2CCD00C05B7F /* APIError.h in Headers */ = {isa = PBXBuildFile; fileRef = 516A4A5B120A2CCD00C05B7F /* APIError.h */; }; >@@ -2072,7 +2071,6 @@ > CDA29A2B1CBEB67A00901CCF /* PlaybackSessionManagerProxyMessages.h in Headers */ = {isa = PBXBuildFile; fileRef = CDA29A271CBEB67A00901CCF /* PlaybackSessionManagerProxyMessages.h */; }; > CDC2831D201BD79D00E6E745 /* WKFullscreenStackView.h in Headers */ = {isa = PBXBuildFile; fileRef = CDC2831B201BD79D00E6E745 /* WKFullscreenStackView.h */; }; > CDC2831E201BD79D00E6E745 /* WKFullscreenStackView.mm in Sources */ = {isa = PBXBuildFile; fileRef = CDC2831C201BD79D00E6E745 /* WKFullscreenStackView.mm */; }; >- CDC382FE17211799008A2FC3 /* SecItemShimLibrary.mm in Sources */ = {isa = PBXBuildFile; fileRef = 511F8A78138B460900A95F44 /* SecItemShimLibrary.mm */; }; > CDCA85C8132ABA4E00E961DF /* WKFullScreenWindowController.mm in Sources */ = {isa = PBXBuildFile; fileRef = CDCA85C6132ABA4E00E961DF /* WKFullScreenWindowController.mm */; }; > CDCA85C9132ABA4E00E961DF /* WKFullScreenWindowController.h in Headers */ = {isa = PBXBuildFile; fileRef = CDCA85C7132ABA4E00E961DF /* WKFullScreenWindowController.h */; }; > CE11AD501CBC47F800681EE5 /* CodeSigning.mm in Sources */ = {isa = PBXBuildFile; fileRef = CE11AD4F1CBC47F800681EE5 /* CodeSigning.mm */; }; >@@ -3489,7 +3487,6 @@ > 515E7725183DD6F60007203F /* AsyncRequest.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = AsyncRequest.cpp; sourceTree = "<group>"; }; > 515E7726183DD6F60007203F /* AsyncRequest.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = AsyncRequest.h; sourceTree = "<group>"; }; > 5160BFE013381DF900918999 /* LoggingFoundation.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = LoggingFoundation.mm; sourceTree = "<group>"; }; >- 516319911628980A00E22F00 /* NetworkProcessProxyMac.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; name = NetworkProcessProxyMac.mm; path = mac/NetworkProcessProxyMac.mm; sourceTree = "<group>"; }; > 5164C0941B05B757004F102A /* ChildProcess.messages.in */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text; path = ChildProcess.messages.in; sourceTree = "<group>"; }; > 516A4A5B120A2CCD00C05B7F /* APIError.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = APIError.h; sourceTree = "<group>"; }; > 517A33B3130B308C00F80CB5 /* WKApplicationCacheManager.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = WKApplicationCacheManager.cpp; sourceTree = "<group>"; }; >@@ -4605,7 +4602,6 @@ > CDC2831B201BD79D00E6E745 /* WKFullscreenStackView.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; name = WKFullscreenStackView.h; path = ios/fullscreen/WKFullscreenStackView.h; sourceTree = "<group>"; }; > CDC2831C201BD79D00E6E745 /* WKFullscreenStackView.mm */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.objcpp; name = WKFullscreenStackView.mm; path = ios/fullscreen/WKFullscreenStackView.mm; sourceTree = "<group>"; }; > CDC382F717211506008A2FC3 /* CFNetwork.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = CFNetwork.framework; path = /System/Library/Frameworks/CFNetwork.framework; sourceTree = "<absolute>"; }; >- CDC3830617211799008A2FC3 /* WebProcessShim.dylib */ = {isa = PBXFileReference; explicitFileType = "compiled.mach-o.dylib"; includeInIndex = 0; path = WebProcessShim.dylib; sourceTree = BUILT_PRODUCTS_DIR; }; > CDC8F4881725E67800166F6E /* CoreFoundation.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = CoreFoundation.framework; path = /System/Library/Frameworks/CoreFoundation.framework; sourceTree = "<absolute>"; }; > CDCA85C6132ABA4E00E961DF /* WKFullScreenWindowController.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = WKFullScreenWindowController.mm; sourceTree = "<group>"; }; > CDCA85C7132ABA4E00E961DF /* WKFullScreenWindowController.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WKFullScreenWindowController.h; sourceTree = "<group>"; }; >@@ -6589,7 +6585,6 @@ > 516319931628980E00E22F00 /* mac */ = { > isa = PBXGroup; > children = ( >- 516319911628980A00E22F00 /* NetworkProcessProxyMac.mm */, > ); > name = mac; > sourceTree = "<group>"; >@@ -10704,7 +10699,6 @@ > 5163199416289A6000E22F00 /* NetworkProcessMessageReceiver.cpp in Sources */, > E14A954916E016A40068DE82 /* NetworkProcessPlatformStrategies.cpp in Sources */, > 5179556D162877B100FA43B6 /* NetworkProcessProxy.cpp in Sources */, >- 516319921628980A00E22F00 /* NetworkProcessProxyMac.mm in Sources */, > 513A163C163088F6005D7D22 /* NetworkProcessProxyMessageReceiver.cpp in Sources */, > 51FD18B51651FBAD00DBE1CE /* NetworkResourceLoader.cpp in Sources */, > E152551A17011819003D7ADB /* NetworkResourceLoaderMessageReceiver.cpp in Sources */, >@@ -11450,14 +11444,6 @@ > ); > runOnlyForDeploymentPostprocessing = 0; > }; >- CDC382FD17211799008A2FC3 /* Sources */ = { >- isa = PBXSourcesBuildPhase; >- buildActionMask = 2147483647; >- files = ( >- CDC382FE17211799008A2FC3 /* SecItemShimLibrary.mm in Sources */, >- ); >- runOnlyForDeploymentPostprocessing = 0; >- }; > /* End PBXSourcesBuildPhase section */ > > /* Begin PBXTargetDependency section */ >diff --git a/Source/WebKit/WebProcess/WebProcess.messages.in b/Source/WebKit/WebProcess/WebProcess.messages.in >index efb07e3fa3b503c794385fec3ade7e36a2bdedc6..fa4c0662238aa82fcbb5b84b0fbf3afc08238a00 100644 >--- a/Source/WebKit/WebProcess/WebProcess.messages.in >+++ b/Source/WebKit/WebProcess/WebProcess.messages.in >@@ -84,7 +84,6 @@ messages -> WebProcess LegacyReceiver { > DeleteWebsiteDataForOrigins(PAL::SessionID sessionID, OptionSet<WebKit::WebsiteDataType> websiteDataTypes, Vector<WebCore::SecurityOriginData> origins) -> () > > SetHiddenPageDOMTimerThrottlingIncreaseLimit(int milliseconds) >- SetProcessSuppressionEnabled(bool flag) > #if PLATFORM(COCOA) > SetQOS(int latencyQOS, int throughputQOS) > #endif
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 185575
:
340355
|
340359